Repository navigation
ci: keep PR text out of the required dash check, and let PR title runs finish - #23
Merged
Merged
Conversation
…s finish The required no-emdash job scanned the tracked files and the pull request's title, body and commit messages. A Dependabot body quotes upstream release notes, so a dash there turned a required check red. The job keeps its name and now scans the tracked files only; a new job, no-emdash-messages, scans the PR text and is not required. The dash workflow and the PR title caller ran under concurrency groups that cancel. A push and an edit that land together (Dependabot does both) start two runs and one is cancelled; when the cancelled run is in the newer check suite, the required context counts as failing until someone re-runs it. A group without cancel-in-progress still cancels a queued run, so both blocks are removed and every short run finishes. The docs that described the PR-text scan or the required checks are corrected to match. Claude-Session: https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for checks that blocked pull requests falsely once they became required.
The dash check. The required
no-emdashjob scanned the tracked files and the pull request's title, body and commit messages. A Dependabot body quotes upstream release notes, so a dash there turned the required check red. The job keeps its id, so theci-required-checksruleset needs no change, and now scans the tracked files only. A new job in the same workflow,no-emdash-messages, scans the title, body and commit messages. It is not required: it still goes red on such a body, as the prompt to edit the dash out before merging (the body becomes the squash commit), but it cannot block the merge.Cancelled runs.
pr-title.ymlandno-emdash.ymlran oneditedunder concurrency groups that cancel. Dependabot pushes and edits at the same moment, which starts two runs, and the group cancels one; when the cancelled run sits in the newer check suite, the required context counts as failing until someone re-runs it. A group withoutcancel-in-progressstill cancels a queued run, so both blocks are removed and every short run finishes.Also corrected to match: CLAUDE.md's gate section, which said
no-emdashscans the PR text.Checked locally:
no-emdashandclaude-cardfrom @cosyte/script-utils 0.1.4 and the commit-message scan pass, every starter passesnpm ciandnpm test, and actionlint 1.7.12 with shellcheck 0.11.0 is clean over every workflow.https://claude.ai/code/session_01MXLcW95gf97vs9RBU1YsXf