Repository navigation
[6.x] Added form modal and slideout actions to Table node cells - #19843
Merged
brandonkelly merged 12 commits intoOct 6, 2026
Conversation
📚 Storybook previews@craftcms/ui — open Storybook Changed components: resources/js — open Storybook No changed components detected in this Storybook. |
…tes' into feature/6.x-table-node-cell-actions
Save the Storybook cache under a key unique to each run and restore it by the content-hash prefix. With a fixed key, a run cancelled by cancel-in-progress while saving held the reservation, so the next run couldn't save it, and its deploy jobs restored nothing and failed to find Storybook. Deploy jobs now fail fast on a cache miss. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`$prefix` ran straight into the substituted run ID, so bash read it as one undefined variable and the key came out as `-1` for every run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
brandonkelly
merged commit Oct 6, 2026
a8033ce
into
feature/6.x-form-component-compatibility-and-usage-updates
9 checks passed
Member
|
@lukeholder sorry, I accidentally merged this before @nfourtythree had a chance to approve. Any changes could be made on #19665 though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lets a Form
Tablenode's cells do more than link out, so a table can act on a row without leaving the screen. Commerce's inventory stock levels screen needs this for its set, adjust and move quantity actions and for editing an inventory item.['label', 'modalUrl', 'actionUrl', 'params']instead of a link. It opens the existingFormModal:modalUrlis requested withparamsand returns{form, title?, submitLabel?}, and submitting posts the form's values plusparamstoactionUrl, then reloads the table.'slideout' => trueopens its URL's screen withopenSlideout()and reloads the table once that screen is saved. A modified click still follows the link.slot="invoker", socraft-action-menuhad no trigger and filed the button away with its content. It now gets the slot attributesActionMenupasses to its invoker.plainand flush, and its chevron only shows while the row is hovered or focused or the menu is open. It stays visible where there is no hover.idno longer crash the table.getRowIdreturned"undefined"for every row with noid, and the duplicate row ids sentDataTableinto a render loop (Maximum recursive updates exceeded). Rows now fall back to their index.Table::rows()only documentsidas needed for reordering and deleting.Generated with Claude Code