Repository navigation
[6.x] Fix per-site statuses for saved elements - #19868
Merged
Merged
Conversation
ElementHelper::siteStatusesForElement() selected the bare `enabled` column, which the element query maps to `elements.enabled`, so every site reported the element's global status instead of its own. Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ElementHelper::siteStatusesForElement()selected the bareenabledcolumn, which the element query maps toelements.enabled. For a saved, enabled element, every site reported as enabled, including sites where it's disabled. 5.x avoids this by selectingelements_sites.enabledexplicitly; this restores that.This affected the per-site status toggles on element edit pages, and
resavewith--propagate-to, which could re-enable entries on sites where they were disabled.Extracted from #19665.