Repository navigation
[6.x] Save draft-less nested elements in place - #19869
Merged
Merged
Conversation
Saving a nested element through a slideout redirected it into the owner's draft whenever an owner draft was prepared, which needs a draft of the nested element. Element types without drafts never get one, so the save failed with "Could not save the nested element draft." They now save in place, matching 5.x. Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Saving a nested element from a slideout moves its changes into the owner's draft whenever the opener prepared one. That move needs a draft of the nested element, so element types without drafts (Commerce variants, for example) failed with “Could not save the nested element draft.” They now save in place, the same as in 5.x.
The fix applies to the Vue element editor, the Vue-hosted legacy editor, and the legacy editor opened from nested element cards.
Extracted from #19665.