Repository navigation
[6.x] Name table cells once, after their column and row - #19890
Merged
Merged
Conversation
Checkbox and select cells were labelled by both their own label and the field label, so screen readers read the name twice. Adds a browser test covering every cell type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
brianjhanson
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes how table cells are named for screen readers, and adds a browser test that checks it.
craft-selectas well, which had named it twice.This replaces
PreviewTargetsTable.test.ts, which was added in fa3848b and lost in #19888 when preview targets were rebuilt on the form builder'sTableControl. That test only checked that the Auto-Refresh lightswitch was named after its column header. The new test covers all cell types (text, lightswitch, checkbox and the prefix select), not just lightswitches.🤖 Generated with Claude Code