Repository navigation
docs: correct ReDoS guard description for exclude_patterns (closes #1196) - #1197
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1196
Changes
docs/build-packaging.md: step 3 now describesPcreLimitGuardsetting the PCRE limits once per filtering pass ([Performance] ExcludePattern::matches() performs 4 ini_set() calls per invocation (tidy-up, ~20ms per build) #568) instead of around everypreg_matchcall.docs/security.md: new "PHAR Exclude Patterns (ReDoS Protection)" section. The other hardenings whose comments [Refactor] Lint rule: forbid narrative comments, allow only bare docblock tags #1194 removed (zip-slip, redirect scheme, master fingerprint, static files) were already documented there.Changelog
[Unreleased] → Fixedentry (#1196).Proof of Work
Docs-only change, no review rounds.
Code Review