Repository navigation
fix(fingerprint): name the leaked temp file when rename fails and cleanup fails - #1202
Open
rootsiemen wants to merge 1 commit into
Open
rootsiemen wants to merge 1 commit into
rootsiemen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1176
MasterFingerprint::writeTo()handled a failedrename()with@unlink($tempPath)but ignored the unlink result and did not name the temp path in the exception. If both failed, the temp file leaked silently.writeTo()now logs the temp path witherror_log()and includes it in theRuntimeExceptionmessage, so the leaked file is visible and removable. The message is unchanged when the unlink succeeds.fingerprintfail://test wrapper gains anunlinkFailsoption, and a new testtestWriteToNamesTempFileWhenRenameAndUnlinkBothFailasserts the exception and the log both name the temp path (verified to fail on the old code: the message carried no temp path).Verified locally:
tests/MasterFingerprintTest.php23 tests green,composer lintgreen except pre-existingshellcheck(untouchedbin/worktree-done.sh) and missinghadolintin this environment.