Skip to content

fix: read sleep respiration average from the correct API field #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyberjunky merged 1 commit into from
Sep 12, 2026
Merged

fix: read sleep respiration average from the correct API field #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion garminconnect/typed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ class DailySleepDTO(_BaseResponse):
avg_sleep_hrv: float | None = Field(default=None, alias="avgSleepHRV")
avg_spo2: float | None = Field(default=None, alias="avgSpO2")
avg_respiration_value: float | None = Field(
default=None, alias="avgRespirationValue"
default=None, alias="averageRespirationValue"
)
lowest_respiration_value: float | None = Field(
default=None, alias="lowestRespirationValue"
Expand Down
3 changes: 2 additions & 1 deletion tests/test_typed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def garmin() -> garminconnect.Garmin:
"sleepEndTimestampGMT": 1761125400000,
"avgSleepHRV": 52.3,
"avgSpO2": 96.0,
"avgRespirationValue": 14.2,
"averageRespirationValue": 14.2,
"sleepScores": {
"overall": {"value": 84, "qualifierKey": "GOOD"},
"totalDuration": {"value": 90, "qualifierKey": "EXCELLENT"},
Expand Down Expand Up @@ -242,6 +242,7 @@ def test_get_sleep_data_returns_nested_dto(garmin: garminconnect.Garmin) -> None
assert sleep.daily_sleep_dto.sleep_time_seconds == 25200
assert sleep.daily_sleep_dto.deep_sleep_seconds == 5400
assert sleep.daily_sleep_dto.avg_sleep_hrv == 52.3
assert sleep.daily_sleep_dto.avg_respiration_value == 14.2
# Nested scores are also typed
assert sleep.daily_sleep_dto.sleep_scores is not None
assert sleep.daily_sleep_dto.sleep_scores.overall is not None
Expand Down