Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typed workout helpers support pace, speed, cadence, power, and heart-rate targets, but swimming CSS offsets still require manually constructing the secondary target fields.
This adds
SwimCssOffsetTarget(offset_seconds=...)andTargetType.SWIM_CSS_OFFSET(17,swim.css.offset). Both targeted step helpers now accept an omitted primary target, so callers can use Garmin'sno.targetprimary with a CSS offset as the secondary target. Existing calls remain compatible.The offset is a signed value rather than a lower/upper range: it is serialized into
secondaryTargetValueOne, withsecondaryTargetValueTwo=0. Non-finite offsets and primary placement are rejected. The README includes a secondary-only example; interval types and swimming stroke/rest/pool configuration are otherwise unchanged.Validation
TestTokenFilePath.test_absolute_path_outside_home_still_alloweduses/var/lib/...; on macOS/varis a symlink and the token path guard rejects it. Neither the test nor the client code was changed.Maintainer review
This is a draft proposal based on a downstream serializer's existing CSS payload shape, not a new captured Garmin response or a live upload performed for this PR. Please confirm the signed-offset interpretation, units, and
secondaryTargetValueTwo=0convention against Garmin before merging. No live-account tests or private workout/account data are included.