pool: Fix properties tests to use the correct property#8060
Merged
mksahakyan merged 1 commit into11.2from Apr 2, 2026
Merged
Conversation
Motivation: While only tests, these files use an obsolete property name `pool.hotfile.monitoring.enable`, and could cause/perpetuate confusion and errors in user configuration. Modification: `pool.hotfile.monitoring.enable` changed to `pool.hotfile.replication.enable` in all cases. Result: Property name use in tests now comports with user applications. Target: master Request: 11.2 Patch: https://rb.dcache.org/r/14654/diff/raw Closes: Requires-notes: yes Requires-book: no Acked-by: Anastasiia Chub
There was a problem hiding this comment.
Pull request overview
Updates the pool hotfile monitoring test configuration to use the current pool property name, aligning test setup with the production Spring wiring and avoiding confusion from an obsolete property key.
Changes:
- Replaced
pool.hotfile.monitoring.enablewithpool.hotfile.replication.enablein the Spring test XML. - Updated
@TestPropertySourcevalues inHotfileMonitoringTestto set the correct property for enabled/disabled scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/dcache/src/test/resources/org/dcache/pool/classic/hotfile-monitoring-test.xml | Switches the SpEL/property-placeholder toggle to pool.hotfile.replication.enable. |
| modules/dcache/src/test/java/org/dcache/pool/classic/HotfileMonitoringTest.java | Updates test property injection to match the new property name in both nested test classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
While only tests, these files use an obsolete property name
pool.hotfile.monitoring.enable, and could cause/perpetuate confusion and errors in user configuration.Modification:
pool.hotfile.monitoring.enablechanged topool.hotfile.replication.enablein all cases.Result:
Property name use in tests now comports with user applications.
Target: master
Request: 11.2
Patch: https://rb.dcache.org/r/14654/diff/raw
Closes:
Requires-notes: yes
Requires-book: no
Acked-by: Anastasiia Chub