Skip to content

bench.sh: say why a test failed - #288

Open
derSteFfi wants to merge 1 commit into
daanx:masterfrom
derSteFfi:bench_fail_details
Open

derSteFfi wants to merge 1 commit into
daanx:masterfrom
derSteFfi:bench_fail_details

Conversation

@derSteFfi

Copy link
Copy Markdown
Contributor

A run's own output goes to <test>-<alloc>-out.txt and that file does not reach a CI log, so a test that dies says nothing beyond its name: in the failing jobs for #287 the log shows the run starting and the next test starting 0.1 s later, with no error text anywhere. Report the exit status - naming the signal when the run was killed by one - and the tail of the output file, on stderr so buildkit records it.

A run's own output goes to <test>-<alloc>-out.txt and that file does not reach a
CI log, so a test that dies says nothing beyond its name: in the failing rocksdb
jobs the log shows the run starting and the next test starting 0.1 s later, with
no error text anywhere. Report the exit status - naming the signal when the run
was killed by one - and the tail of the output file, on stderr so buildkit
records it.

Name a signal only when the shell knows that number, and always keep the status:
a program can exit() above 128 as well, and guarder's fatal errors do (exit 255),
which an unconditional 128 offset would report as a nonexistent "signal 127".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant