Skip to content

build-bench-env.sh: let ff align jumbo allocations - #290

Open
derSteFfi wants to merge 1 commit into
daanx:masterfrom
derSteFfi:ff_jumbo_align
Open

derSteFfi wants to merge 1 commit into
daanx:masterfrom
derSteFfi:ff_jumbo_align

Conversation

@derSteFfi

@derSteFfi derSteFfi commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

rbstress fails for ff on ubuntu after 4 seconds: ruby 3.2 asks for posix_memalign(32 KB, 32 MB) while it starts up, and ffmalloc answered EINVAL for every request above page alignment that reaches its jumbo path ("until that's fixed"). ruby reads the NULL as out of memory and aborts in ruby_setup, so both rbstress tests die before the benchmark begins. Fedora's ruby 4 makes no such request, which is why only ubuntu is red.

Ask for the alignment in excess in the shared jumbo path and return an aligned address inside the pool. A pointer inside a jumbo pool is valid to free because free(), realloc() and malloc_usable_size() resolve the pool that contains the pointer, so this needs no bookkeeping and the three refusals in posix_memalign, memalign and aligned_alloc go away.

While working on this I discovered what seems to be a race-condition for at least xmalloc, but I'll look into that separately.

rbstress fails for ff on ubuntu after 4 seconds: ruby 3.2 asks for
posix_memalign(32 KB, 32 MB) while it starts up, and ffmalloc answered
EINVAL for every request above page alignment that reaches its jumbo
path ("until that's fixed"). ruby reads the NULL as out of memory and
aborts in ruby_setup, so both rbstress tests die before the benchmark
begins. Fedora's ruby 4 makes no such request, which is why only ubuntu
is red.

Ask for the alignment in excess in the shared jumbo path and return an
aligned address inside the pool. A pointer inside a jumbo pool is valid
to free because free(), realloc() and malloc_usable_size() resolve the
pool that contains the pointer, so this needs no bookkeeping and the
three refusals in posix_memalign, memalign and aligned_alloc go away.
@derSteFfi
derSteFfi marked this pull request as draft November 12, 2026 16:59
@derSteFfi
derSteFfi marked this pull request as ready for review November 12, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant