Repository navigation
fix(cli): team send requires --from member per kernel contract - #271
Merged
Merged
Conversation
…268) Live e2e against agent-studio v0.16.1 (upstream #710 fixed) exposed two defects in cmdSend: 1. Default sender "lead" is not an entity — fusion-harness team_runtime.send validates BOTH sender and recipient against the declared member list, so every default send returned "unknown member: lead". --from is now required. 2. The --from flag parser did not strip the flag tokens from the message body ("msg --from bob" delivered the flag text). Fake UDS daemon in tests now mirrors the kernel member-validation semantics (previous fixture accepted any sender — test passed for the wrong reason). 3 new cases: --from delivery, missing --from rejection, flag-leak regression. Verified: 10/10 team tests, 1272 unit pass, tsc/biome clean, live daemon flow register/duplicate-reject/send/task/status/disband green.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268.
Problem
Live e2e against agent-studio v0.16.1 (upstream #710 fixed, daemon restarted) exposed two defects in
fusion-code team send:"lead"is not an entity. fusion-harnessteam_runtime.sendvalidates BOTH sender and recipient against the declared member list. Every default send returnedunknown member: lead.--fromflag leaked into the message body. The parser did not strip flag tokens, sosend t alice msg --from bobdelivered"msg --from bob".Fix
--from SENDERis now required (must be a declared manifest member); usage error otherwise.Verification
team not registered