Repository navigation
fix(install): resume-download loop for truncated transfers - #277
Merged
Merged
Conversation
Flaky networks/proxies kill large CDN transfers mid-stream (observed: HTTP/2 PROTOCOL_ERROR and byte-stream truncation at 3-24MB across 10+ attempts to release-assets.githubusercontent.com). curl -C - resumes from the byte offset, up to 8 attempts; the sha256 check still guarantees integrity of the assembled file (verified: truncated 24.1MB partial mismatches official SHA256SUMS and is rejected).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Live verification of the install script against the real v0.8.5 release exposed that flaky networks/proxies truncate large CDN transfers mid-stream: HTTP/2
PROTOCOL_ERRORand byte-stream truncation (3-24MB) across 10+ attempts torelease-assets.githubusercontent.com. A single-shotcurl --retrydoes not recover — it does not resume from the byte offset.Fix
Download wrapped in an 8-attempt loop with
curl -C -(byte-offset resume). Integrity is still guaranteed by the sha256 check againstSHA256SUMS.txt— verified live that a truncated 24.1MB partial mismatches the official checksum (38cbfef7…vs computed37c0ad54…) and is rejected.Verification