Skip to content

feat: better auth#5701

Merged
rebelchris merged 25 commits intomainfrom
feat-better-auth
Mar 16, 2026
Merged

feat: better auth#5701
rebelchris merged 25 commits intomainfrom
feat-better-auth

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 11, 2026

Changes

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://feat-better-auth.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 16, 2026 11:55am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 16, 2026 11:55am

Request Review

@rebelchris
Copy link
Contributor Author

@claude make sure all circleCI is happy and green

@claude
Copy link
Contributor

claude bot commented Mar 11, 2026

Claude finished @rebelchris's task in 35m 36s —— View job


Checking CircleCI Status

  • Check CI status for the PR
  • Identify failing/problematic tests
  • Fix useRegistration.ts - implement auto sign-in after sign-up
  • Add @marsidev/react-turnstile mock in jest config
  • Fix RegistrationForm.tsx - display hints['traits.email'] error
  • Fix RegistrationForm.spec.tsx - BetterAuth test setup issues
  • Fix AccountSecurityPage.tsx - BetterAuth test waitForNock issue

Issues Found

packages/shared tests (RegistrationForm.spec.tsx)

  1. renderBetterAuthRegistration calls waitForNock() but Kratos interceptors (set up by renderComponent()) are never consumed when isBetterAuth=true — causes timeout
  2. Form submission blocked by @marsidev/react-turnstile returning undefined in JSDOM (not mocked)
  3. Experience level dropdown not selected → form validation fails early
  4. Second email check (from RegistrationForm.handleFormSubmit) needs a nock mock
  5. Missing feature: auto sign-in after sign-up in useRegistration.ts (the BETTER_AUTH_SIGNUP_FALLBACK_ERROR constant is defined but never used)
  6. hints['traits.email'] not rendered in RegistrationForm, so error message never appears in DOM

packages/webapp tests (AccountSecurityPage.tsx)
7. Better Auth test calls waitForNock() after renderComponent() which sets up Kratos interceptors never consumed with isBetterAuth=true

@rebelchris rebelchris requested a review from capJavert March 11, 2026 13:47
@rebelchris rebelchris requested a review from idoshamun March 12, 2026 11:46
@rebelchris rebelchris merged commit 52c41da into main Mar 16, 2026
11 checks passed
@rebelchris rebelchris deleted the feat-better-auth branch March 16, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants