feat(search): add daily-dev-ask upsell banner on search page#5732
Open
feat(search): add daily-dev-ask upsell banner on search page#5732
Conversation
Add a dismissible banner promoting daily-dev-ask to Plus users on the web search page. Follows the DigestBookmarkBanner pattern with dismiss persistence via ActionType and analytics logging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The CTA button now calls completeAction so the banner won't reappear after the user clicks through to /agents/ask. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move AskSearchBanner from page children (renders after feed) to feedHeader layout prop (renders before feed). Add feedHeader slot to MainFeedLayout so pages can inject content above the feed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the feedHeader prop and pass AskSearchBanner via the existing searchChildren prop. On mobile, searchChildren renders inside the LayoutHeader (existing behavior). On laptop, it now also renders directly above the feed to ensure the banner appears above results on all viewports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move AskSearchBanner from the main feed area into the search page sidebar (PageWidgets), rendered above Related Tags for a better fit in the layout. Adapt styling for sidebar width and revert the searchChildren approach from MainFeedLayout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Title: "WebSearch for Developers" Content: updated messaging about community vetted articles and trusted developer content. CTA: "Try /daily-dev-ask" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When neither navChildren nor searchChildren are provided, the LayoutHeader rendered an empty <header> element with mb-6 and min-h-14 classes, creating a visible gap on mobile search. Skip rendering when there is no content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add `ask_upsell_search` feature flag via GrowthBook for A/B testing - Gate banner rendering on feature flag with shouldEvaluate only when user is authenticated, Plus, and hasn't dismissed - Show banner above search results on mobile/tablet - Remove banner from sidebar on desktop (laptop+) - Add tests for feature flag gating and conditional evaluation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AskSearchBannercomponent promoting daily-dev-ask to Plus users on the web search pageDigestBookmarkBannerpattern: accent-cabbage border card with icon, title, description, CTA link, and close buttonActionType.AskUpsellSearchusing the existingcompleteActionmutationKey decisions
/agents/askviaButtonwithtag="a"ActionTypevalueask_upsell_search: Stable string persisted in DB — chosen to be clear and consistent with existing namingTest plan
AskSearchBanner.spec.tsxcovering:/agents/askcompleteActionCloses ENG-1074
Created by Huginn 🐦⬛
Preview domain
https://eng-1074-add-daily-dev-ask-upsel.preview.app.daily.dev