Skip to content

fix(shared): shorten squad leave button copy#5733

Merged
rebelchris merged 3 commits intomainfrom
eng-1067-bug-in-webapp-mobile-view-the-button-leave-squad-overflows
Mar 16, 2026
Merged

fix(shared): shorten squad leave button copy#5733
rebelchris merged 3 commits intomainfrom
eng-1067-bug-in-webapp-mobile-view-the-button-leave-squad-overflows

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Mar 16, 2026

Summary

  • change the shared SquadActionButton default leave label from Leave Squad to Leave
  • update the affected squad card specs to assert the shorter label
  • remove redundant leave: "Leave" overrides that now inherit the shared default

Key Decisions

  • fixed the overflow by shortening the shared default copy instead of adding layout-specific CSS
  • kept the existing Leave Squad menu item and confirmation flow unchanged because they are outside the constrained button surface

Closes ENG-1067


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1067-bug-in-webapp-mobile-vi.preview.app.daily.dev

@vercel
Copy link

vercel bot commented Mar 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Mar 16, 2026 11:30am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Mar 16, 2026 11:30am

Request Review

@rebelchris rebelchris merged commit acf61a1 into main Mar 16, 2026
5 of 7 checks passed
@rebelchris rebelchris deleted the eng-1067-bug-in-webapp-mobile-view-the-button-leave-squad-overflows branch March 16, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant