Skip to content

[bug] MergeSettings drops every installer hook once the user overlay defines a hooks… #2829

Open

Description

@donatellobruno

What happened

MergeSettings drops every installer hook once the user overlay defines a hooks key. settings.system.json ships without hooks (the installer writes them straight into settings.json), so mergeSettingsPreserving carries them forward only while neither layer defines hooks. Adding one hook by hand to settings.json makes SettingsBackport write a hooks append annotation into settings.user.json; from then on the overlay defines hooks, and the next regeneration leaves settings.json with only that one hook. MergeSettings.ts --check showed it before any damage; we restored both files from backups.

Summary

A hand-added hook in settings.json gets backported into the user overlay as a hooks append annotation. Because settings.system.json has no hooks key, the overlay then becomes the only layer that defines hooks, and mergeSettingsPreserving stops carrying the installer's hooks forward. The next regeneration would leave settings.json with only the one hand-added hook.

Repro: hand-add one SessionStart hook to settings.json, start a session (SettingsBackport runs), then bun LIFEOS/TOOLS/MergeSettings.ts --check.

Suggested fix: for INSTALLER_OWNED_KEYS, when the overlay defines the key but the system layer does not, merge the overlay onto the existing output's value instead of replacing it, or have SettingsBackport skip installer-owned keys.

Details

  • Kind: bug
  • LifeOS version: 8.761.0

Filed with the LifeOS /feedback command. The reporter approved this exact text before it was sent; paths, secrets and personal details were stripped locally.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions