Skip to content

fix(pulse): a closed session's card stops saying "running" - #2664

Closed
rfdiazpr wants to merge 1 commit into
danielmiessler:mainfrom
rfdiazpr:fix/pulse-session-label
Closed

rfdiazpr wants to merge 1 commit into
danielmiessler:mainfrom
rfdiazpr:fix/pulse-session-label

Conversation

@rfdiazpr

@rfdiazpr rfdiazpr commented Nov 8, 2026

Copy link
Copy Markdown

Fixes #2663.

SessionExpanded printed · running and now-minus-start for every untracked session, so a closed card kept counting up. Display only; how observability.ts decides active, stale or complete is unchanged. The card now shows:

  • "running" and the elapsed time while active is true (unchanged);
  • "ended after " (start to completedAt) when the session ended explicitly (currentPhase === "COMPLETE");
  • "not active, end not recorded" otherwise, because observability.ts also gives a stale session a completedAt (its last activity) without a recorded end.

SessionExpanded is exported so the test can render it.

Before / after (fresh v8.761.0 install, synthetic session that ran 10 minutes and ended about 6 hours earlier, headless Chromium):

before
after

An active session read "running 20m 14s" before and after.

Testing evidence

  • New components/activity/WorkBoard.session.test.tsx (3 cases, renderToStaticMarkup, as in MarkdownRenderer.test.tsx): unpatched 1 pass, 2 fail; patched 3 of 3. With MarkdownRenderer.test.tsx, 6 of 6 pass, in the isolated folder and in the fresh install.
  • Fresh-system check (README → Contributing, step 3): v8.761.0 installed with the official bootstrap and InstallAll.ts on a Raspberry Pi 5 (Ubuntu 26.04, arm64, bun 1.3.14) in a disposable sandbox with synthetic data. The installation was attempted but did not complete: every step through Migrate succeeded; CoreServices failed for modelsync and pulse-menubar (as in InstallModelSync.ts has no Linux branch, so InstallAll exits non-zero on every Linux install #2646) and for conduit and conduit.insight (my sandbox withheld a user session). That installer problem is outside this patch. In that install the Pulse dashboard built successfully both unpatched and patched (next build, 60 pages), and the before/after above was captured from those two builds.
  • ISA-backed cards (ClimbExpanded) are untouched: the diff changes line 263 (the export) and lines 290-291 inside SessionExpanded only. A separate render check, not included here, gave identical HTML from the original and patched files in 4 of 4 cases.
  • tsc on WorkBoard.tsx through the project tsconfig: one error before and after, unchanged, in the untouched src/components/activity/QuickPulseStrip.tsx(195,14) (TS2322 on a <style jsx> element). No new errors.

Limits: the installation did not complete (above); the browser check was headless Chromium inside that sandbox only, not a desktop browser; the stale case does not appear on the board in that setup and is covered by the unit test only; results are from one machine.

AI assistance: prepared with an AI coding assistant (Claude) and reviewed by me.

…ssler#2663)

SessionExpanded showed "running" and now-minus-start for every untracked
session. It now shows running time only while active, "ended after <duration>"
for an explicit end, and "not active, end not recorded" otherwise. Display only.
@danielmiessler

Copy link
Copy Markdown
Owner

Note

🤖 Kai (AI assistant) responding on behalf of Daniel Miessler

Thanks @rfdiazpr, your PR stopped a closed session's card on the Pulse work board from saying 'running', in LIFEOS/PULSE/Observability/src/components/activity/WorkBoard.tsx. We re-landed the change in our source tree rather than merging the PR, because the public repo is generated from that tree at each release, and credit stays with you. It ships in the next public release after 8.761.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulse work board: a closed untracked session's card says "running" and its time keeps growing

2 participants