Repository navigation
Conversation
…ssler#2663) SessionExpanded showed "running" and now-minus-start for every untracked session. It now shows running time only while active, "ended after <duration>" for an explicit end, and "not active, end not recorded" otherwise. Display only.
Owner
|
Note 🤖 Kai (AI assistant) responding on behalf of Daniel Miessler Thanks @rfdiazpr, your PR stopped a closed session's card on the Pulse work board from saying 'running', in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2663.
SessionExpandedprinted· runningand now-minus-start for every untracked session, so a closed card kept counting up. Display only; howobservability.tsdecidesactive, stale or complete is unchanged. The card now shows:activeis true (unchanged);completedAt) when the session ended explicitly (currentPhase === "COMPLETE");observability.tsalso gives a stale session acompletedAt(its last activity) without a recorded end.SessionExpandedis exported so the test can render it.Before / after (fresh v8.761.0 install, synthetic session that ran 10 minutes and ended about 6 hours earlier, headless Chromium):
An active session read "running 20m 14s" before and after.
Testing evidence
components/activity/WorkBoard.session.test.tsx(3 cases,renderToStaticMarkup, as inMarkdownRenderer.test.tsx): unpatched 1 pass, 2 fail; patched 3 of 3. WithMarkdownRenderer.test.tsx, 6 of 6 pass, in the isolated folder and in the fresh install.InstallAll.tson a Raspberry Pi 5 (Ubuntu 26.04, arm64, bun 1.3.14) in a disposable sandbox with synthetic data. The installation was attempted but did not complete: every step throughMigratesucceeded;CoreServicesfailed formodelsyncandpulse-menubar(as in InstallModelSync.ts has no Linux branch, so InstallAll exits non-zero on every Linux install #2646) and forconduitandconduit.insight(my sandbox withheld a user session). That installer problem is outside this patch. In that install the Pulse dashboard built successfully both unpatched and patched (next build, 60 pages), and the before/after above was captured from those two builds.ClimbExpanded) are untouched: the diff changes line 263 (the export) and lines 290-291 insideSessionExpandedonly. A separate render check, not included here, gave identical HTML from the original and patched files in 4 of 4 cases.tsconWorkBoard.tsxthrough the project tsconfig: one error before and after, unchanged, in the untouchedsrc/components/activity/QuickPulseStrip.tsx(195,14)(TS2322 on a<style jsx>element). No new errors.Limits: the installation did not complete (above); the browser check was headless Chromium inside that sandbox only, not a desktop browser; the stale case does not appear on the board in that setup and is covered by the unit test only; results are from one machine.
AI assistance: prepared with an AI coding assistant (Claude) and reviewed by me.