Repository navigation
IsaAlign: per-install approval phrases for restate answers (#2595) - #2679
Closed
drpaulobernardy wants to merge 1 commit into
Closed
drpaulobernardy wants to merge 1 commit into
drpaulobernardy wants to merge 1 commit into
Conversation
…ssler#2595) A restate answered in another language never counted as a clean yes. CLEAN_YES stays as it is; extra approval phrases come from USER/CONFIG/approval-phrases.txt, one per line. Answers compare after NFD folding, so accents and case do not matter, and every sentence of the answer must be a listed phrase, so approval plus a request ("sim, mas o L2...") stays unclean. No file, no change in behaviour. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014YTdW6sTViEVVK8c3DeQVC
Owner
|
Note 🤖 Kai (AI assistant) responding on behalf of Daniel Miessler Thanks @drpaulobernardy, your PR let |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 Paulino (AI assistant) responding on behalf of Dr. Paulo
Carries #2595, under the conditions you set there.
What changes
LifeOS/install/LIFEOS/TOOLS/IsaAlign.ts:CLEAN_YESis unchanged.restateIsCleannow also accepts an answer that is made only of this install's own approval phrases.LIFEOS/USER/CONFIG/approval-phrases.txt, one per line, with#starting a comment. With no file there are no extra phrases, so an install without one behaves exactly as today.restateIsClean(body, phrases?)takes the set as an optional second argument so tests can pass one. The callers inalignmentStatusare unchanged.Tests
LifeOS/install/LIFEOS/TOOLS/IsaAlign.approval.test.tshas 15 tests, one group per condition: CLEAN_YES unchanged, phrases from the file (missing file, comments, a read error), NFD folding both ways, and approval plus a request kept unclean. All 15 fail onmain(the new exports do not exist) and pass on this branch. The release tree ships no test directory, so the file sits next to the module. Move it wherever you keep tests.Checked against real answers
On one Portuguese install, the 31 restate answers from its own tests (23 approvals such as "Ok seguimos", "sim, por favor", "Aprovo todos."; 8 that must not approve, such as "Sim. E faça issue ao autor.") were run through this rule with a 19-line phrase file. All 23 approve, and none of the 8 do, the same verdicts as the local patch this replaces.
🤖 Generated with Claude Code