Repository navigation
fix(pulse): let configured kanban columns take precedence over legacy aliases (#2796) - #2801
Open
isihussain wants to merge 1 commit into
Open
isihussain wants to merge 1 commit into
isihussain wants to merge 1 commit into
Conversation
… aliases (danielmiessler#2796) When a user adds a column to KANBAN_COLUMNS that matches a status remapped by LEGACY_STATUS_ALIASES (e.g. "Ready" where "ready" maps to "Queued"), deriveColumn previously applied the alias first, placing all Status:ready items into Queued and leaving Ready empty. Update deriveColumn to look for a configured column matching the raw status first, falling back to LEGACY_STATUS_ALIASES only when no configured column matches. Export deriveColumn and add work.columns.test.ts covering configured and fallback scenarios. Closes danielmiessler#2796 Signed-off-by: isihussain <isihussain@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2796.
In the Pulse Work board (LIFEOS/PULSE/modules/work.ts), when a user configured KANBAN_COLUMNS with a column whose name matches an aliased status (such as Ready, where
eady is mapped to Queued in LEGACY_STATUS_ALIASES), deriveColumn() previously resolved LEGACY_STATUS_ALIASES[raw] before inspecting configured columns.
As a result, issues with Status:ready were remapped to Queued even when Ready existed as an explicit column in columns.
Solution
Signed-off-by: isihussain isihussain@users.noreply.github.com