Repository navigation
fix(boundary): resolve root prefix and permission checks on Windows (#2774) - #2802
Open
isihussain wants to merge 1 commit into
Open
isihussain wants to merge 1 commit into
isihussain wants to merge 1 commit into
Conversation
…anielmiessler#2774) In confinedPath(), absolute path resolution previously initialized cur to sep ('/', or '\' on Windows). On Windows, this prepended a backslash to drive letters ('\C:'), producing ENOENT and causing every absolute path inside root to be wrongly refused as null. Additionally, paths with mixed forward/backward slashes were not split consistently. In atomicWrite(), the mode invariant checked POSIX permission bits (0o777), which always fails on Windows where fstat reports 0o666. Fix confinedPath to initialize rootPrefix from parse(p).root and split path segments on both '/' and '\'. Gate POSIX permission checks and chmodSync in ensureDir and atomicWrite to non-Windows platforms. Add Boundary.test.ts covering path containment, traversal rejection, and atomic file creation. Closes danielmiessler#2774 Signed-off-by: isihussain <isihussain@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2774.
The Boundary.ts module provides system-wide path containment and atomic write primitives (confinedPath, �tomicWrite). On Windows systems, two defects caused all boundary-checked absolute writes and memory operations to fail:
ull. Additionally, paths using mixed / and \ separators were not split properly.
Solution
Signed-off-by: isihussain isihussain@users.noreply.github.com