feature - implement RFC 022 hashing functions (#39)#49
Draft
dannymeijer wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the first RFC 022 format-function slice: deterministic string hashing helpers. It adds registry-backed
md5,sha224,sha256,sha384,sha512, andsha2helpers, records stable Substrait extension anchors for the concrete helpers, and keepssha2(...)as a compatibility rewrite over supported literal bit lengths. RFC 022 remains In Progress because JSON, CSV, URL, and dynamic-value helper semantics are still explicitly future scope.Type of change
docs/rfcs/*)Area(s)
Select the primary areas touched (labels sync from checked lines when the triage workflow runs):
Key details
md5(...), concrete SHA-2 helpers, orsha2(expr, 224|256|384|512).sha2(...)is a compatibility helper that rewrites to the matching concrete SHA-2 helper and rejects unsupported digest lengths before backend lowering.Testing / verification
make fmtincan test tests/test_hashing_functions.incnincan test tests/test_function_registry.incnincan test tests/test_substrait_plan.incnincan test tests/test_session_projection.incnmake fmt-checkmake test-stylemake registry-metadatamake buildmake testmake smoke-consumermake pre-commitManual verification notes:
make testandmake pre-commitboth passed with 146 tests.make registry-metadatapassed with 92 helpers.incan.lock is out of datewarnings appeared as expected; this PR does not refresh the lock.Docs impact
If docs updated:
docs/language/reference/functions/format.md,docs/language/reference/functions/index.md,docs/release_notes/v0_1.md,docs/rfcs/022_semi_structured_format_functions.md,docs/rfcs/README.mdChecklist
Stack order: merge after #48. This PR is partial RFC 022 scope and should not close the RFC issue yet.
Refs #39