MAINT: remove explicit xp.complex128 imports#430
Open
ev-br wants to merge 7 commits intodata-apis:masterfrom
Open
MAINT: remove explicit xp.complex128 imports#430ev-br wants to merge 7 commits intodata-apis:masterfrom
ev-br wants to merge 7 commits intodata-apis:masterfrom
Conversation
ev-br
changed the title
NB: while at it, note that complex64 cases used to generate values of 32 bits for *both real and imag parts*: so in a range of complex32 / two float16.
Reuse real_dtype_for/complex_dtype_for, which encapsulate the same mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #431
scalarsstrategy.While at it, note that complex64 cases used to generate values of 32 bits for both real and imag parts: so in a range of complex32 / two float16.
TODO: test locally. Thedone, tested locally, no new problemsscalarsstrategy is fairly deep in the stack.widest_{real,complex}_dtypetodtype_helpers, use intest_special_cases