feat(query): virtual column support materialized cte#19902
Open
b41sh wants to merge 5 commits into
Open
Conversation
Contributor
🤖 CI Job Analysis
📊 Summary
❌ NO RETRY NEEDEDAll failures appear to be code/test issues requiring manual fixes. 🔍 Job Details
🤖 AboutAutomated analysis using job annotations to distinguish infrastructure issues (auto-retried) from code/test issues (manual fixes needed). |
c84d932 to
c79fbf9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c79fbf971f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Materialized CTEs can hide the original Variant column path from the virtual column rewrite. For example, after a CTE projects
v['message'] AS message, downstream expressions such asmessage['attribute']['user_id']are bound against the materialized CTE output instead of the original table column. As a result, the planner can no longer recover the full pathv['message']['attribute']['user_id'], so virtual column pushdown is missed.This also affects large chained CTE queries where a reused CTE is auto-materialized: downstream consumers may repeatedly read large intermediate Variant objects instead of extracting only the required nested fields earlier.
This PR adds a binder-side rewrite for auto-materialized CTEs that preserves static Variant path access across CTE boundaries.
The following examples show the original SQL and the rewritten SQL
other changes
add_internal_column_into_exprandadd_virtual_column_into_exprhave been modified to addinternal_columnandvirtual_columnin batches, thereby avoiding redundant operationscolumn_mappingofMaterializedCTERefhas been changed fromHashMaptoBTreeMapto ensure the stability of theEXPLAINresultsfixes: #[Link the issue here]
Tests
Type of change
This change is