Repository navigation
for_each_task checks on databricks bundle validate - #4104
Open
idelafuente-oc wants to merge 8 commits into
Open
idelafuente-oc wants to merge 8 commits into
idelafuente-oc wants to merge 8 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #3977
Changes
Adds to the
databricks bundle validatethe ability to detect properties wrongly added to the parent task in for_each_task.Currently it checks for:
Can easily be extended to other configs with it's custom check.
Why
Currently
databricks bundle validatedoesn't detect this kind of issues, only on deployment this error was thrown. I think it's a good idea to add to the validate logic this typos of checks to prevent issues early on.Tests
I have tested this changes by building the wheel locally with the changes implemented, here is the output of a validate run over code with the issue:

I also added the unit tests for this.