Make auto-generated files non-executable (set mode to 0644)#5423
Draft
janniklasrose wants to merge 1 commit into
Draft
Make auto-generated files non-executable (set mode to 0644)#5423janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
genkit writes its generated output with mode 0755 (openapi/genkit sync.go and render.go), but the execute bit is meaningless for Go sources and a GitHub Actions workflow YAML. Normalize the generated command files plus tagging.yml and tagging.py to 0644 so they match every other workflow file and stop producing spurious mode diffs on regeneration. Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 6953fa8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
genkitwrites its generated output with mode0755. This PR changes the files to 0644. Upstream fix togenkitis pending.Why
Source files should not be executable files.
Tests
Co-authored-by: Isaac