bundle/dms: record deployment_mode on the deployment version#5445
Merged
shreyas-goenka merged 1 commit intoJun 4, 2026
Merged
Conversation
Co-authored-by: Isaac
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Jun 4, 2026
shreyas-goenka
merged commit 06061ae
into
shreyas-goenka/deployment-metadata-service
22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Record the bundle target deployment mode on each DMS version. Adds a
deployment_modefield (and theDEPLOYMENT_MODE_DEVELOPMENT/DEPLOYMENT_MODE_PRODUCTIONenum) totmpdms.Version, and sets it in theCreateVersionrequest frombundle.mode.Not set on the deployment:
Deployment.deployment_modeis derived server-side from the most recent version's mode (output-only), so the CLI only sets it on the version. A target with nomodemaps to an empty value, which is omitted (the server treats it as unspecified) — we don't fabricate a default.Why
The SDK's
bundle.Versionalready carriesdeployment_mode("captured at the time of this version"), but the CLI never populated it, so every version recorded a null mode. This stamps it so each version records whether it was a development or production deployment.Tests
Added a unit test for the mode mapping (development / production / unset). The
bundle/dmsacceptance outputs are unchanged because those targets don't set a mode. Verified live against a workspace: amode: developmenttarget now recordsdeployment_mode: DEPLOYMENT_MODE_DEVELOPMENTon the created version.This pull request and its description were written by Isaac, an AI coding agent.