Fix flag names in bundle generate dashboard error message#5449
Merged
Conversation
The fallback error in resolveID referenced --dashboard-path and --dashboard-id, which are not real flags for this command. Use the actual flag names --existing-path and --existing-id. Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 00d4d65 |
andrewnester
approved these changes
Jun 5, 2026
Collaborator
|
Commit: 9138455 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix the flag names in the
bundle generate dashboardfallback error.resolveIDreferenced--dashboard-path/--dashboard-id, which are not flags of this command; the real flags are--existing-path/--existing-id.Why
The message printed flag names that don't exist, which would mislead anyone who hit it.
Tests
Existing
cmd/bundle/generateunit tests andbundle/generate/dashboard*acceptance tests pass. No test asserted the old string.This PR was written by Claude Code.