Skip to content

direct: don't send undeclared app user_api_scopes in update mask - #7193

Open
denik wants to merge 9 commits into
mainfrom
denik/apps-partial-update
Open

denik wants to merge 9 commits into
mainfrom
denik/apps-partial-update

Conversation

@denik

@denik denik commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Changes

user_api_scopes is only in the apps update mask when the bundle declares it (or removes it, which clears it). Out-of-band changes to it no longer plan an update.

Why

Every apps update sent user_api_scopes in the mask, so changing e.g. the description cleared scopes the bundle doesn't manage, like jobs added at the account level. The update API can't set jobs (rejected as an invalid scope) but does clear the field, and the mask accepts only the whole field.

Tests

New acceptance tests update-declared-scopes, update-omitted-scopes and update-removed-scopes. The testserver now clears masked fields missing from the body, like the real API.

This pull request and its description were written by Isaac.

@github-actions github-actions Bot added the DABs DABs related issues label Oct 27, 2026
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 056644754 | Workflow run

Regression test report

Selected 8 changed tests (limit=20, 0 not selected)

16 tests: regression=14 unreleased=0 coverage=2 failing=0
test branch main (a96c087) latest (v1.27.0)
TestAccept/bundle/resources/apps/lifecycle-started/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/lifecycle-started/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/missing-service-principal/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/missing-service-principal/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/source-code-path-update/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/source-code-path-update/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-compute-size/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-compute-size/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-declared-scopes/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-declared-scopes/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-omitted-scopes/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/update-removed-scopes/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/apps/update-removed-scopes/DMS=true ✅ ✅ ✅
TestAccept/bundle/resources/apps/update/DMS= ✅ ❌ ❌
TestAccept/bundle/resources/apps/update/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/apps/lifecycle-started/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/lifecycle-started/output.txt
        +++ /tmp/TestAcceptbundleresourcesappslifecycle-startedDMS=2910369581/002/output.txt
        @@ -96,7 +96,7 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         
        @@ -124,7 +124,7 @@
               "description": "MY_APP_DESCRIPTION_3",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/lifecycle-started/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/lifecycle-started/output.txt
        +++ /tmp/TestAcceptbundleresourcesappslifecycle-startedDMS=true785485771/002/output.txt
        @@ -96,7 +96,7 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         
        @@ -124,7 +124,7 @@
               "description": "MY_APP_DESCRIPTION_3",
               "name": "[UNIQUE_NAME]"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/missing-service-principal/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/missing-service-principal/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsmissing-service-principalDMS=1909021400/002/output.txt
        @@ -45,7 +45,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/missing-service-principal/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/missing-service-principal/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsmissing-service-principalDMS=t232865958/002/output.txt
        @@ -45,7 +45,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         
        
FAIL

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/source-code-path-update/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/source-code-path-update/output.txt
        +++ /tmp/TestAcceptbundleresourcesappssource-code-path-updateDMS=2190191204/002/output.txt
        @@ -64,6 +64,6 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "test-app-source-code-path-update"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/source-code-path-update/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/source-code-path-update/output.txt
        +++ /tmp/TestAcceptbundleresourcesappssource-code-path-updateDMS=tru4167361544/002/output.txt
        @@ -64,6 +64,6 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "test-app-source-code-path-update"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-compute-size/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-compute-size/out.requests.json
        +++ /tmp/TestAcceptbundleresourcesappsupdate-compute-sizeDMS=2526782894/001/out.requests.json
        @@ -20,7 +20,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_size,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {
        @@ -31,6 +31,6 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-compute-size/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-compute-size/out.requests.json
        +++ /tmp/TestAcceptbundleresourcesappsupdate-compute-sizeDMS=true1887297181/001/out.requests.json
        @@ -20,7 +20,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_size,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_size,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {
        @@ -31,6 +31,6 @@
               "description": "MY_APP_DESCRIPTION_2",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-declared-scopes/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-declared-scopes/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsupdate-declared-scopesDMS=2425859705/002/output.txt
        @@ -19,8 +19,10 @@
         === Plan after out-of-band change
         
         >>> [CLI] bundle plan
        -Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged
        +update apps.mykey
         
        +Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged
        +
         === Change description and re-deploy; declared scopes are in the mask, so the remote value is replaced
         
         >>> update_file.py databricks.yml my_app_description MY_APP_DESCRIPTION

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-declared-scopes/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-declared-scopes/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsupdate-declared-scopesDMS=true1989907733/002/output.txt
        @@ -19,8 +19,10 @@
         === Plan after out-of-band change
         
         >>> [CLI] bundle plan
        -Plan: 0 to add, 0 to change, 0 to delete, 1 unchanged
        +update apps.mykey
         
        +Plan: 0 to add, 1 to change, 0 to delete, 0 unchanged
        +
         === Change description and re-deploy; declared scopes are in the mask, so the remote value is replaced
         
         >>> update_file.py databricks.yml my_app_description MY_APP_DESCRIPTION

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-omitted-scopes/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsupdate-omitted-scopesDMS=2647736019/002/output.txt
        @@ -24,10 +24,7 @@
         >>> [CLI] apps get myappname
         {
           "description": "MY_APP_DESCRIPTION",
        -  "user_api_scopes": [
        -    "sql",
        -    "jobs"
        -  ]
        +  "user_api_scopes": null
         }
         
         >>> [CLI] bundle destroy --auto-approve
        
    acceptance_test.go:1388: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1388
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1141
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:692
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations\"\n  }\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations\"\n  }\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -8,3 +8,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=
        	Messages:   	bundle/resources/apps/update-omitted-scopes/out.deploy.requests.json vs /tmp/TestAcceptbundleresourcesappsupdate-omitted-scopesDMS=2647736019/001/out.deploy.requests.json

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update-omitted-scopes/output.txt
        +++ /tmp/TestAcceptbundleresourcesappsupdate-omitted-scopesDMS=true1937961525/002/output.txt
        @@ -24,10 +24,7 @@
         >>> [CLI] apps get myappname
         {
           "description": "MY_APP_DESCRIPTION",
        -  "user_api_scopes": [
        -    "sql",
        -    "jobs"
        -  ]
        +  "user_api_scopes": null
         }
         
         >>> [CLI] bundle destroy --auto-approve
        
    acceptance_test.go:1388: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1388
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1141
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:692
        	Error:      	Not equal: 
        	            	expected: "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations\"\n  }\n}\n"
        	            	actual  : "{\n  \"method\": \"POST\",\n  \"path\": \"/api/2.0/apps/myappname/update\",\n  \"body\": {\n    \"app\": {\n      \"description\": \"MY_APP_DESCRIPTION\",\n      \"name\": \"myappname\"\n    },\n    \"update_mask\": \"description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations\"\n  }\n}\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -8,3 +8,3 @@
        	            	     },
        	            	-    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        	            	+    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        	            	   }
        	Test:       	TestAccept/bundle/resources/apps/update-omitted-scopes/DMS=true
        	Messages:   	bundle/resources/apps/update-omitted-scopes/out.deploy.requests.json vs /tmp/TestAcceptbundleresourcesappsupdate-omitted-scopesDMS=true1937961525/001/out.deploy.requests.json

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update/DMS=: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update/out.requests.json
        +++ /tmp/TestAcceptbundleresourcesappsupdateDMS=1949720834/001/out.requests.json
        @@ -18,7 +18,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {

latest (v1.27.0): same output as main (a96c087)

TestAccept/bundle/resources/apps/update/DMS=true: branch ✅ | main (a96c087) ❌ | latest (v1.27.0) ❌

main (a96c087):

acceptance_test.go:1388: Diff:
        --- bundle/resources/apps/update/out.requests.json
        +++ /tmp/TestAcceptbundleresourcesappsupdateDMS=true4254696647/001/out.requests.json
        @@ -18,7 +18,7 @@
               "description": "MY_APP_DESCRIPTION",
               "name": "myappname"
             },
        -    "update_mask": "description,budget_policy_id,usage_policy_id,resources,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
        +    "update_mask": "description,budget_policy_id,usage_policy_id,resources,user_api_scopes,compute_min_instances,compute_max_instances,git_repository,git_source,telemetry_export_destinations"
           }
         }
         {

latest (v1.27.0): same output as main (a96c087)

@denik
denik marked this pull request as ready for review October 27, 2026 11:46
@denik
denik requested review from a team as code owners October 27, 2026 11:46
@denik denik changed the title direct: don't clear app user_api_scopes on unrelated updates direct: don't send undeclared app user_api_scopes in update mask Oct 27, 2026
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 0566447

Run: 44530960183

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 4 272 26 15:01
💚​ aws-windows-latest-4core-16gb 4 274 24 16:05
💚​ azure linux-2core-8gb 4 271 26 14:21
💚​ azure-windows-latest-4core-16gb 4 273 24 14:58
💚​ gcp linux-2core-8gb 4 272 26 16:38
💚​ gcp-windows-latest-4core-16gb 4 274 24 21:53
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS= 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 16 slowest tests (at least 2 minutes):
duration env testname
18:39 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
16:31 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
15:06 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
13:23 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
12:30 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
12:19 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
12:09 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
11:57 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:52 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:39 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:54 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:38 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
3:39 aws-windows-latest-4core-16gb TestAccept
3:08 gcp-windows-latest-4core-16gb TestAccept
2:55 azure-windows-latest-4core-16gb TestAccept
2:18 gcp-windows-latest-4core-16gb TestImportDirDoesNotOverwrite

@github-actions

Copy link
Copy Markdown
Contributor

This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled.

@github-actions github-actions Bot added the Stale label Nov 11, 2026
@github-actions github-actions Bot closed this Nov 18, 2026
@denik denik reopened this Nov 19, 2026
@denik denik removed the Stale label Nov 19, 2026
denik and others added 9 commits November 19, 2026 13:07
The direct engine always sent user_api_scopes in the Apps update_mask, so any
update (e.g. a description change) cleared scopes that cannot be set through
this API, such as "jobs" added at the account level. Now user_api_scopes is
only in the mask when the bundle changes it, and remote-only drift on it is
ignored.

The testserver now clears masked fields that are absent from the body, like
the real API.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>

@review-oss-bot review-oss-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me — no issues found.

@denik
denik force-pushed the denik/apps-partial-update branch from 95dcba4 to 0566447 Compare November 19, 2026 13:10

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants