Skip to content

Add the testing property of pipelines to bundles - #7300

Closed
tharunbhuk-db wants to merge 3 commits into
tharun/pipelines-test-b1-editable-folderfrom
tharun/pipelines-test-pr4-bundles
Closed

tharunbhuk-db wants to merge 3 commits into
tharun/pipelines-test-b1-editable-folderfrom
tharun/pipelines-test-pr4-bundles

Conversation

@tharunbhuk-db

@tharunbhuk-db tharunbhuk-db commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

🥞 Stacked PR


Adds resources.pipelines.<key>.testing (sources, environment.dependencies), with the type from the Go SDK. Adds descriptions for testing, dependencies and glob, and regenerates the JSON schema and Python models.

Bundles without testing do not change.

Tests: acceptance bundle/resources/pipelines/testing.

This pull request and its description were written by Isaac.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 115d175d7 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

4 tests: regression=2 unreleased=2 coverage=0 failing=0
test branch main (0f6d067) latest (v1.26.0)
TestAccept/bundle/environments/dependencies/DMS= ✅ ❌ ❌
TestAccept/bundle/environments/dependencies/DMS=true ✅ ❌ ❌
TestAccept/bundle/resources/pipelines/testing/DMS= ✅ ✅ ❌
TestAccept/bundle/resources/pipelines/testing/DMS=true ✅ ✅ ❌
TestAccept/bundle/environments/dependencies/DMS=: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌

main (0f6d067):

acceptance_test.go:1384: Diff:
        --- bundle/environments/dependencies/output.txt
        +++ /tmp/TestAcceptbundleenvironmentsdependenciesDMS=2118452325/002/output.txt
        @@ -1,150 +1,13 @@
         
         >>> [CLI] bundle validate
        +Error: unable to determine if [TEST_TMP_DIR]/project is not a notebook: read [TEST_TMP_DIR]/project: is a directory
        +
         Name: dependencies
         Target: default
         Workspace:
           User: [USERNAME]
           Path: /Workspace/Users/[USERNAME]/.bundle/dependencies/default
         
        -Validation OK!
        +Found 1 error
         
        ->>> [CLI] bundle deploy
        -Uploading dist/test.whl...
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files...
        -Created jobs.test_job
        -Created pipelines.test_pipeline
        -Files: 6 uploaded, 0 deleted
        -Resources: 2 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> jq -s .[] | select(.path=="/api/2.2/jobs/create") | .body.environments [OUTPUT_DIR]/out.requests.txt
        -[
        -  {
        -    "environment_key": "test_env",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
        -        "-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/artifacts/.internal/test.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "beautifulsoup4[security, tests] ~= 4.12.3",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    }
        -  },
        -  {
        -    "environment_key": "test_env_2",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt"
        -      ]
        -    }
        -  }
        -]
        -
        ->>> jq -s .[] | select(.path=="/api/2.0/pipelines") [OUTPUT_DIR]/out.requests.txt
        -{
        -  "method": "POST",
        -  "path": "/api/2.0/pipelines",
        -  "body": {
        -    "channel": "CURRENT",
        -    "deployment": {
        -      "kind": "BUNDLE",
        -      "metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/state/metadata.json"
        -    },
        -    "edition": "ADVANCED",
        -    "environment": {
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/artifacts/.internal/test.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    },
        -    "name": "Test Pipeline"
        -  }
        -}
        -
        ->>> [CLI] bundle validate -o json
        -[
        -  {
        -    "environment_key": "test_env",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
        -        "-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "./dist/*.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "beautifulsoup4[security, tests] ~= 4.12.3",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    }
        -  },
        -  {
        -    "environment_key": "test_env_2",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt"
        -      ]
        -    }
        -  }
        -]
        -
        ->>> [CLI] bundle validate -o json
        -{
        -  "dependencies": [
        -    "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -    "-i http://myindexurl.com",
        -    "--index-url http://myindexurl.com",
        -    "./dist/*.whl",
        -    "/Workspace/Users/test@databricks.com/test-package.whl",
        -    "test_package",
        -    "test_package==2.0.1",
        -    "test_package>=2.0.1",
        -    "test_package==2.0.*",
        -    "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -    "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -    "--find-links=/Workspace/Users/test"
        -  ]
        -}
        +Exit code: 1

latest (v1.26.0): same output as main (0f6d067)

TestAccept/bundle/environments/dependencies/DMS=true: branch ✅ | main (0f6d067) ❌ | latest (v1.26.0) ❌

main (0f6d067):

acceptance_test.go:1384: Diff:
        --- bundle/environments/dependencies/output.txt
        +++ /tmp/TestAcceptbundleenvironmentsdependenciesDMS=true2116246615/002/output.txt
        @@ -1,150 +1,13 @@
         
         >>> [CLI] bundle validate
        +Error: unable to determine if [TEST_TMP_DIR]/project is not a notebook: read [TEST_TMP_DIR]/project: is a directory
        +
         Name: dependencies
         Target: default
         Workspace:
           User: [USERNAME]
           Path: /Workspace/Users/[USERNAME]/.bundle/dependencies/default
         
        -Validation OK!
        +Found 1 error
         
        ->>> [CLI] bundle deploy
        -Uploading dist/test.whl...
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files...
        -Created jobs.test_job
        -Created pipelines.test_pipeline
        -Files: 6 uploaded, 0 deleted
        -Resources: 2 created, 0 changed, 0 deleted, 0 unchanged
        -
        ->>> jq -s .[] | select(.path=="/api/2.2/jobs/create") | .body.environments [OUTPUT_DIR]/out.requests.txt
        -[
        -  {
        -    "environment_key": "test_env",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
        -        "-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/artifacts/.internal/test.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "beautifulsoup4[security, tests] ~= 4.12.3",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    }
        -  },
        -  {
        -    "environment_key": "test_env_2",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt"
        -      ]
        -    }
        -  }
        -]
        -
        ->>> jq -s .[] | select(.path=="/api/2.0/pipelines") [OUTPUT_DIR]/out.requests.txt
        -{
        -  "method": "POST",
        -  "path": "/api/2.0/pipelines",
        -  "body": {
        -    "channel": "CURRENT",
        -    "deployment": {
        -      "kind": "BUNDLE",
        -      "metadata_file_path": "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/state/metadata.json"
        -    },
        -    "edition": "ADVANCED",
        -    "environment": {
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "/Workspace/Users/[USERNAME]/.bundle/dependencies/default/artifacts/.internal/test.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    },
        -    "name": "Test Pipeline"
        -  }
        -}
        -
        ->>> [CLI] bundle validate -o json
        -[
        -  {
        -    "environment_key": "test_env",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -        "-r \"/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt\"",
        -        "-r '/Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/Path With Spaces/requirements.txt'",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -        "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -        "-i http://myindexurl.com",
        -        "--index-url http://myindexurl.com",
        -        "test_package",
        -        "test_package==2.0.1",
        -        "test_package>=2.0.1",
        -        "test_package==2.0.*",
        -        "./dist/*.whl",
        -        "/Workspace/Users/test@databricks.com/test-package.whl",
        -        "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -        "beautifulsoup4[security, tests] ~= 4.12.3",
        -        "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -        "--find-links=/Workspace/Users/test"
        -      ]
        -    }
        -  },
        -  {
        -    "environment_key": "test_env_2",
        -    "spec": {
        -      "client": "1",
        -      "dependencies": [
        -        "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt"
        -      ]
        -    }
        -  }
        -]
        -
        ->>> [CLI] bundle validate -o json
        -{
        -  "dependencies": [
        -    "-r /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/requirements.txt",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/file.py",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project",
        -    "-e /Workspace/Users/[USERNAME]/.bundle/dependencies/default/files/project[test]",
        -    "-i http://myindexurl.com",
        -    "--index-url http://myindexurl.com",
        -    "./dist/*.whl",
        -    "/Workspace/Users/test@databricks.com/test-package.whl",
        -    "test_package",
        -    "test_package==2.0.1",
        -    "test_package>=2.0.1",
        -    "test_package==2.0.*",
        -    "beautifulsoup4>=1.0.0,~=1.2.0,<2.0.0",
        -    "requests[security] @ https://github.com/psf/requests/archive/refs/heads/main.zip",
        -    "--find-links=/Workspace/Users/test"
        -  ]
        -}
        +Exit code: 1
        
FAIL

latest (v1.26.0): same output as main (0f6d067)

TestAccept/bundle/resources/pipelines/testing/DMS=: branch ✅ | main (0f6d067) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1384
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1125
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:688
        	Error:      	Not equal: 
        	            	expected: "\n>>> [CLI] bundle validate -o json\n{\n  \"environment\": {\n    \"dependencies\": [\n      \"-e .[test]\",\n      \"-r ./tests/requirements.txt\",\n      \"./dist/*.whl\"\n    ]\n  },\n  \"sources\": [\n    {\n      \"glob\": {\n        \"include\": \"./tests/**\"\n      }\n    }\n  ]\n}\n"
        	            	actual  : "\n>>> [CLI] bundle validate -o json\nWarning: unknown field: testing\n  at resources.pipelines.orders\n  in databricks.yml:11:7\n\nnull\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,18 +2,7 @@
        	            	 >>> [CLI] bundle validate -o json
        	            	-{
        	            	-  "environment": {
        	            	-    "dependencies": [
        	            	-      "-e .[test]",
        	            	-      "-r ./tests/requirements.txt",
        	            	-      "./dist/*.whl"
        	            	-    ]
        	            	-  },
        	            	-  "sources": [
        	            	-    {
        	            	-      "glob": {
        	            	-        "include": "./tests/**"
        	            	-      }
        	            	-    }
        	            	-  ]
        	            	-}
        	            	+Warning: unknown field: testing
        	            	+  at resources.pipelines.orders
        	            	+  in databricks.yml:11:7
        	            	 
        	            	+null
        	            	+
        	Test:       	TestAccept/bundle/resources/pipelines/testing/DMS=
        	Messages:   	bundle/resources/pipelines/testing/output.txt vs /tmp/TestAcceptbundleresourcespipelinestestingDMS=1847946638/002/output.txt
TestAccept/bundle/resources/pipelines/testing/DMS=true: branch ✅ | main (0f6d067) ✅ | latest (v1.26.0) ❌

latest (v1.26.0):

acceptance_test.go:1384: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1384
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1125
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:688
        	Error:      	Not equal: 
        	            	expected: "\n>>> [CLI] bundle validate -o json\n{\n  \"environment\": {\n    \"dependencies\": [\n      \"-e .[test]\",\n      \"-r ./tests/requirements.txt\",\n      \"./dist/*.whl\"\n    ]\n  },\n  \"sources\": [\n    {\n      \"glob\": {\n        \"include\": \"./tests/**\"\n      }\n    }\n  ]\n}\n"
        	            	actual  : "\n>>> [CLI] bundle validate -o json\nWarning: unknown field: testing\n  at resources.pipelines.orders\n  in databricks.yml:11:7\n\nnull\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -2,18 +2,7 @@
        	            	 >>> [CLI] bundle validate -o json
        	            	-{
        	            	-  "environment": {
        	            	-    "dependencies": [
        	            	-      "-e .[test]",
        	            	-      "-r ./tests/requirements.txt",
        	            	-      "./dist/*.whl"
        	            	-    ]
        	            	-  },
        	            	-  "sources": [
        	            	-    {
        	            	-      "glob": {
        	            	-        "include": "./tests/**"
        	            	-      }
        	            	-    }
        	            	-  ]
        	            	-}
        	            	+Warning: unknown field: testing
        	            	+  at resources.pipelines.orders
        	            	+  in databricks.yml:11:7
        	            	 
        	            	+null
        	            	+
        	Test:       	TestAccept/bundle/resources/pipelines/testing/DMS=true
        	Messages:   	bundle/resources/pipelines/testing/output.txt vs /tmp/TestAcceptbundleresourcespipelinestestingDMS=true4159334959/002/output.txt

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 115d175

Run: 44276660134

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 21 4:01
💚​ aws-windows-latest-4core-16gb 1 274 19 3:53
💚​ azure linux-2core-8gb 1 271 21 3:44
💚​ azure-windows-latest-4core-16gb 1 273 19 3:36
💚​ gcp linux-2core-8gb 1 272 21 3:49
💚​ gcp-windows-latest-4core-16gb 1 274 19 3:39
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:51 aws-windows-latest-4core-16gb TestAccept
3:36 gcp-windows-latest-4core-16gb TestAccept
3:31 azure-windows-latest-4core-16gb TestAccept

@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr3-junit branch from cc2e61a to b4df318 Compare November 3, 2026 00:53
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 9c9d9c8 to 742ef87 Compare November 3, 2026 00:53
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from e038a13 to e895d35 Compare November 3, 2026 17:34
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr3-junit branch from b4df318 to 7c61f68 Compare November 3, 2026 17:34
Comment thread bundle/direct/dresources/pipeline.go Resolved
Comment thread bundle/internal/schema/annotations.yml Resolved
Comment thread libs/testserver/pipelines.go Resolved
@tharunbhuk-db
tharunbhuk-db marked this pull request as ready for review November 5, 2026 16:09
@tharunbhuk-db
tharunbhuk-db marked this pull request as draft November 9, 2026 23:57
@tharunbhuk-db tharunbhuk-db changed the title [WIP] Add the testing property of pipelines to bundles Add the testing property of pipelines to bundles Nov 10, 2026
}
var diags diag.Diagnostics
pipelines := b.Config.Resources.Pipelines
for _, key := range slices.Sorted(maps.Keys(pipelines)) {

ghost Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipeline_development_deprecated.go right above this in initialize.go does the same walk with dyn.MapByPattern on resources.pipelines.*.development, which gives the path and locations directly. Can we do the same here for resources.pipelines.*.testing instead of iterating the typed map and calling dyn.GetByPath per key?

ghost Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 13c0eb2. The check now uses dyn.MapByPattern on resources.pipelines.*.testing, like the development check.

"github.com/stretchr/testify/require"
)

func TestPipelineTestingEnabled(t *testing.T) {

ghost Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this unit test? The acceptance test already shows the error with its location and path (the env -u ... bundle validate step) and the enabled case, and we try not to unit test mutators that an acceptance output covers.

ghost Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 13c0eb2. The acceptance test covers the error with its location and path, and the enabled case.

Comment thread bundle/direct/dresources/type_test.go Outdated
"file_path",
},
"pipelines": {
// The experimental testing property is not deployed yet.

ghost Nov 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this lands before #7438, a bundle with the variable on and testing set deploys fine and testing is silently dropped (PrepareState copies only CreatePipeline and CascadeOnDestroy). Fine for an experimental flag while the stack merges together, or do we want validate to say the property isn't deployed yet?

ghost Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is out of date. The field now comes from the Go SDK's CreatePipeline, so PrepareState copies it and this PR already deploys testing; main's direct engine sends it too. The knownMissingInStateType entry is gone.

@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 4c21f8b to 33085b7 Compare November 11, 2026 19:58
@tharunbhuk-db
tharunbhuk-db marked this pull request as draft November 11, 2026 20:01
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 33085b7 to 86997dc Compare November 11, 2026 22:00
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-b1-editable-folder branch from 2a9184c to 24212b4 Compare November 11, 2026 22:00
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-b1-editable-folder branch from 24212b4 to 76d7d05 Compare November 16, 2026 22:20
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 86997dc to 5a146d7 Compare November 16, 2026 22:20
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-b1-editable-folder branch from 76d7d05 to a19ae14 Compare November 17, 2026 00:18
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 5a146d7 to 13c0eb2 Compare November 17, 2026 00:18
@tharunbhuk-db
tharunbhuk-db marked this pull request as ready for review November 17, 2026 00:19
@tharunbhuk-db

ghost commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Status of the notes from the review above:

  1. Mixed CLI versions: done in Add the changelog entries for pipeline testing #7439 (204853f). The changelog entry says that everyone who deploys the bundle needs this CLI, because a deploy from an older CLI that changes the pipeline removes its testing.
  2. "[Private Preview]" in the schema: not changed. The label comes from the launch stage in the API spec, and main already shows it for testing through the Go SDK. Changing it is a decision for the API spec, not this stack.
  3. --editable ./project[...]: done in Map a project folder after -e in environment dependencies to its deployed folder #7427 (a19ae14). It maps like -e, and the output keeps the flag as written.

@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-b1-editable-folder branch from a19ae14 to 9253416 Compare November 17, 2026 16:00
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 13c0eb2 to 2c5d853 Compare November 17, 2026 16:00
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-b1-editable-folder branch from 9253416 to 3409615 Compare November 18, 2026 09:02
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from 2c5d853 to c14224e Compare November 18, 2026 09:02
@github-actions github-actions Bot added the DABs DABs related issues label Nov 18, 2026

ghost left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR can be removed from the stack.

"$fields":
"glob":
"description": |-
A `.py` test file, or a folder followed by `/**`. Other wildcards are rejected, and the sources must not overlap the pipeline's `libraries`. A relative path is relative to the YAML file that defines it.

ghost Nov 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the override; the description comes from upstream.

ghost Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, removed. The descriptions now come from the SDK.

@@ -0,0 +1 @@
trace $CLI bundle validate -o json | jq .resources.pipelines.orders.testing

ghost Nov 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this test testing now that the property comes from the SDK spec?

ghost Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On its own it covered nothing beyond the SDK type. It now lives in #7437, where it checks the translated test paths and the uploaded wheel.

Bhukya and others added 3 commits November 18, 2026 09:26
Add resources.pipelines.<key>.testing, with the test sources and test-only
dependencies that databricks pipelines test runs with. The field comes from
the Go SDK's CreatePipeline. The CLI adds its own descriptions for it.

The property is experimental. It needs
DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_PIPELINE_TESTING=true. While the variable
is off, bundle validate rejects testing and names the variable. Bundles without
testing are not changed. Later PRs translate its paths.

Co-authored-by: Isaac <no-reply@databricks.com>
The check walks resources.pipelines.*.testing with dyn.MapByPattern, like
the check of the development property, which gives the path and the
locations directly. The acceptance test covers the error and the enabled
case, so the unit test is removed.

Co-authored-by: Isaac <no-reply@databricks.com>
The Go SDK now has the testing field, so the property needs no separate opt-in.

Co-authored-by: Isaac <no-reply@databricks.com>
@tharunbhuk-db
tharunbhuk-db removed this pull request from stack #7755 November 18, 2026 09:28
@tharunbhuk-db
tharunbhuk-db force-pushed the tharun/pipelines-test-pr4-bundles branch from c14224e to 115d175 Compare November 18, 2026 09:29
@tharunbhuk-db
tharunbhuk-db removed this pull request from stack #7758 November 18, 2026 10:10
@tharunbhuk-db

ghost commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Agreed, closed. Its test moved to #7437, and the stack is now #7427 → #7437 → #7429.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants