Skip to content

Apply auth token --timeout to the inline login - #7337

Merged
pietern merged 3 commits into
mainfrom
pietern/f07-7267-auth-token-timeout
Nov 16, 2026
Merged

pietern merged 3 commits into
mainfrom
pietern/f07-7267-auth-token-timeout

Conversation

@pietern

@pietern pietern commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Changes

databricks auth token --timeout didn't apply to the browser login after "Create a new profile" in the profile picker: runInlineLogin used a fixed one-hour timeout. It now uses the flag, like auth login --timeout, and the flag's help text says so.

Why

#7267 made the inline login honor a timeout, but hard-coded defaultTimeout; this PR uses --timeout instead.

Tests

TestLoadTokenCreateNewProfileAppliesTimeout drives the picker against a server that never answers the login and expects the deadline to fire.

This pull request and its description were written by Isaac.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: d0c8fec

Run: 43847298774

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 4:14
💚​ aws-windows-latest-4core-16gb 1 272 13 7:04
💚​ azure linux-2core-8gb 1 269 15 3:34
💚​ azure-windows-latest-4core-16gb 1 271 13 5:41
💚​ gcp linux-2core-8gb 1 270 15 4:27
💚​ gcp-windows-latest-4core-16gb 1 272 13 7:27
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 1 slowest tests (at least 2 minutes):
duration env testname
2:04 gcp-windows-latest-4core-16gb TestFsCpDir/dbfs_to_dbfs

@maksim-zuev-db maksim-zuev-db left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Why" in the description is a bit wrong, the better wording would be "#7267 made the inline login honor a timeout, but hard-coded defaultTimeout; this PR uses --timeout instead."
All the rest looks good, thanks!

pietern and others added 3 commits November 16, 2026 10:03
The browser login run after "Create a new profile" in `auth token` used
the hardcoded one hour defaultTimeout instead of the --timeout flag,
because profile resolution happens before loadToken applies
args.tokenTimeout. Pass the flag value through resolveNoArgsToken to
runInlineLogin, as `auth login` does with its own --timeout.

Co-authored-by: Isaac <no-reply@databricks.com>
--timeout now also limits the inline browser login, so say so in the help
text. Add a changelog entry, as other fixes to this login flow do.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern force-pushed the pietern/f07-7267-auth-token-timeout branch from 73e9fb2 to d0c8fec Compare November 16, 2026 10:13
@pietern pietern added the auth label Nov 16, 2026
@pietern
pietern marked this pull request as ready for review November 16, 2026 14:31
@pietern
pietern requested review from a team as code owners November 16, 2026 14:31
@pietern
pietern requested review from denik and parthban-db November 16, 2026 14:31
@pietern
pietern added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 5bd8717 Nov 16, 2026
27 checks passed
@pietern
pietern deleted the pietern/f07-7267-auth-token-timeout branch November 16, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants