Repository navigation
Conversation
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 0 not selected) 48 tests: regression=39 unreleased=0 coverage=9 failing=0
TestAccept/bundle/migrate/auto/registered-model-rename/DMS=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/resources/catalogs/rename/DMS=/READPLAN=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/catalogs/rename/DMS=/READPLAN=1: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/catalogs/rename/DMS=true/READPLAN=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/catalogs/rename/DMS=true/READPLAN=1: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/grants/registered_model_change_name/DMS=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/grants/registered_model_change_name/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): TestAccept/bundle/resources/registered_models/basic/DMS=: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) TestAccept/bundle/resources/registered_models/basic/DMS=true: branch ✅ | main (ef8fc0b) ❌ | latest (v1.27.0) ❌main (ef8fc0b): latest (v1.27.0): same output as main (ef8fc0b) 30 more failure details omitted, see the full report in the run. |
✅ Integration test reportCommit: ae7b23c
Top 8 slowest tests (at least 2 minutes):
|
344a6c9 to
24b12d9
Compare
24b12d9 to
35b8737
Compare
35b8737 to
5bd3516
Compare
5bd3516 to
a333a4b
Compare
a333a4b to
4ccf5ab
Compare
4ccf5ab to
cdc56bf
Compare
cdc56bf to
0d1ef07
Compare
0d1ef07 to
d16b7c2
Compare
d16b7c2 to
5e37c6e
Compare
5e37c6e to
2957d38
Compare
2957d38 to
ce6daec
Compare
ce6daec to
2b74f07
Compare
1e1984e to
66ba15f
Compare
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
| trace $CLI bundle plan | ||
|
|
||
| title "The create fails: the secret is already there" | ||
| trace errcode $CLI bundle deploy |
There was a problem hiding this comment.
[AI Generated] nit: This deploy is expected to fail with 409, and .agents/rules/testing.md asks for musterr rather than errcode when a failure is required. Can this be trace musterr $CLI bundle deploy?
66ba15f to
162f1f3
Compare
UC moves a secret with its renamed parent, so the planner now re-keys it (update_id, parent_renamed) instead of recreating it, which failed with ALREADY_EXISTS. A secret cannot be renamed itself, so its DoUpdateWithID only re-keys; the adapter check now accepts DoUpdateWithID for a resource whose provided_id_fields a parent rename can change. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…t; drop duplicated test-server moves Co-authored-by: Isaac <no-reply@databricks.com>
The recreate deletes the secret at its recorded path after the schema's rename moved it, so the moved secret is left behind. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…secret Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…rets (review S3) The check is skipped for resources that implement OverrideChangeDesc, as secrets do. Co-authored-by: Isaac <no-reply@databricks.com>
Only parent_id_fields (catalog_name, schema_name, from #7718) follow a parent's rename, so a name that references a renamed schema's name recreates the secret instead of re-keying it to a path that does not exist. Co-authored-by: Isaac <no-reply@databricks.com>
…ADY_EXISTS Verified on AWS, Azure and GCP: "Secret '<full_name>' already exists". Co-authored-by: Isaac <no-reply@databricks.com>
…adness, review G1) Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
162f1f3 to
ae7b23c
Compare
…ricks#7718) ## Changes A UC resource that takes its own name from another resource's name, and lives in a different schema, was treated as moved when that resource was renamed. For example, a secret in schema `shared` with `name: ${resources.schemas.app.name}`: renaming `app` recreated the secret, but the delete went to `shared.<new app name>`, which does not exist, and the old secret was left behind. Registered models had the same problem. Only the fields that name a resource's parent move it with the parent. A new `parent_id_fields` config lists them (`catalog_name`, `schema_name`) for schemas, volumes, registered models and secrets, and both the plan's follow check and the recreate's delete ID now consult only those. Before, any field referencing the renamed resource counted, except a name that can be renamed in place. Found in review of databricks#7381, where secrets start following a renamed parent. That PR and databricks#7379 rebase on this one. ## Tests - New `schemas/rename_referenced_by_name` (`Cloud = true`): a model and a secret in a shared schema, named after another schema that gets renamed. The first commit records the bug (`Badness`): the delete went to the new name and the old model and secret stayed. Now the delete goes to their actual path, both are gone, and the redeploy is a no-op. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
| expectedAction: deployplan.Recreate, | ||
| }, | ||
| { | ||
| name: "own name referencing the renamed parent is recreated", |
There was a problem hiding this comment.
[AI Generated] nit: This case meets every condition in TestFollowsParentRename's doc comment (provided_id_field, DoUpdateWithID, same old parent value) yet expects recreate. Can the comment add that the field must also be a parent_id_fields entry?
Changes
A UC secret in a renamed catalog or schema (
schema_name: ${resources.schemas.<s>.name}) now follows its parent the way volumes do since #7343 and registered models do in #7379: withIDFromState, the framework re-keys it without a request (state_only). Before, it was recreated where the parent's rename moved it: the secret was deleted and created again.UC cannot rename a secret, so its own name still recreates, even when it references a renamed resource's name: only its
parent_id_fields(catalog_name,schema_name, from #7718) follow a parent. When the secret also has its own changes, the newDoUpdateWithIDsends the update at the new path, and the framework records the new path first (#7379), so a failed update is retried there.Stacked on #7379.
Tests
secrets/recreate_in_renamed_schema(Cloud = true): rename the schema and the secret in one deploy. The secret is recreated, and the old one is deleted where the schema's rename moved it.secrets/parent_rename(Cloud = true): rename the schema (no request to the secret), then rename the catalog and change the secret's comment in one deploy (one PATCH at the new path).create_timestays the same and the final plan is a no-op.secrets/parent_rename_out_of_band(Cloud = true,Badness): a secret has no recorded id, so when its schema is renamed outside the bundle the plan creates it again and UC rejects the create. Same on main.schemas/rename_with_model_and_secret(Cloud = true): the secret now follows the schema's rename too; the deploy sends only the schema's PATCH.Secret '<name>' does not exist.,409 ALREADY_EXISTSSecret '<name>' already exists; checked on AWS, Azure and GCP).This pull request and its description were written by Isaac.