Skip to content

[DECO-28500] Sync a remote run_as on jobs whose config leaves it unset - #7494

Merged
petrapostelnicu-db merged 8 commits into
mainfrom
deco-28500-run-as-unset-config
Nov 18, 2026
Merged

petrapostelnicu-db merged 8 commits into
mainfrom
deco-28500-run-as-unset-config

Conversation

@petrapostelnicu-db

@petrapostelnicu-db petrapostelnicu-db commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • config-remote-sync now writes a remote job run_as into a config that doesn't set one, unless it names the job's owner (skipJobRunAs in bundle/configsync/runas.go). It replaces the blanket resources.jobs.*.run_as skip.
  • The owner is the principal a job without run_as runs as, per the Jobs API (run_as_user_name): the IS_OWNER entry of the job's ACL, or creator_user_name when job access control is off. The ACL comes from:
  • The whole-object run_as change is still skipped when:
    • the config sets run_as (the plan reports the edit key by key);
    • the remote has no run_as;
    • the owner is unknown because the ACL can't be read.
  • applyLifecycle no longer drops a job's whole run_as as a backend default; skipJobRunAs decides it.

Why

  • A run-as change in the Jobs UI never reached a YAML without run_as, which is most bundles.
  • The Jobs UI always shows a principal (the owner when run_as is unset) and only saves a different one, so the owner check doesn't drop UI edits.
  • Jobs deployed with terraform carry run_as set to the owner (provider code), so they are skipped.
  • A run_as removed from the config and deployed is written back: jobs/reset without run_as keeps the previous value, so the job still runs as that principal.
  • This replaces the --sync-run-as-ids flag from an earlier revision, so the caller needs no new flag.

Tests

  • config-remote-sync/job_run_as:
    • remote run_as on a job without one → synced;
    • remote run_as naming the owner → not synced, both with the creator as owner and after an ownership transfer;
    • run_as removed from config and deployed → written back;
    • run_as added locally, not deployed, then changed remotely → one key-level change;
    • the kind-switch cases from [DECO-28500] Fix config-remote-sync writing run_as: {} on a principal kind switch #7493 are unchanged;
    • a second sync is a no-op.
  • config-remote-sync/terraform_state: a terraform-pinned run_as naming the owner isn't reported.
  • Unit tests for skipJobRunAs and jobOwners.

This pull request and its description were written by Isaac.

@github-actions

github-actions Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Commit: b0c621a04 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

3 tests: regression=2 unreleased=0 coverage=1 failing=0
test branch main (f153f69) latest (v1.26.0)
TestAccept/bundle/config-remote-sync/job_run_as/DMS= ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/job_run_as/DMS=true ✅ ❌ ❌
TestAccept/bundle/config-remote-sync/terraform_state/DMS= ✅ ✅ ✅
TestAccept/bundle/config-remote-sync/job_run_as/DMS=: branch ✅ | main (f153f69) ❌ | latest (v1.26.0) ❌

main (f153f69):

acceptance_test.go:1384: Diff:
        --- bundle/config-remote-sync/job_run_as/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncjob_run_asDMS=1989705171/002/output.txt
        @@ -34,17 +34,11 @@
         === Detect and save changes
         
         >>> [CLI] bundle config-remote-sync --save
        -Detected changes in 7 resource(s):
        +Detected changes in 5 resource(s):
         
        -Resource: resources.jobs.no_run_as
        -  run_as: add
        -
         Resource: resources.jobs.pending_add
           run_as.user_name: replace
         
        -Resource: resources.jobs.removed_run_as
        -  run_as: add
        -
         Resource: resources.jobs.transferred_owner
           permissions: add
         
        @@ -63,49 +53,36 @@
         >>> diff.py databricks.yml.backup databricks.yml
         --- databricks.yml.backup
         +++ databricks.yml
        -@@ -12,4 +12,6 @@
        +@@ -28,4 +28,7 @@
                      notebook_path: /Users/{{workspace_user_name}}/notebook
         
        -+      run_as:
        -+        service_principal_name: [UUID]
        -     # The remote run_as names the owner, which is what no run_as means.
        -     run_as_to_owner:
        -@@ -28,4 +30,7 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
         +      permissions:
         +        - level: IS_OWNER
         +          user_name: new-owner@example.com
              # run_as is removed from config and deployed; the job keeps it remotely.
              removed_run_as:
        -@@ -36,9 +41,11 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        user_name: first-user@example.com
        -     # run_as is added to config locally and not deployed.
        -     pending_add:
        +@@ -40,5 +43,5 @@
                name: pending-add-[UNIQUE_NAME]
                run_as:
         -        user_name: local-user@example.com
         +        user_name: remote-user@example.com
                tasks:
                  - task_key: main
        -@@ -49,5 +56,5 @@
        +@@ -49,5 +52,5 @@
                name: user-to-user-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: second-user@example.com
                tasks:
                  - task_key: main
        -@@ -58,5 +65,5 @@
        +@@ -58,5 +61,5 @@
                name: user-to-creator-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: [USERNAME]
                tasks:
                  - task_key: main
        -@@ -67,5 +74,5 @@
        +@@ -67,5 +70,5 @@
                name: user-to-sp-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/config-remote-sync/job_run_as/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncjob_run_asDMS=3807289425/002/output.txt
        @@ -34,25 +34,15 @@
         === Detect and save changes
         
         >>> [CLI] bundle config-remote-sync --save
        -Detected changes in 7 resource(s):
        +Detected changes in 4 resource(s):
         
        -Resource: resources.jobs.no_run_as
        -  run_as: add
        -
         Resource: resources.jobs.pending_add
           run_as.user_name: replace
         
        -Resource: resources.jobs.removed_run_as
        -  run_as: add
        -
        -Resource: resources.jobs.transferred_owner
        -  permissions: add
        -
         Resource: resources.jobs.user_to_creator
           run_as.user_name: replace
         
         Resource: resources.jobs.user_to_sp
        -  run_as.service_principal_name: add
           run_as.user_name: remove
         
         Resource: resources.jobs.user_to_user
        @@ -63,53 +45,33 @@
         >>> diff.py databricks.yml.backup databricks.yml
         --- databricks.yml.backup
         +++ databricks.yml
        -@@ -12,4 +12,6 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        service_principal_name: [UUID]
        -     # The remote run_as names the owner, which is what no run_as means.
        -     run_as_to_owner:
        -@@ -28,4 +30,7 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      permissions:
        -+        - level: IS_OWNER
        -+          user_name: new-owner@example.com
        -     # run_as is removed from config and deployed; the job keeps it remotely.
        -     removed_run_as:
        -@@ -36,9 +41,11 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        user_name: first-user@example.com
        -     # run_as is added to config locally and not deployed.
        -     pending_add:
        +@@ -40,5 +40,5 @@
                name: pending-add-[UNIQUE_NAME]
                run_as:
         -        user_name: local-user@example.com
         +        user_name: remote-user@example.com
                tasks:
                  - task_key: main
        -@@ -49,5 +56,5 @@
        +@@ -49,5 +49,5 @@
                name: user-to-user-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: second-user@example.com
                tasks:
                  - task_key: main
        -@@ -58,5 +65,5 @@
        +@@ -58,5 +58,5 @@
                name: user-to-creator-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: [USERNAME]
                tasks:
                  - task_key: main
        -@@ -67,5 +74,5 @@
        +@@ -66,6 +66,5 @@
        +     user_to_sp:
                name: user-to-sp-[UNIQUE_NAME]
        -       run_as:
        +-      run_as:
         -        user_name: first-user@example.com
        -+        service_principal_name: [UUID]
        ++      run_as: {}
                tasks:
                  - task_key: main
         
        @@ -122,10 +64,8 @@
         === Plan after sync
         
         >>> [CLI] bundle plan
        -create jobs.transferred_owner.permissions
        +Plan: 0 to add, 0 to change, 0 to delete, 8 unchanged
         
        -Plan: 1 to add, 0 to change, 0 to delete, 8 unchanged
        -
         >>> [CLI] bundle destroy --auto-approve
         The following resources will be deleted:
           delete resources.jobs.no_run_as
TestAccept/bundle/config-remote-sync/job_run_as/DMS=true: branch ✅ | main (f153f69) ❌ | latest (v1.26.0) ❌

main (f153f69):

acceptance_test.go:1384: Diff:
        --- bundle/config-remote-sync/job_run_as/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncjob_run_asDMS=true1819705258/002/output.txt
        @@ -34,17 +34,11 @@
         === Detect and save changes
         
         >>> [CLI] bundle config-remote-sync --save
        -Detected changes in 7 resource(s):
        +Detected changes in 5 resource(s):
         
        -Resource: resources.jobs.no_run_as
        -  run_as: add
        -
         Resource: resources.jobs.pending_add
           run_as.user_name: replace
         
        -Resource: resources.jobs.removed_run_as
        -  run_as: add
        -
         Resource: resources.jobs.transferred_owner
           permissions: add
         
        @@ -63,49 +53,36 @@
         >>> diff.py databricks.yml.backup databricks.yml
         --- databricks.yml.backup
         +++ databricks.yml
        -@@ -12,4 +12,6 @@
        +@@ -28,4 +28,7 @@
                      notebook_path: /Users/{{workspace_user_name}}/notebook
         
        -+      run_as:
        -+        service_principal_name: [UUID]
        -     # The remote run_as names the owner, which is what no run_as means.
        -     run_as_to_owner:
        -@@ -28,4 +30,7 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
         +      permissions:
         +        - level: IS_OWNER
         +          user_name: new-owner@example.com
              # run_as is removed from config and deployed; the job keeps it remotely.
              removed_run_as:
        -@@ -36,9 +41,11 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        user_name: first-user@example.com
        -     # run_as is added to config locally and not deployed.
        -     pending_add:
        +@@ -40,5 +43,5 @@
                name: pending-add-[UNIQUE_NAME]
                run_as:
         -        user_name: local-user@example.com
         +        user_name: remote-user@example.com
                tasks:
                  - task_key: main
        -@@ -49,5 +56,5 @@
        +@@ -49,5 +52,5 @@
                name: user-to-user-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: second-user@example.com
                tasks:
                  - task_key: main
        -@@ -58,5 +65,5 @@
        +@@ -58,5 +61,5 @@
                name: user-to-creator-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: [USERNAME]
                tasks:
                  - task_key: main
        -@@ -67,5 +74,5 @@
        +@@ -67,5 +70,5 @@
                name: user-to-sp-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
        
FAIL

latest (v1.26.0):

acceptance_test.go:1384: Diff:
        --- bundle/config-remote-sync/job_run_as/output.txt
        +++ /tmp/TestAcceptbundleconfig-remote-syncjob_run_asDMS=true2354856059/002/output.txt
        @@ -34,25 +34,15 @@
         === Detect and save changes
         
         >>> [CLI] bundle config-remote-sync --save
        -Detected changes in 7 resource(s):
        +Detected changes in 4 resource(s):
         
        -Resource: resources.jobs.no_run_as
        -  run_as: add
        -
         Resource: resources.jobs.pending_add
           run_as.user_name: replace
         
        -Resource: resources.jobs.removed_run_as
        -  run_as: add
        -
        -Resource: resources.jobs.transferred_owner
        -  permissions: add
        -
         Resource: resources.jobs.user_to_creator
           run_as.user_name: replace
         
         Resource: resources.jobs.user_to_sp
        -  run_as.service_principal_name: add
           run_as.user_name: remove
         
         Resource: resources.jobs.user_to_user
        @@ -63,53 +45,33 @@
         >>> diff.py databricks.yml.backup databricks.yml
         --- databricks.yml.backup
         +++ databricks.yml
        -@@ -12,4 +12,6 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        service_principal_name: [UUID]
        -     # The remote run_as names the owner, which is what no run_as means.
        -     run_as_to_owner:
        -@@ -28,4 +30,7 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      permissions:
        -+        - level: IS_OWNER
        -+          user_name: new-owner@example.com
        -     # run_as is removed from config and deployed; the job keeps it remotely.
        -     removed_run_as:
        -@@ -36,9 +41,11 @@
        -             notebook_path: /Users/{{workspace_user_name}}/notebook
        -
        -+      run_as:
        -+        user_name: first-user@example.com
        -     # run_as is added to config locally and not deployed.
        -     pending_add:
        +@@ -40,5 +40,5 @@
                name: pending-add-[UNIQUE_NAME]
                run_as:
         -        user_name: local-user@example.com
         +        user_name: remote-user@example.com
                tasks:
                  - task_key: main
        -@@ -49,5 +56,5 @@
        +@@ -49,5 +49,5 @@
                name: user-to-user-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: second-user@example.com
                tasks:
                  - task_key: main
        -@@ -58,5 +65,5 @@
        +@@ -58,5 +58,5 @@
                name: user-to-creator-[UNIQUE_NAME]
                run_as:
         -        user_name: first-user@example.com
         +        user_name: [USERNAME]
                tasks:
                  - task_key: main
        -@@ -67,5 +74,5 @@
        +@@ -66,6 +66,5 @@
        +     user_to_sp:
                name: user-to-sp-[UNIQUE_NAME]
        -       run_as:
        +-      run_as:
         -        user_name: first-user@example.com
        -+        service_principal_name: [UUID]
        ++      run_as: {}
                tasks:
                  - task_key: main
         
        @@ -122,10 +64,8 @@
         === Plan after sync
         
         >>> [CLI] bundle plan
        -create jobs.transferred_owner.permissions
        +Plan: 0 to add, 0 to change, 0 to delete, 8 unchanged
         
        -Plan: 1 to add, 0 to change, 0 to delete, 8 unchanged
        -
         >>> [CLI] bundle destroy --auto-approve
         The following resources will be deleted:
           delete resources.jobs.no_run_as
        
FAIL

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: b0c621a

Run: 44287833772

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 21 4:41
💚​ aws-windows-latest-4core-16gb 1 274 19 3:52
💚​ azure linux-2core-8gb 1 271 21 6:15
💚​ azure-windows-latest-4core-16gb 1 273 19 4:39
💚​ gcp linux-2core-8gb 1 272 21 5:48
💚​ gcp-windows-latest-4core-16gb 1 274 19 4:25
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:46 aws-windows-latest-4core-16gb TestAccept
2:53 azure-windows-latest-4core-16gb TestAccept
2:45 gcp-windows-latest-4core-16gb TestAccept

@petrapostelnicu-db
petrapostelnicu-db force-pushed the deco-28500-run-as-unset-config branch from c83ff1d to cc6cc1c Compare November 12, 2026 15:30
@petrapostelnicu-db
petrapostelnicu-db marked this pull request as ready for review November 12, 2026 15:31
@petrapostelnicu-db
petrapostelnicu-db requested review from a team as code owners November 12, 2026 15:31
@github-actions github-actions Bot added the DABs DABs related issues label Nov 12, 2026
@petrapostelnicu-db
petrapostelnicu-db force-pushed the deco-28500-run-as-unset-config branch 3 times, most recently from f712989 to 759b252 Compare November 13, 2026 12:17

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI review from review-factory: 3 independent reviewer models (Claude Opus 5.5, Claude Fable 5.2, Claude Sonnet 5.5) with cross-verification. Only findings that reviewers agreed on are posted.

Syncs a remote job run_as into configs lacking one; reviewers confirmed a removed-and-redeployed run_as is written back, plus a redundant whole-object replace.

Findings: 1 major, 1 minor.

Comment thread bundle/configsync/runas.go Resolved
Comment thread bundle/configsync/runas.go Resolved
Base automatically changed from deco-28500-run-as-kind-switch to main November 15, 2026 17:38
petrapostelnicu-db and others added 3 commits November 15, 2026 17:38
config-remote-sync skipped a job's run_as entirely, so a run-as change
made in the Jobs UI never reached a config without run_as. Replace the
blanket skip with a rule for the whole run_as object: sync it unless the
remote has none, it is unchanged since the last deploy, or it names the
job's creator. Jobs updated by the terraform engine carry an explicit
run_as set to the job's identity, which the creator check filters out.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
config-remote-sync is a hidden command used only by DABs in the workspace;
changes to it do not get release notes.

Co-authored-by: Isaac <no-reply@databricks.com>
@petrapostelnicu-db
petrapostelnicu-db force-pushed the deco-28500-run-as-unset-config branch from 759b252 to 9d7317e Compare November 15, 2026 17:38

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AI review (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

Comment thread bundle/configsync/runas.go Resolved
Comment thread bundle/configsync/runas.go Resolved
A remote run_as on a job whose config has none is either a Jobs UI edit
or a value the server kept: jobs/reset without run_as keeps the previous
run_as, so a run_as removed from the config and deployed stays on the
job. Every sync wrote it back. Only the caller knows which case applies,
so a whole-object run_as is now synced only for jobs listed in the new
--sync-run-as-ids flag. This replaces the creator heuristic, which also
missed jobs whose ownership was transferred.

When the config sets run_as, the plan reports the remote edit key by
key, so the whole-object change is skipped instead of emitted as a
duplicate replace.

Co-authored-by: Isaac <no-reply@databricks.com>
@petrapostelnicu-db petrapostelnicu-db changed the title [DECO-28500] Sync a remote run_as on jobs whose config leaves it unset [DECO-28500] Sync a remote run_as on jobs whose config leaves it unset, for jobs passed in --sync-run-as-ids Nov 16, 2026
@petrapostelnicu-db petrapostelnicu-db changed the title [DECO-28500] Sync a remote run_as on jobs whose config leaves it unset, for jobs passed in --sync-run-as-ids [DECO-28500] Sync a remote run_as on jobs whose config leaves it unset Nov 16, 2026

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.

No blocking or major issues found.

Comment thread cmd/bundle/config_remote_sync.go Resolved
Resolve conflicts with #7645 (lifecycle metadata) and #7536 (permissions):
- convertPlanChange applies skipJobRunAs before applyLifecycle.
- applyLifecycle no longer drops a job's whole run_as as a backend default;
  skipJobRunAs already limits it to jobs passed in --sync-run-as-ids.

Also validate --sync-run-as-ids inside PostStateFunc so an invalid value
is reported through WriteResult (status: failed with -o json) and telemetry,
like --select-ids.

Co-authored-by: Isaac <no-reply@databricks.com>
@ilyakuz-db

Copy link
Copy Markdown
Contributor

Overall LGTM but I'm not super happy with having extra command flag

It can be a value the server kept. jobs/reset without run_as keeps the previous one, so a run_as removed from the config and deployed stays on the job.

Can we derive it in the config somehow and add more guardrails? E.g. if it's the server-side default value (e.g. owner) - maybe we can skip sync?

If not possible, maybe we could consider a generic argument for such cases? i.e. force_sync_fields: job.run_as or something similar

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.

No issues found.

Replace the --sync-run-as-ids flag with a rule config-remote-sync applies on
its own. A job without run_as runs as its owner: the IS_OWNER entry of its
ACL, or its creator when job access control is off. The Jobs UI always shows
and saves a principal, so a remote run_as that names the owner says what the
config already says and is skipped. Any other remote run_as is what the job
runs as, so it is written to the config. That includes a run_as removed from
the config and deployed, which jobs/reset keeps.

The owner comes from the ACLs config-remote-sync already reads for unmanaged
permissions (now returned unfiltered), from the plan for declared ones, or
from a direct read for declared permissions that were never deployed. When
the ACL can't be read, run_as is not synced.

Co-authored-by: Isaac <no-reply@databricks.com>
@petrapostelnicu-db

Copy link
Copy Markdown
Contributor Author

@ilyakuz-db Yes, it can be derived. A remote run_as the YAML doesn't set is now synced unless it's the job's owner (IS_OWNER in the ACL, or the creator). That's safe: no run_as already means the owner, so skipping the owner never makes the YAML wrong. Every other UI edit picks someone else and is synced.

The trade-off is the case the flag was for. If run_as is removed from the YAML and deployed, the server keeps the old value, and sync writes it back. I think that's fine, because the job really does still run as that principal. Maybe it even helps users as they realize that just removing run_as from config did not revert back to running as owner, so they can be explicit for the next deploy.

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.

Comment thread bundle/configsync/runas.go Resolved
Co-authored-by: Isaac <no-reply@databricks.com>

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Follow-up review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.

No new issues found.

Resolve the conflict with #7717 in permissions.go: readUnmanagedPermissions
keeps returning the raw ACL (jobOwners needs the IS_OWNER entry), and
addPermissionsChanges now filters it with withoutCurrentUserDefaults.

Co-authored-by: Isaac <no-reply@databricks.com>
@petrapostelnicu-db
petrapostelnicu-db added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 03bcf5d Nov 18, 2026
27 checks passed
@petrapostelnicu-db
petrapostelnicu-db deleted the deco-28500-run-as-unset-config branch November 18, 2026 11:09

@Sankalp-Mittal Sankalp-Mittal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.

No blocking or major issues found.

if adapter == nil {
return nil, errPermissionsNotRead
}
return readPermissions(ctx, b, adapter, resourceKey)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[AI Generated] nit: No test can fail on this direct read: the second sync reaches it for transferred_owner, but a failed read also gives "No changes detected". Can one case with undeployed permissions expect run_as: add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants