Skip to content

acc: tolerate retried app deployment POST in apps lifecycle-started-omitted - #7547

Merged
denik merged 1 commit into
mainfrom
ai/apps-lifecycle-omitted-unique
Nov 12, 2026
Merged

denik merged 1 commit into
mainfrom
ai/apps-lifecycle-omitted-unique

Conversation

@denik

@denik denik commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Collapse consecutive duplicate requests (print_requests.py --unique) in apps/lifecycle-started-omitted, the same treatment #7511 gave lifecycle-started and lifecycle-started-toggle. output.txt doesn't change, because the trace line prints the wrapper function name.

Why

Review feedback on #7511: this test also records a start followed by POST /api/2.0/apps/{name}/deployments (the "started omitted -> started: true" step), so the same appdeploy.Deploy retry can record that POST twice. The dashboard shows no error/1031 failures for this test in the last 90 days, so this change prevents the flake rather than fixing an observed one. Consecutive duplicates are still collapsed only after GET filtering, as in #7511.

Dashboard

Preventive; the same failure mode as error/1031, which has not been seen on this test yet.

Tests

  • Local: go test ./acceptance -run 'TestAccept/bundle/resources/apps/lifecycle-started-omitted' passes.
  • AWS: testme-aws -run 'TestAccept/bundle/resources/apps/lifecycle-started-omitted/' passes (DMS= and DMS=true).

Opened by an AI agent (harness_auto, isaac_claude, opus5.5).

This pull request and its description were written by Isaac.

Follow-up to #7511: this test records the same start-then-deploy pair, so
it is exposed to the same appdeploy.Deploy retry. Collapse consecutive
duplicates with print_requests.py --unique.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added the ai-auto Deprecated: use factory-generated instead. label Nov 12, 2026
@denik
denik requested a review from andrewnester November 12, 2026 12:09
@github-actions github-actions Bot added DABs DABs related issues test-only-fix PRs that update failing of flaky tests without changing CLI code. labels Nov 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Commit: b58c714e6 | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

2 tests: regression=0 unreleased=0 coverage=2 failing=0
test branch main (4668f26) latest (v1.26.0)
TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS= ✅ ✅ ✅
TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true ✅ ✅ ✅

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: b58c714

Run: 43215505984

Env 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 3 271 15 14:26
💚​ aws-windows-latest-4core-16gb 3 273 13 8:29
💚​ azure linux-2core-8gb 3 270 15 13:43
💚​ azure-windows-latest-4core-16gb 3 272 13 9:27
🔄​ gcp linux-2core-8gb 2 3 269 15 15:44
💚​ gcp-windows-latest-4core-16gb 3 273 13 7:25
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
💚​ TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestSyncIncrementalFileOverwritesFolder ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
🔄​ TestSyncIncrementalSyncFileToPythonNotebook ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
Top 23 slowest tests (at least 2 minutes):
duration env testname
6:05 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
5:56 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
5:48 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
5:21 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
5:14 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
5:02 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
5:01 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
4:59 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
4:28 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
3:53 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
3:50 aws linux-2core-8gb TestAccept
3:47 gcp linux-2core-8gb TestAccept
3:19 azure-windows-latest-4core-16gb TestAccept
3:18 gcp-windows-latest-4core-16gb TestAccept
3:12 azure linux-2core-8gb TestAccept
3:09 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
3:08 azure linux-2core-8gb TestFilerReadDir/workspace_files_extensions
3:02 aws-windows-latest-4core-16gb TestAccept
2:59 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=true
2:39 azure-windows-latest-4core-16gb TestExportDir
2:28 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
2:22 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:15 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions

@denik
denik marked this pull request as ready for review November 12, 2026 16:32
@denik
denik requested review from a team as code owners November 12, 2026 16:32
@denik
denik enabled auto-merge November 12, 2026 16:32
@denik
denik added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 1f483d0 Nov 12, 2026
28 checks passed
@denik
denik deleted the ai/apps-lifecycle-omitted-unique branch November 12, 2026 16:51
idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 16, 2026
…atabricks#7641)

## Changes
Record postgres requests with `print_requests.py --unique` in
`bundle/resources/postgres_endpoints/update_autoscaling`, so a retried
request (an identical consecutive request) is recorded once.

## Why
On GCP the backend returned a transient 500 for `GET .../branches/main`
during the no-change deploy. The CLI retried the read on purpose
(`libs/retry`, `IsTransientRead` in `bundle/direct`), and the retry
showed up as an extra request in `out.requests.no_change.json`. The
retry is correct behavior, so the recording should tolerate it. Same
approach as databricks#7511 and databricks#7547 for apps.

Not a regression from databricks#7557 (that change retries create-operation
polling) or from databricks#7596 (testserver spec echo). The failing request is a
plain remote-state read that has been retried for a while.

The current goldens have no consecutive duplicate requests, so
`--unique` changes only the traced command line in output.txt.

## Dashboard
-
[TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS=true](http://go/cli/dashboard/test/acceptance.TestAccept/bundle/resources/postgres_endpoints/update_autoscaling/DMS=true?main=1&pr=1&end=2026-11-15T03:00:00Z&last=2d)
-
[error/3462](http://go/cli/dashboard/error/3462?main=1&pr=1&end=2026-11-15T03:00:00Z&last=2d)

```
Suppressed from output.txt:
    Warn: retrying after 500 Internal Server Error from GET /api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main
...
+{
+  "method": "GET",
+  "path": "/api/2.0/postgres/projects/test-pg-proj-[UNIQUE_NAME]/branches/main"
+}
Messages: bundle/resources/postgres_endpoints/update_autoscaling/out.requests.no_change.json
```

## Tests
Passed locally and on AWS (both DMS variants). The last commit asks CI
to run the test on GCP and AWS.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik denik added factory-generated and removed ai-auto Deprecated: use factory-generated instead. labels Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues factory-generated test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants