Skip to content

Add sign-in challenges and the authenticate tool to aitools mcp serve - #7553

Merged
simonfaltum merged 1 commit into
mainfrom
aitools-mcp/08-challenge
Nov 19, 2026
Merged

simonfaltum merged 1 commit into
mainfrom
aitools-mcp/08-challenge

Conversation

@simonfaltum

@simonfaltum simonfaltum commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

This pull request is part of a stack that adds the hidden databricks aitools mcp command group, on top of #7551. A service that needs provider sign-in rejects tools/list until the user signs in, so the agent has no tool to start it. The proxy now offers one authenticate tool that runs the sign-in.

Changes

  • A challenge makes tools/list return only authenticate. A challenge is a JSON-RPC -32006, a -32042 answer with a sign-in URL, or an error result that names a sign-in URL. A -32042 URL is accepted on the profile's host, or on any host whose o= or w= query names the bound workspace.
  • On a server that needs sign-in, a 401 is a challenge only when its body asks for sign-in. Any other 401 gets the databricks auth login hint. A server that needs no sign-in has no such handling, so its 401 passes through unchanged.
  • A challenged tools/call names authenticate and the login command. If tools/list still passes, authenticate is added to its first page until a call succeeds or the sign-in completes.
  • If the service still challenges after an "Already signed in" answer, a challenged tools/call is answered with the mcp logout command to run first, since neither authenticate nor login can fix it then.
  • authenticate runs login's sign-in, sends progress naming the page, and sends tools/list_changed when signed in. A timeout names the URL, the last failed check and the login command.
  • The known-service note is printed by mcp add, by mcp login and by the authenticate tool's sign-in. mcp list does not read it.
  • The proxy never deletes an active credential. SignIn deletes a FAILED or DEGRADED one before it shows the page.
  • The page opens with no stdin, since stdin carries the protocol, and stays open when the request is cancelled.
  • A server with an install record takes its workspace ID from the record, so its sign-in makes no request for it.
  • A server with no install record reads the service at start. A rejected token there exits 2 with the login hint.

Why

Discovery fails before sign-in, so the agent can only start a sign-in through a tool that exists before it. A rejected Databricks token is not fixed by a provider sign-in, so it gets the login hint instead.

Decisions to review

  • No automatic recovery when a credential reads as active but the service keeps rejecting it. Deleting and re-creating an active credential would also delete working ones, for example while the gateway catches up with a sign-in just made in a terminal. Cost: a stale provider grant needs one mcp logout.
  • A 401 that does not ask for sign-in is an auth failure, whatever its body. Cost: a gateway that answers a missing provider sign-in with a bare 401 gets the login hint instead of a sign-in.
  • A page is not reopened after a cancelled attempt that showed it, so a retry does not open a second tab.

Tests

  • libs/aitools/mcp/proxy/challenge_test.go covers the challenge bodies, 401s, call-only challenges, the logout answer, page reopening, queued and cancelled calls, and progress. TestSignInRequiredNamesTheLogoutWhileStillChallenged covers the logout answer after "Already signed in".
  • TestServeSignInUsesTheRecordedWorkspaceID covers the workspace ID taken from the record.
  • Acceptance serve-authenticate-tool runs the stdio flow with BROWSER=none.
  • go test -race ./cmd/aitools/ ./libs/aitools/mcp/..., the TestAccept/cmd/aitools/mcp acceptance tests and GOOS=windows go vet on the same packages pass.
  • Not tested: a live -32042 challenge, and a real browser.

How to review

Refactors that keep behavior: the sign-in path that mcp login and the proxy share (libs/aitools/mcp/login.go, cmd/aitools/mcp_serve.go), and the shared JSON-RPC response envelope in libs/aitools/mcp/proxy/. Read closely: libs/aitools/mcp/proxy/challenge.go (new), its Result method and the 401 rule, and serveChallenge in cmd/aitools/mcp_serve.go.

This pull request and its description were written by Isaac.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 22ff1dcbf | Workflow run

Regression test report

Selected 1 changed tests (limit=20, 0 not selected)

1 tests: regression=1 unreleased=0 coverage=0 failing=0
test branch main (4285bf9) latest (v1.27.0)
TestAccept/cmd/aitools/mcp/serve-authenticate-tool ✅ ❌ ❌
TestAccept/cmd/aitools/mcp/serve-authenticate-tool: branch ✅ | main (4285bf9) ❌ | latest (v1.27.0) ❌

main (4285bf9):

acceptance_test.go:1388: Diff:
        --- cmd/aitools/mcp/serve-authenticate-tool/output.txt
        +++ /tmp/TestAcceptcmdaitoolsmcpserve-authenticate-tool2574208724/002/output.txt
        @@ -1,43 +1,4 @@
        -
        -=== Before sign-in, tools/list answers with one tool, authenticate; it opened no sign-in
        -
        ->>> jq -c select(.id==2) | [.result.tools[].name] serve.stdout.txt
        -["authenticate"]
        -
        ->>> cat stderr-before-authenticate.txt
         No install record for system.ai.github on profile "logfood"; using its current host [DATABRICKS_URL]
        +retry: condition not met after 60 attempts
         
        -=== authenticate waits for the sign-in, then answers and asks the agent to re-list
        -
        ->>> jq -c select(.id==3) | .result | {isError, text: .content[0].text} serve.stdout.txt
        -{"isError":false,"text":"Signed in to system.ai.github on profile logfood. Tools are available now; retry the user's request in this turn."}
        -
        ->>> jq -c select(.method=="notifications/tools/list_changed") serve.stdout.txt
        -{"jsonrpc":"2.0","method":"notifications/tools/list_changed"}
        -
        ->>> cat serve.stderr.txt
        -No install record for system.ai.github on profile "logfood"; using its current host [DATABRICKS_URL]
        -Sign in with the same account you use for Databricks profile logfood.
        -Open this URL to sign in to system.ai.github:
        -[DATABRICKS_URL]/mcp-service-login?name=system.ai.github&o=[WORKSPACE_ID]
        -Waiting for sign-in...
        -Signed in to system.ai.github on profile logfood.
        -Public repositories only until a repository owner installs https://github.com/apps/databricks-github-connector (on AWS GovCloud, https://github.com/apps/databricks-gh-connector-gov-cloud).
        -
        -=== After the sign-in, tools/list passes through and tools/call reaches the service
        -
        ->>> jq -c select(.id==4) | [.result.tools[].name] serve.stdout.txt
        -["echo"]
        -
        ->>> jq -c select(.id==5) | .result.content[0].text serve.stdout.txt
        -"hello"
        -
        -=== Stdout holds only JSON-RPC lines
        -
        ->>> jq -c .jsonrpc serve.stdout.txt
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        +Exit code: 1
        
    acceptance_test.go:1166: 
        LOG.create-github: {
        LOG.create-github:   "comment": "Repositories, issues, pull requests",
        LOG.create-github:   "config": {
        LOG.create-github:     "source_connection": {
        LOG.create-github:       "name": "connections/github",
        LOG.create-github:       "options": {
        LOG.create-github:         "oauth_provider": "github"
        LOG.create-github:       }
        LOG.create-github:     }
        LOG.create-github:   },
        LOG.create-github:   "create_time": "2026-11-19T15:56:19.825539145Z",
        LOG.create-github:   "created_by": "tester@databricks.com",
        LOG.create-github:   "effective_owner": "tester@databricks.com",
        LOG.create-github:   "metastore_id": "7a0e7c4a-0f32-5407-7a0e-7c4a0f32552c",
        LOG.create-github:   "name": "mcp-services/system.ai.github",
        LOG.create-github:   "updated_by": "tester@databricks.com"
        LOG.create-github: }
FAIL

latest (v1.27.0):

acceptance_test.go:1388: Diff:
        --- cmd/aitools/mcp/serve-authenticate-tool/output.txt
        +++ /tmp/TestAcceptcmdaitoolsmcpserve-authenticate-tool573687584/002/output.txt
        @@ -1,43 +1,3 @@
        +retry: condition not met after 60 attempts
         
        -=== Before sign-in, tools/list answers with one tool, authenticate; it opened no sign-in
        -
        ->>> jq -c select(.id==2) | [.result.tools[].name] serve.stdout.txt
        -["authenticate"]
        -
        ->>> cat stderr-before-authenticate.txt
        -No install record for system.ai.github on profile "logfood"; using its current host [DATABRICKS_URL]
        -
        -=== authenticate waits for the sign-in, then answers and asks the agent to re-list
        -
        ->>> jq -c select(.id==3) | .result | {isError, text: .content[0].text} serve.stdout.txt
        -{"isError":false,"text":"Signed in to system.ai.github on profile logfood. Tools are available now; retry the user's request in this turn."}
        -
        ->>> jq -c select(.method=="notifications/tools/list_changed") serve.stdout.txt
        -{"jsonrpc":"2.0","method":"notifications/tools/list_changed"}
        -
        ->>> cat serve.stderr.txt
        -No install record for system.ai.github on profile "logfood"; using its current host [DATABRICKS_URL]
        -Sign in with the same account you use for Databricks profile logfood.
        -Open this URL to sign in to system.ai.github:
        -[DATABRICKS_URL]/mcp-service-login?name=system.ai.github&o=[WORKSPACE_ID]
        -Waiting for sign-in...
        -Signed in to system.ai.github on profile logfood.
        -Public repositories only until a repository owner installs https://github.com/apps/databricks-github-connector (on AWS GovCloud, https://github.com/apps/databricks-gh-connector-gov-cloud).
        -
        -=== After the sign-in, tools/list passes through and tools/call reaches the service
        -
        ->>> jq -c select(.id==4) | [.result.tools[].name] serve.stdout.txt
        -["echo"]
        -
        ->>> jq -c select(.id==5) | .result.content[0].text serve.stdout.txt
        -"hello"
        -
        -=== Stdout holds only JSON-RPC lines
        -
        ->>> jq -c .jsonrpc serve.stdout.txt
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        -"2.0"
        +Exit code: 1
        
    acceptance_test.go:1166: 
        LOG.create-github: {
        LOG.create-github:   "comment": "Repositories, issues, pull requests",
        LOG.create-github:   "config": {
        LOG.create-github:     "source_connection": {
        LOG.create-github:       "name": "connections/github",
        LOG.create-github:       "options": {
        LOG.create-github:         "oauth_provider": "github"
        LOG.create-github:       }
        LOG.create-github:     }
        LOG.create-github:   },
        LOG.create-github:   "create_time": "2026-11-19T15:56:52.277563044Z",
        LOG.create-github:   "created_by": "tester@databricks.com",
        LOG.create-github:   "effective_owner": "tester@databricks.com",
        LOG.create-github:   "metastore_id": "7a0e7c51-9d7c-ea18-7a0e-7c519d7ceb69",
        LOG.create-github:   "name": "mcp-services/system.ai.github",
        LOG.create-github:   "updated_by": "tester@databricks.com"
        LOG.create-github: }
FAIL

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 22ff1dc

Run: 44559297528

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 20 14:59
💚​ aws-windows-latest-4core-16gb 1 274 18 10:27
💚​ azure linux-2core-8gb 1 271 20 16:58
💚​ azure-windows-latest-4core-16gb 1 273 18 9:52
💚​ gcp linux-2core-8gb 1 272 20 14:50
💚​ gcp-windows-latest-4core-16gb 1 274 18 10:11
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 36 slowest tests (at least 2 minutes):
duration env testname
6:31 azure-windows-latest-4core-16gb TestSyncFullFileSync
6:26 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
5:32 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
4:28 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
4:19 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
3:58 aws-windows-latest-4core-16gb TestAccept
3:48 gcp-windows-latest-4core-16gb TestAccept
3:42 gcp linux-2core-8gb TestSyncIncrementalFileSync
3:32 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:18 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
3:10 azure-windows-latest-4core-16gb TestAccept
3:03 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:59 azure linux-2core-8gb TestImportDirDoesNotOverwrite
2:53 gcp-windows-latest-4core-16gb TestSyncIncrementalSyncFileToPythonNotebook
2:46 azure-windows-latest-4core-16gb TestFilerReadWrite/workspace_files_extensions
2:45 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files_extensions
2:43 aws-windows-latest-4core-16gb TestSyncFullFileSync
2:43 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
2:39 gcp linux-2core-8gb TestSyncNestedSpacePlusAndHashAreEscapedSync
2:34 azure linux-2core-8gb TestImportDirWithOverwriteFlag
2:34 aws linux-2core-8gb TestFilerReadWrite/workspace_files_extensions
2:29 gcp-windows-latest-4core-16gb TestFilerReadWrite/workspace_files
2:26 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:23 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:20 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:20 azure linux-2core-8gb TestFilerWorkspaceNotebook/rNb.r
2:20 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files
2:16 aws-windows-latest-4core-16gb TestImportDir
2:14 aws-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:13 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead
2:12 gcp linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:12 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:10 aws linux-2core-8gb TestImportDirWithOverwriteFlag
2:05 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:02 azure linux-2core-8gb TestImportDir
2:01 azure linux-2core-8gb TestFilerRecursiveDelete/workspace_files

@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 38cdd13 to 1d8e6b3 Compare November 12, 2026 14:42
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 1d8e6b3 to 7b98424 Compare November 12, 2026 17:14
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 7b98424 to cb80384 Compare November 13, 2026 05:35
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 1c6aee6 to 7a9dca9 Compare November 13, 2026 07:25
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 1abf7d0 to 6b41591 Compare November 13, 2026 15:05
@pietern pietern added the aitools AI tools (databricks aitools) related changes label Nov 16, 2026
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 6b41591 to 48208cf Compare November 16, 2026 12:47
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch 2 times, most recently from 922dad8 to 7e7f6c7 Compare November 16, 2026 13:32
@simonfaltum
simonfaltum force-pushed the aitools-mcp/07-login branch 2 times, most recently from 43bb551 to e441c85 Compare November 16, 2026 14:49
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 7e7f6c7 to 865e2f5 Compare November 16, 2026 14:49
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch 2 times, most recently from 0952a73 to 1f42a46 Compare November 16, 2026 15:53
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 1f42a46 to d94c24d Compare November 17, 2026 10:52
@simonfaltum
simonfaltum force-pushed the aitools-mcp/07-login branch 2 times, most recently from 661f21e to af69ee8 Compare November 17, 2026 11:21
@simonfaltum
simonfaltum force-pushed the aitools-mcp/07-login branch 2 times, most recently from 14af751 to 9abcc11 Compare November 17, 2026 19:58
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch 2 times, most recently from 8c7ea9b to 160e62d Compare November 17, 2026 22:17
@simonfaltum
simonfaltum marked this pull request as ready for review November 18, 2026 16:20
@simonfaltum
simonfaltum requested review from a team and lennartkats-db as code owners November 18, 2026 16:21

// A call that the client cancelled leaves the logout answer to the next call.
h.stateMu.Lock()
stillChallenged := h.stillChallenged && ctx.Err() == nil

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After stillChallenged is cleared (line 489) and its answer is returned (line 496), the code falls through to check ctx.Err() (line 498). But between line 487 (h.stateMu.Lock()) and line 496, if ctx.Err() != nil the stillChallenged flag was left as-is and we return the logout-answer tool result. That's fine. However on the non-stillChallenged path, when ctx.Err() != nil at line 498, h.stillChallenged was already cleared at line 489 and never restored. A cancelled call that acquired the turn and found stillChallenged true will clear the flag, write no answer, yet the next authenticate won't see stillChallenged either — so the logout answer is lost. The description says "A call that the client cancelled leaves the logout answer to the next call," but the flag is cleared unconditionally. Should the h.stillChallenged = false (line 490) be inside the if stillChallenged block only when ctx.Err() == nil, i.e. move the clearing to where the tool result is returned?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag is cleared only while the call's context is live: stillChallenged is computed as h.stillChallenged && ctx.Err() == nil, and the field is cleared only inside if stillChallenged. A cancelled call sees stillChallenged as false and leaves the field set, so the next call still gets the logout answer. No change.

},
Stderr: h.stderr,
})
h.pageCancelled = urlShown && err != nil && ctx.Err() != nil

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h.pageCancelled is read and written under the turn semaphore but not under stateMu. Meanwhile the doc comment on turn says pageCancelled is read and written under it, which is correct. Just flagging: if pageCancelled is ever accessed outside of the turn (it isn't today), this would race. Looks good as-is, but the field lives on a struct whose other fields are guarded by stateMu — a future reader might add a read of pageCancelled under stateMu by mistake. Would a one-line comment on the field itself ("guarded by turn, not stateMu") help?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it to the field's own comment in b68daa5.

Comment thread cmd/aitools/mcp_serve.go
return serveFailure(cmd, err, 1)
}
}
challenge, err := serveChallenge(ctx, serveTarget{w: w, entry: entry, profile: profileName, service: f.service, pinnedFile: pinnedFile}, cmd.ErrOrStderr())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When entry == nil && !entry.SignInRequired is false (i.e. entry != nil && !entry.SignInRequired), w is nil and serveChallenge is called with t.w == nil. That path returns nil, nil (line 374), so t.w is never dereferenced — but this is subtle. A future change to serveChallenge that reads t.w on the !signInRequired path would panic. Is it worth a comment on serveTarget.w saying it may be nil when the entry says no sign-in is needed?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment on serveTarget.w in b68daa5.

timer := time.AfterFunc(notificationWait, release)
defer timer.Stop()
}
if c.answerLocally(ctx, line) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answerLocally runs after the notification gate timer is started (line 310) but before the idle watchdog (line 317). A locally-answered request that blocks in signInHooks.authenticate for minutes will fire the notification timer, which releases the gate of the next notification. The gate release is a no-op for the locally-handled request itself, but it means the next notification in the queue proceeds immediately instead of waiting notificationWait after its predecessor. Is that intended? The bridge doc says notificationWait is so the upstream finishes its SSE before a notification is sent. If the local answer runs instead of the upstream, the upstream was never started, so releasing the gate early is arguably correct — but it could also let a notification race ahead of a still-running sign-in's list_changed. Can you confirm that the ordering is safe here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case can't happen. release is only non-nil for notifications (handle passes nil for requests), and Local only handles the authenticate tools/call request. So a request answered locally never starts the notification timer and never holds a gate, and the next notification waits only for the notification before it. No change.

@anton-107 anton-107 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed only what this PR adds on top of aitools-mcp/07-login. I found nothing that blocks the merge. The change is a two-way door: the command group is hidden, no persisted state or config format changes, and the shared refactors (signIn's options, the rpcResponse envelope, browser/exec getting a no-stdin opener) leave existing callers' behavior as it was.

Verified locally at b68daa5: go test -race on libs/aitools/mcp/..., cmd/aitools/..., libs/browser, libs/exec, libs/testserver, plus TestAccept/cmd/aitools/mcp, all pass.

Last round: the four bot comments are all resolved. The pageCancelled and serveTarget.w comments were added in b68daa5. The stillChallenged and notification-gate concerns were correctly rebutted: the flag is cleared only inside if stillChallenged, which requires a live ctx, and release is nil for requests.

Non-blocking notes:

  • The description says "The proxy never deletes a credential". The authenticate tool runs mcp.SignIn, though, and that deletes a FAILED credential before showing the page (libs/aitools/mcp/login.go, the ProvisioningInfoStateFailed case). The behavior is fine; "never deletes an active credential" would be more accurate.
  • After an "Already signed in" answer, a later call challenge sets stillChallenged. The tools/call answer (signInRequired) still says "Call the authenticate tool, or run: <mcp login>". In that state, mcp login just reports "Already signed in" again, and only authenticate gives the logout command. Naming the logout command in signInRequired while stillChallenged is set would save a round trip.
  • serveSignIn resolves the workspace ID with auth.ResolveWorkspaceID even when the install record already has entry.WorkspaceID. It runs only once per session, so this is minor.

@simonfaltum

Copy link
Copy Markdown
Member Author

Thanks!

  • The description now says the proxy never deletes an active credential. SignIn deletes a FAILED one, and since Add aitools mcp login, logout and list --check #7551's fix a DEGRADED one, before it shows the page.
  • cf7430a: while stillChallenged is set, a challenged tools/call is answered with the logout command, as authenticate would answer.
  • 6957247: serveSignIn takes the workspace ID from the install record when there is one.

@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from 6957247 to edbd091 Compare November 19, 2026 11:42
@simonfaltum
simonfaltum force-pushed the aitools-mcp/07-login branch 2 times, most recently from 57552af to e6ae53a Compare November 19, 2026 15:11
@simonfaltum
simonfaltum requested a review from a team as a code owner November 19, 2026 15:11
Base automatically changed from aitools-mcp/07-login to main November 19, 2026 15:47
One commit for the restack onto main. The individual commits, up to 6957247, are in the pull request's history.

Co-authored-by: Isaac <no-reply@databricks.com>
@simonfaltum
simonfaltum force-pushed the aitools-mcp/08-challenge branch from edbd091 to 22ff1dc Compare November 19, 2026 15:49
@simonfaltum
simonfaltum added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit de394ed Nov 19, 2026
28 checks passed
@simonfaltum
simonfaltum deleted the aitools-mcp/08-challenge branch November 19, 2026 16:24
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

❌ Integration test report

Commit: de394ed

Run: 44565754264

Env 💥​PANIC ❌​FAIL 🟨​KNOWN 🤯​MISS 💚​RECOVERED ✅​pass 🙈​skip Time
💥​ aws linux-2core-8gb 1 2 470 18 1139 1412 320:00
💥​ aws-windows-latest-4core-16gb 1 4 341 20 1180 1440 320:00
💥​ azure linux-2core-8gb 1 6 454 14 1135 1420 320:00
🟨​ azure-windows-latest-4core-16gb 6 581 15 924 1448 320:00
💥​ gcp linux-2core-8gb 1 624 21 971 1418 320:00
💥​ gcp-windows-latest-4core-16gb 1 2 480 20 1030 1446 320:00
1168 interesting tests: 1134 MISS, 14 KNOWN, 9 RECOVERED, 6 FAIL, 5 PANIC
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
🤯​ TestAccept 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/apps/job_permissions/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_doesnot_exist/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/artifacts/artifact_path_with_volume/volume_not_deployed/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cli_defaults/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_cross_target/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_permissions/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/cluster_policy_remote_addition/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/config_edits 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/config_edits/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/config_edits/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/dashboard_etag/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/flushed_cache/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/formatting_preserved/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_multiple_tasks/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_params_variables/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/job_pipeline_task/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_missing_state/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/json_status_selectors/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_files 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/multiple_files/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_files/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_json 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/output_json/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_json/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/output_no_changes/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/pipeline_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/policy_injected_cluster_fields/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/resolve_variables/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_basic 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/select_basic/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_basic/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_multiple 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/select_multiple/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/select_multiple/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_deployment/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/skip_permissions/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/target_override 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/target_override/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/target_override/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert 🤯​M 🙈​s 🤯​M 🙈​s 🤯​M 🙈​s
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert/DMS= 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/config-remote-sync/task_rename_revert/DMS=true 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/debug/fetch-repository-info/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
💥​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 💥​P 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS= 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/empty-bundle/DATABRICKS_BUNDLE_ENABLE_EXPERIMENTAL_YAML_SYNC=true/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS= 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/files/no-snapshot-sync/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/basic/DMS= 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/breakglass/DMS= 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/can-manage/DMS= 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy 🤯​M ✅​p 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/destroy-redeploy/DMS= 🤯​M ✅​p 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/dev-mode/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/legacy-state/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/missing-snapshot/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/no-artifacts/DMS=/READPLAN=1 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/permissions-change/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/immutable/select/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/mlops-stacks/DMS=true 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS= 🤯​M 🤯​M 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deploy/spark-jar-task/DMS=true 🤯​M 🤯​M 🤯​M 🤯​M ✅​p 🤯​M
🟨​ TestAccept/bundle/deployment/bind/alert 🤯​M 🤯​M 🤯​M 🟨​K 💚​R 🤯​M
🟨​ TestAccept/bundle/deployment/bind/alert/DMS= 🤯​M 🤯​M 🤯​M 🟨​K 💚​R 🤯​M
🟨​ TestAccept/bundle/deployment/bind/alert/DMS=true 🤯​M 🤯​M 🤯​M 🟨​K 💚​R 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS= 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/catalog/DMS=true 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS= 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/cluster/DMS=true 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=/READPLAN= 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=/READPLAN=1 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=true/READPLAN= 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/DMS=true/READPLAN=1 🤯​M ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/recreation ✅​p ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN= ✅​p ✅​p 🤯​M ✅​p ✅​p 🤯​M
🤯​ TestAccept/bundle/deployment/bind/dashboard/recreation/DMS=/READPLAN=1 ✅​p ✅​p 🤯​M ✅​p ✅​p 🤯​M
Top 50 slowest tests (at least 2 minutes):
duration env testname
14:30 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
14:21 azure linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
14:14 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
13:37 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
13:02 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
12:31 azure-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
12:00 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
11:56 aws linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
11:34 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
11:15 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
11:12 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:58 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
10:32 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:23 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
10:21 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:17 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:54 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:52 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
9:30 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=true
9:25 azure-windows-latest-4core-16gb TestAccept/bundle/quiet-levels/DMS=true
9:20 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
9:13 gcp-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=yes/PY=yes/READPLAN=1
8:59 aws-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/integration_classic/DMS=/UV_PYTHON=3.11
8:56 azure-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:55 azure linux-2core-8gb TestAccept/bundle/resources/schemas/rename_then_change/DMS=
8:48 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=yes/PY=yes/READPLAN=
8:42 azure linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=no/PY=no/READPLAN=1
8:34 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=
8:32 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/classic/DLT=yes/DMS=/NBOOK=yes/PY=yes/READPLAN=
8:22 aws-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=yes/DMS=/NBOOK=yes/PY=no/READPLAN=1
8:18 azure linux-2core-8gb TestAccept/bundle/templates/default-python/integration_classic/DMS=/UV_PYTHON=3.10
8:14 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/registered_models/basic/DMS=true
8:12 aws-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/classic/DLT=no/DMS=/NBOOK=yes/PY=no/READPLAN=1
8:11 aws-windows-latest-4core-16gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=yes/PY=yes/READPLAN=1
8:08 aws-windows-latest-4core-16gb TestAccept/bundle/resources/materialization_sets/immutable/DMS=
8:07 azure linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:58 gcp linux-2core-8gb TestAccept/bundle/invariant/continue_293/DMS=/INPUT_CONFIG=job_table_update_trigger.yml.tmpl
7:56 azure-windows-latest-4core-16gb TestAccept/bundle/quiet-levels/DMS=
7:48 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/serverless/DLT=no/DMS=/NBOOK=no/PY=yes/READPLAN=
7:46 azure-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=volume_path_job_ref.yml.tmpl/READPLAN=
7:42 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:41 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:35 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/classic/DLT=no/DMS=/NBOOK=no/PY=no/READPLAN=
7:34 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
7:34 aws linux-2core-8gb TestAccept/bundle/templates/default-python/combinations/classic/DLT=no/DMS=/NBOOK=yes/PY=no/READPLAN=1
7:27 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-omitted/DMS=
7:26 aws linux-2core-8gb TestAccept/bundle/resources/postgres_projects/purge_on_delete_transitions/DMS=true
7:25 gcp linux-2core-8gb TestAccept/pipelines/run/refresh-flags
7:25 gcp linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=vector_search_index.yml.tmpl/READPLAN=1
7:22 aws linux-2core-8gb TestAccept/pipelines/run/refresh-flags
(1019 table rows omitted to keep the report under 60000 bytes)

idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 20, 2026
…tabricks#7595)

This pull request is part of the stack that adds the hidden `databricks
aitools mcp` command group; its parent is databricks#7553. `aitools mcp add` and
`remove` now change the Claude Code, Gemini CLI and Copilot CLI configs
through each agent's own MCP command, when that CLI is on PATH. Codex
CLI configs are always written directly.

## Changes
- A new entry runs the agent's add command when its config file exists:
`claude mcp add-json --scope user`, `gemini mcp add --scope user`, or
`copilot mcp add --tools *`. A config file that does not exist yet is
written directly, with mode 0600, since the agent's CLI would create it
with its own permissions. Afterwards the config file holds the entry
asked for, whatever the exit status: a differing entry is replaced, and
a missing one is added directly. An entry that already exists is updated
by the direct writer.
- `remove` runs the CLI's remove for an entry we wrote, when the agent
reads that file now. A CLI failure, or an entry left behind, falls back
to the direct writer.
- Symlinked configs, names that start with `-`, and Codex always use the
direct writer.
- The CLI runs in an empty directory with a 30-second timeout, in the
foreground process group so Ctrl-C reaches it.
- For an agent that locks its config (Claude Code, see databricks#7539), only the
direct writer takes the lock. It is never held while the agent's CLI
runs, since that CLI takes the same lock.

## Why
An agent's own CLI writes its config with its own locking and layout,
and follows the agent when its file format changes. Codex is the
exception. With Codex CLI 0.167.1, `codex mcp add` and `codex mcp
remove` rewrote every `[mcp_servers.*]` table of an 11-server config:
they dropped `enabled = true` keys, collapsed multi-line arrays, turned
`10` into `10.0`, and converted CRLF to LF.

## Decisions to review
- The file decides, not the exit status. Cost: a CLI that writes another
file keeps its entry there, and ours is also added to the agent's file.
- A differing entry is replaced, not refused. Cost: our launch keys win
over the CLI's choices.
- Existing entries use the direct writer, since the add commands replace
whole entries. Cost: two paths write one file.
- Codex always uses the direct writer. Cost: comments inside a
Databricks server's own tables are lost on either path.
- A hung CLI costs the 30-second timeout for each server.
- On Windows, a `.cmd` shim gets only arguments without spaces, double
quotes or `cmd.exe` special characters. Other arguments use the direct
writer.

## Tests
- `libs/aitools/agents` covers argv per agent, including a Windows path
with spaces. `agentconfig/cli_test.go` covers each outcome of an add,
`TestAgentCLIRunsWithoutTheLock` the lock, symlinks, missing config
files, dash names and the timeout, and the Codex direct writer.
`libs/process` covers `WithoutEnv`, which ignores case on Windows.
- `acceptance/cmd/aitools/mcp/add-remove-agent-clis` covers each agent's
argv and the files it wrote.
- `./task test-exp-aitools` passes with `BROWSER` unset and with
`BROWSER=none`.
- Not tested: the Copilot and Gemini binaries, which are not installed
here, so their argv follows their docs and source. Windows runs, which
CI covers. `-inprocess` mode, which already fails on the base for these
tests.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aitools AI tools (databricks aitools) related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants