Skip to content

aitools: Hint the AI Runtime skill on air subcommands - #7622

Open
artemy-kolesnikov wants to merge 11 commits into
mainfrom
CNXT-2593-air-only-aitools-hint
Open

artemy-kolesnikov wants to merge 11 commits into
mainfrom
CNXT-2593-air-only-aitools-hint

Conversation

@artemy-kolesnikov

@artemy-kolesnikov artemy-kolesnikov commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Changes

The Claude Code install hint (agents.MaybeHint, run from the root PersistentPreRunE since #5918) prints one generic line on every non-aitools command:

Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install

This change is deliberately narrow: behavior on non-air commands is unchanged. Only on runnable databricks air subcommands (run, get, list, logs, cancel, convert-to-dabs, images/images push, pools/pools list/pools get) does Claude Code's hint text change, to name the skill it can use there and give both the install and a no-install preview:

Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.
  • Non-air commands keep the generic hint exactly as on main: auth profiles, version, jobs list, apps init (with its own APPS_INIT_TIP), and every other hinted command print the same lines as before. The native <claude-code-hint> plugin line (aitools: emit Claude Code's native plugin install hint #7585) and the per-agent install hints for Codex, Copilot, Cursor and the rest (aitools: install hints for non-Claude coding agents #7586) are untouched, on air and off it; the air run --help skill pointer (air: Point to the databricks-ai-runtime skill in air run --help #7652) is untouched. Agents other than Claude Code keep their generic hint on air subcommands too: the installer has no per-agent AI Runtime variant to offer them.
  • Detection (air path): the hint is silenced only by exactly the databricks-ai-runtime skill in a location Claude Code loads for the working directory — Claude's own skills dir, the project skills dir of cwd or a parent up to the repository root, or the databricks plugin counted only when its record applies to cwd. Before this change, any databricks* skill (for example only databricks-jobs) silenced the hint, even on air. The generic path's detection (claudeToolingInstalled) is unchanged.
  • Bare air and air --help: cobra renders help without running PersistentPreRunE, so the hook can't fire there. The air help footer now has the benefit line and the --path preview under the existing "Coding agent skill" line.
  • Unchanged: the CLAUDE_CODE_SESSION_ID throttle (at most one hint per hour per session, shared between the generic and air text, so a hint shown on an earlier non-air command also covers the agent's first air command; with no session id the hint prints per command, as before), the telemetry kind (INSTALL_TEXT), the aitools-subtree and credential-helper exemptions, and the Claude-only gating. No new enum value; ExecutionContext.Command already tells air commands apart.
  • .nextchanges/cli/air-skill-hint.md is added.

Why

In a coding-agent run (Claude Code), the agent saw the generic hint on databricks auth profiles. It read the hint as unrelated setup noise and went to docs instead of the skill. Rather than removing the generic hint anywhere (a product call for the DECO maintainers), this change adds the skill-specific recommendation only where the skill applies — an agent running air has an AI Runtime task for it to help with — and names the skill so the agent can tell the hint is about the task at hand. #7452's description makes the same point: calls with no task to apply the skills to "do not convert".

Needs maintainer sign-off on the air wording. The generic hint is an existing feature and stays as is; this PR only swaps Claude Code's text on air subcommands and keys the air detection to the exact skill. If maintainers prefer a different wording, target set, or an extension of the skill-specific text to the other agents, that is a small local change.

Why this is based on main, not stacked on #7452 or #7578:

Tests

New unit tests:

  • libs/aitools/agents/hint_test.go:
    • TestMaybeHint_NonAIRCommandsKeepGenericHint: outside air (including auth profiles, version, bare air and the hidden experimental air alias) Claude Code gets the generic hint, never the skill line.
    • TestMaybeHint_AIRSubcommandsHint: runnable air subcommands, including nested ones, get the skill line.
    • TestMaybeHint_AIRSkillDetection and TestMaybeHint_AIRSkillInRepositoryRoot: Claude's own skills dir, project skills dirs, repository root seen from a subdirectory; other databricks* skills only; a file named like the skill; the shared canonical and legacy stores; a plugin for this project vs. an unrelated project.
    • TestMaybeHint_AIRSessionThrottle: with a session id only the first hinted command is hinted, and a generic hint shown on a non-air command covers the session's air commands too. TestMaybeHint_OtherSessionStillHinted and TestAIRHintText.
    • TestHintForCommand: the air/generic split per agent.
    • The TestMaybeHint_NativeHint table gains air rows: child session + air prints the native line then the skill line, and an installed skill silences it.
  • libs/aitools/agents/hint_agents_test.go: TestMaybeHint_AgentInstallHintUnchangedOnAIR pins that non-Claude agents keep their generic install hint on air subcommands.
  • cmd/air/hint_test.go:
    • TestRunnableAirCommandsGetSkillHint walks the real air tree, so a new subcommand is covered automatically.
    • TestBareAirAndHelpShowFooterWithoutPreRun runs bare air and air --help, and asserts the footer content and that the pre-run hook did not run.
  • cmd/air/air_test.go: TestHelpFooterOnlyOnAirCommand also asserts the skill line, the benefit line and the --path preview.

Existing tests and goldens:

  • The generic-hint tests (regularCmd, throttle, native-hint table, claudeToolingInstalled detection) are unchanged from main and still pass.
  • acceptance/air/image-push: the hint on an air subcommand is now the skill line.
  • acceptance/air/help: golden updated for the footer.
  • All other acceptance goldens (cmd/aitools/*, cmd/version) are unchanged from main.

Results: go test ./libs/aitools/... ./cmd/air/... ./cmd/root/... ./cmd/version/... ./libs/telemetry/... passes. Acceptance TestAccept/cmd/aitools, TestAccept/cmd/version and TestAccept/air pass. golangci-lint on the touched packages reports 0 issues, and gofmt and validate_nextchanges.py are clean.

Manual end-to-end check: a local build in a fresh temp HOME, no workspace calls, run under the Claude Code Bash tool (non-TTY):

Command (CLAUDECODE=1, no session id) main stderr This change
auth profiles generic hint + config error unchanged
version generic hint unchanged
jobs list (Codex) per-agent install hint unchanged
air list generic hint + auth error air skill hint + auth error
air --help / bare air footer without benefit/preview footer with benefit + --path preview
aitools install --path $HOME/preview --skills databricks-ai-runtime writes SKILL.md, no state same; next air list still hinted
air list with only databricks-jobs installed silent (bug) air skill hint
air list with databricks-ai-runtime in <cwd>/.claude/skills generic hint (bug) silent
air list with the plugin installed for another project silent (bug) air skill hint
air list, then air get 1, same session id hint once hint once
air list / auth profiles without CLAUDECODE silent silent

This pull request and its description were written by Isaac.

The Claude Code install hint fired on every non-aitools command with a
generic line ("Databricks skills are not installed..."). Coding agents
treat it as unrelated noise on commands like `auth profiles`, and it
never named the skill that helps with the task at hand.

MaybeHint now fires only on runnable `databricks air` subcommands and
names the databricks-ai-runtime skill, what it covers, the install
command, and a no-install preview (`aitools install --path`). Detection
looks for that skill by exact name in the home stores and the project
store (cwd up to the repository root), and counts the databricks plugin
only when it applies to cwd. Bare `air` and `air --help` render help
without the pre-run hook, so the air help footer now carries the same
benefit line and the preview command. Telemetry keeps INSTALL_TEXT and
the per-session throttle is unchanged.

Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added the AIR Databricks AI Runtime CLI label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Commit: 4fdad3159 | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

2 tests: regression=2 unreleased=0 coverage=0 failing=0
test branch main (73b204d) latest (v1.26.0)
TestAccept/air/help ✅ ❌ ❌
TestAccept/air/image-push ✅ ❌ ❌
TestAccept/air/help: branch ✅ | main (73b204d) ❌ | latest (v1.26.0) ❌

main (73b204d):

acceptance_test.go:1388: Diff:
        --- air/help/output.txt
        +++ /tmp/TestAcceptairhelp1581940838/002/output.txt
        @@ -43,10 +43,6 @@
           Quickstart (AWS)         https://docs.databricks.com/aws/en/machine-learning/ai-runtime/quickstart
           Quickstart (Azure)       https://learn.microsoft.com/azure/databricks/machine-learning/ai-runtime/quickstart
           Coding agent skill       databricks aitools install --skills-only --skills databricks-ai-runtime
        -                           Teaches coding agents the workload YAML, GPU types, secrets,
        -                           and how to follow and debug runs.
        -  Preview the skill        databricks aitools install --path <dir> --skills databricks-ai-runtime
        -                           Writes the skill files to <dir> without installing anything.
         
         === list help

latest (v1.26.0):

acceptance_test.go:1388: Diff:
        --- air/help/output.txt
        +++ /tmp/TestAcceptairhelp3441593275/002/output.txt
        @@ -2,52 +2,34 @@
         === help
         
         >>> [CLI] air --help
        -Run GPU workloads on Databricks serverless compute.
        +Run and manage AI Runtime training workloads on Databricks serverless GPU compute.
         
        -Describe a workload in a YAML file and submit it with "databricks air run".
        -Follow a run with "databricks air logs" and "databricks air get", or see your
        -active runs with "databricks air list".
        +These commands are under active development.
         
         Usage:
           databricks air [command]
         
        -Run workloads:
        -  run             Submit a workload from a YAML config
        -
        -Manage runs:
        +Available Commands:
           cancel          Cancel one or more runs
        -  get             Show a run's status, configuration, and timing
        -  list            List your active runs
        -  logs            Stream or fetch a run's logs
        +  convert-to-dabs Convert an AIR run YAML into a Databricks Asset Bundle
        +  get             Show status, configuration, and timing details for a specified run
        +  images          Manage container images for AI Runtime
        +  list            List active runs for the current user
        +  logs            Stream or fetch logs for a run
        +  pools           View provisioned GPU pools
        +  run             Submit a training workload from a YAML config
         
        -Package and deploy:
        -  convert-to-dabs Convert a workload YAML into a Databricks Asset Bundle
        -  images          Push container images for custom environments
        -
        -Provisioned capacity:
        -  pools           View provisioned GPU pools, if any (not required to run)
        -
         Flags:
        -  -h, --help[=true|false]   help for air
        +  -h, --help   help for air
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         Use "databricks air [command] --help" for more information about a command.
         
        -Learn more:
        -  YAML fields and example  databricks air run -h config
        -  Quickstart (AWS)         https://docs.databricks.com/aws/en/machine-learning/ai-runtime/quickstart
        -  Quickstart (Azure)       https://learn.microsoft.com/azure/databricks/machine-learning/ai-runtime/quickstart
        -  Coding agent skill       databricks aitools install --skills-only --skills databricks-ai-runtime
        -                           Teaches coding agents the workload YAML, GPU types, secrets,
        -                           and how to follow and debug runs.
        -  Preview the skill        databricks aitools install --path <dir> --skills databricks-ai-runtime
        -                           Writes the skill files to <dir> without installing anything.
        -
         === list help
         
         >>> [CLI] air list --help
        @@ -56,9 +25,7 @@
         Filters:
           Use --filter KEY=VALUE per condition. A run must match every condition.
         
        -  accelerator_type  Accelerator family or full YAML type. Examples:
        -                    A10, H100, GPU_1xA10, GPU_8xH100.
        -                    Workspace types: databricks air run -h config.compute.accelerator_type
        +  accelerator_type  Accelerator type, such as A10 or H100.
           experiment        Case-insensitive glob matched against the experiment name.
           num_accelerators  Total GPU count.
           user              Run creator identifier.
        @@ -69,78 +36,71 @@
         Examples:
           databricks air list --filter accelerator_type=H100
         
        -  databricks air list --filter accelerator_type=GPU_8xH100
        -
           databricks air list --all-status \
             --filter 'experiment=qwen*' \
             --filter num_accelerators=8 \
             --filter user=person@example.com
         
         Flags:
        -      --all-status[=true|false]   Show runs in all states (default: active only)
        -      --all-users[=true|false]    Show runs from all users
        -      --filter stringArray        Filter runs by KEY=VALUE (repeatable)
        -  -h, --help[=true|false]         help for list
        -      --limit int                 Maximum number of runs to show (default 20)
        +      --all-status           Show runs in all states (default: active only)
        +      --all-users            Show runs from all users
        +      --filter stringArray   Filter runs by KEY=VALUE (repeatable)
        +  -h, --help                 help for list
        +      --limit int            Maximum number of runs to show (default 20)
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         === get help
         
         >>> [CLI] air get --help
        -Show a run's status, configuration, and timing.
        +Show status, configuration, and timing details for a specified run.
         
        -JOB_RUN_ID is the job run ID returned by "databricks air run".
        +JOB_RUN_ID is the job run ID returned by "air run".
         
         Usage:
           databricks air get JOB_RUN_ID [flags]
         
         Flags:
        -  -h, --help[=true|false]             help for get
        -      --include-config[=true|false]   Include stored config in JSON (downloads over 1 MiB are omitted; may contain plaintext env_variables and parameters)
        +  -h, --help   help for get
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         === pools help
         
         >>> [CLI] air pools --help
        -View GPU pools provisioned for your workspace.
        +View provisioned GPU pools
         
        -A GPU pool is dedicated accelerator capacity that your Databricks account team
        -provisions. Pools are optional: a run uses one only when its YAML sets
        -compute.pool_id.
        -
         Usage:
           databricks air pools [flags]
           databricks air pools [command]
         
         Available Commands:
        -  get         Show a GPU pool and its accelerator usage
        +  get         Show a GPU pool, including its accelerator usage (POOL_ID may be omitted when the workspace has exactly one pool)
           list        List the GPU pools available to the current workspace
         
         Flags:
        -  -h, --help[=true|false]   help for pools
        +  -h, --help   help for pools
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         Use "databricks air pools [command] --help" for more information about a command.
         
         === images help
         
         >>> [CLI] air images --help
        -Push container images for custom environments
        +Manage container images for AI Runtime
         
         Usage:
           databricks air images [flags]
        @@ -150,13 +69,13 @@
           push        *Preview* Push a container image to Databricks Artifact Registry
         
         Flags:
        -  -h, --help[=true|false]   help for images
        +  -h, --help   help for images
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
... (96 more lines truncated, raise DATABRICKS_CLI_TEST_MAX_LOG to see more)
TestAccept/air/image-push: branch ✅ | main (73b204d) ❌ | latest (v1.26.0) ❌

main (73b204d):

acceptance_test.go:1388: Diff:
        --- air/image-push/output.txt
        +++ /tmp/TestAcceptairimage-push391615062/002/output.txt
        @@ -218,7 +218,7 @@
         
         >>> databricks air images push -p docker-test -s example/image:v1 --catalog main --schema training
         <claude-code-hint v="1" type="plugin" value="databricks@claude-plugins-official" />
        -Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.
        +Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
         Warning: This feature is in Preview. APIs may change, and the workspace must enable the Preview features.
         Pushing example/image:v1 as main.training.image:v1 using profile docker-test
         Configured Docker credential helper for [WORKSPACE_ID].container.us-west-2.localhost
        @@ -233,7 +233,7 @@
         
         >>> musterr databricks air images push -p pat-test -s example/image:v1 --catalog main --schema training
         <claude-code-hint v="1" type="plugin" value="databricks@claude-plugins-official" />
        -Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.
        +Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
         Warning: This feature is in Preview. APIs may change, and the workspace must enable the Preview features.
         Pushing example/image:v1 as main.training.image:v1 using profile pat-test
         Error: configure Docker authentication: run auth docker configure: exit status 1: Error: profile "pat-test" uses auth_type "pat". Docker credential helper requires a profile created by databricks auth login
        
FAIL

latest (v1.26.0):

acceptance_test.go:1388: Diff:
        --- air/image-push/output.txt
        +++ /tmp/TestAcceptairimage-push604547811/002/output.txt
        @@ -150,18 +150,18 @@
           databricks air images push [flags]
         
         Flags:
        -      --artifact string     Destination ARTIFACT[:TAG]; defaults to the source image name and tag (latest if untagged); maximum 255 characters for catalog.schema.artifact and 128 for the tag
        -      --catalog string      Destination Unity Catalog catalog; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        -  -h, --help[=true|false]   help for push
        -      --pull[=true|false]   Pull the source image even when it is already available locally
        -      --schema string       Destination Unity Catalog schema; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        -  -s, --source string       Source container image to push (NAME[:TAG] or NAME@DIGEST)
        +      --artifact string   Destination ARTIFACT[:TAG]; defaults to the source image name and tag (latest if untagged); maximum 255 characters for catalog.schema.artifact and 128 for the tag
        +      --catalog string    Destination Unity Catalog catalog; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        +  -h, --help              help for push
        +      --pull              Pull the source image even when it is already available locally
        +      --schema string     Destination Unity Catalog schema; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        +  -s, --source string     Source container image to push (NAME[:TAG] or NAME@DIGEST)
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         
         >>> musterr databricks air images push --image artifact
        @@ -171,18 +169,18 @@
           databricks air images push [flags]
         
         Flags:
        -      --artifact string     Destination ARTIFACT[:TAG]; defaults to the source image name and tag (latest if untagged); maximum 255 characters for catalog.schema.artifact and 128 for the tag
        -      --catalog string      Destination Unity Catalog catalog; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        -  -h, --help[=true|false]   help for push
        -      --pull[=true|false]   Pull the source image even when it is already available locally
        -      --schema string       Destination Unity Catalog schema; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        -  -s, --source string       Source container image to push (NAME[:TAG] or NAME@DIGEST)
        +      --artifact string   Destination ARTIFACT[:TAG]; defaults to the source image name and tag (latest if untagged); maximum 255 characters for catalog.schema.artifact and 128 for the tag
        +      --catalog string    Destination Unity Catalog catalog; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        +  -h, --help              help for push
        +      --pull              Pull the source image even when it is already available locally
        +      --schema string     Destination Unity Catalog schema; use lowercase letters and digits separated by one or two underscores or one or more hyphens
        +  -s, --source string     Source container image to push (NAME[:TAG] or NAME@DIGEST)
         
         Global Flags:
        -      --debug[=true|false]   enable debug logging
        -  -o, --output type          output type: text or json (default text)
        -  -p, --profile string       ~/.databrickscfg profile
        -  -t, --target string        bundle target to use (if applicable)
        +      --debug            enable debug logging
        +  -o, --output type      output type: text or json (default text)
        +  -p, --profile string   ~/.databrickscfg profile
        +  -t, --target string    bundle target to use (if applicable)
         
         
         === reject oversized catalog.schema.artifact before Docker operations
        @@ -217,10 +213,10 @@
         === in a Claude Code session the auth docker configure child adds no install hint
         
         >>> databricks air images push -p docker-test -s example/image:v1 --catalog main --schema training
        -<claude-code-hint v="1" type="plugin" value="databricks@claude-plugins-official" />
        -Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.
        +Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
         Warning: This feature is in Preview. APIs may change, and the workspace must enable the Preview features.
         Pushing example/image:v1 as main.training.image:v1 using profile docker-test
        +Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
         Configured Docker credential helper for [WORKSPACE_ID].container.us-west-2.localhost
         Updated Docker config: [TEST_TMP_DIR]/home/docker/config.json
         Installed Docker credential helper: [TEST_TMP_DIR]/home/bin/docker-credential-databricks
        @@ -232,8 +226,8 @@
         Now you can set `environment.unity_catalog_image = main.training.image:v1` in your YAML config and create a workload with `databricks air run -f config.yaml`.
         
         >>> musterr databricks air images push -p pat-test -s example/image:v1 --catalog main --schema training
        -<claude-code-hint v="1" type="plugin" value="databricks@claude-plugins-official" />
        -Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.
        +Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
         Warning: This feature is in Preview. APIs may change, and the workspace must enable the Preview features.
         Pushing example/image:v1 as main.training.image:v1 using profile pat-test
        -Error: configure Docker authentication: run auth docker configure: exit status 1: Error: profile "pat-test" uses auth_type "pat". Docker credential helper requires a profile created by databricks auth login
        +Error: configure Docker authentication: run auth docker configure: exit status 1: Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
        +Error: profile "pat-test" uses auth_type "pat". Docker credential helper requires a profile created by databricks auth login
        
FAIL

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 4fdad31

Run: 44369468191

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 21 12:43
💚​ aws-windows-latest-4core-16gb 1 274 19 6:15
💚​ azure linux-2core-8gb 1 271 21 11:33
💚​ azure-windows-latest-4core-16gb 1 273 19 6:38
💚​ gcp linux-2core-8gb 1 272 21 13:53
💚​ gcp-windows-latest-4core-16gb 1 274 19 7:31
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 9 slowest tests (at least 2 minutes):
duration env testname
4:54 gcp linux-2core-8gb TestFilerRecursiveDelete/files
3:26 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
3:14 azure-windows-latest-4core-16gb TestAccept
3:14 gcp-windows-latest-4core-16gb TestAccept
2:52 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsReadDir
2:43 aws linux-2core-8gb TestFilerWorkspaceFilesExtensionsRead
2:37 aws-windows-latest-4core-16gb TestAccept
2:33 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:12 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsRead

artemy-kolesnikov and others added 2 commits November 13, 2026 23:48
Co-authored-by: Isaac <no-reply@databricks.com>
Windows paths contain backslashes, so interpolating them into the manifest
string produced invalid JSON escapes and the plugin record was silently
dropped, hinting when the test expected silence. Marshal the manifest
instead.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern pietern added the aitools AI tools (databricks aitools) related changes label Nov 16, 2026
idelafuente-oc pushed a commit to idelafuente-oc/cli that referenced this pull request Nov 16, 2026
…bricks#7652)

Replaces databricks#7628, which was opened from a fork and couldn't run CI. Same
change, rebased on `main`.

## Changes
`databricks air run --help` now names the databricks-ai-runtime agent
skill and gives the install command, below the `-h config` lookup lines:

```
  databricks air run -h config.compute.accelerator_type   one field

To have a coding agent write the YAML and follow the run, install the
databricks-ai-runtime skill:

  databricks aitools install --skills-only --skills databricks-ai-runtime
```

- The install command is now a constant, `skillInstallCommand`, in
`cmd/air/runconfig.go`. The `-h config` skill note uses it as well.
- The `air -h` footer in `cmd/air/air.go` still has its own copy of the
command. I left that file alone because databricks#7622 edits the same footer. It
can move to the constant after that PR lands.

## Why
Coding agents read `air run --help` right before they write a workload
YAML, so this page should point to the skill.
- On v1.26.0 the skill appears only in `air run -h config`.
- On `main`, databricks#7512 added it to the `air -h` footer too. `air run --help`
still doesn't mention it.
- databricks#7622 makes the install hint name this skill on air subcommands. That
hint runs from `PersistentPreRunE`, and cobra doesn't run that for
`--help`. Help text is the only way to show the skill on help pages.

## Tests
- New unit test `TestRunHelpPointsToAgentSkill` in
`cmd/air/air_test.go`.
- Regenerated `acceptance/air/config-help/output.txt` with `-update`.
The only diff is the 5 new lines in `air run --help`.
- Passing: `go test ./acceptance -run 'TestAccept/air/'`, `go vet
./cmd/air/`, `./task lint-q` and `./task ws`.
- `go test ./cmd/air/` passes except
`TestLogsCommandRepeatsRunLinkAfterStreaming`. That test fails the same
way on an unmodified `origin/main` checkout (bdb37ab) in this
environment.

This pull request and its description were written by Isaac.

---------

Co-authored-by: Isaac <no-reply@databricks.com>
@artemy-kolesnikov
artemy-kolesnikov marked this pull request as ready for review November 16, 2026 17:17

@vinchenzo-db vinchenzo-db left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you removed the generic Claude Code install hint across all non-air commands in the Databricks CLI.... are we sure we want to do that? regardless I'm not sure my stamp matters too much here, this is more of a broader DECO maintainers question.

Databricks skills are not installed. To work with Databricks reliably, first run: databricks aitools install
Databricks CLI v[CLI_VERSION]
>>> CLAUDE_CONFIG_DIR=missing [CLI] air list
Tip: the databricks-ai-runtime skill is not installed. It documents the air workload YAML, GPU types, secrets, and how to follow and debug runs. Install it: databricks aitools install --skills-only --skills databricks-ai-runtime (to read it first without installing: databricks aitools install --path <dir> --skills databricks-ai-runtime)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest tightening this a little:

Tip: install the databricks-ai-runtime skill for workload configuration and run debugging: databricks aitools install --skills-only --skills databricks-ai-runtime. To preview it first, replace --skills-only with --path <dir>.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied — the hint now reads exactly that (in libs/aitools/agents/hint.go, pinned by the air goldens such as acceptance/air/image-push/output.txt).

Note this file itself is back to its main golden since then: the change was narrowed so only runnable databricks air subcommands use this wording, and claude-config-dir exercises a non-air command, which keeps the generic install hint. As of ca03773.

artemy-kolesnikov and others added 4 commits November 16, 2026 18:36
Use the reviewer-suggested wording: name the skill and its benefit up
front, then the install command, then the --path preview.

Co-authored-by: Isaac <no-reply@databricks.com>
…tools-hint

# Conflicts:
#	acceptance/cmd/aitools/claude-config-dir/output.txt
#	acceptance/cmd/aitools/claude-config-dir/script
#	acceptance/cmd/aitools/telemetry/hint/output.txt
#	acceptance/cmd/aitools/telemetry/hint/script
#	acceptance/cmd/version/script
#	libs/aitools/agents/calling.go
#	libs/aitools/agents/hint.go
#	libs/aitools/agents/hint_test.go
#	libs/aitools/agents/recommend.go
Narrow the change so non-air commands behave exactly as before: Claude
Code keeps the generic install hint and the registry agents keep their
per-agent install hints on every hinted command. Only on runnable
'databricks air' subcommands does Claude Code now get the AI Runtime
skill recommendation instead of the generic hint, with detection keyed
to exactly the databricks-ai-runtime skill in the locations Claude Code
loads for the working directory.

Co-authored-by: Isaac <no-reply@databricks.com>
@artemy-kolesnikov artemy-kolesnikov changed the title aitools: Hint the AI Runtime skill only on air subcommands aitools: Hint the AI Runtime skill on air subcommands Nov 16, 2026
@artemy-kolesnikov

Copy link
Copy Markdown
Contributor Author

Fair question — the change is now narrowed so the answer is no: nothing is removed. Non-air commands keep the generic Claude Code install hint and the per-agent install hints exactly as on main; only runnable databricks air subcommands swap Claude Code's text for the databricks-ai-runtime skill recommendation (your suggested wording), with detection keyed to exactly that skill. Agents other than Claude Code keep their generic hint on air subcommands too.

The DECO-maintainers question remains, but only about the air wording and whether the skill-specific text should extend to the other agents — both small local changes if you'd prefer something else. As of ca03773.

artemy-kolesnikov and others added 4 commits November 17, 2026 10:14
…anch

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIR Databricks AI Runtime CLI aitools AI tools (databricks aitools) related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants