Repository navigation
Conversation
--skip-validate never validates, so every profile showed NO in the Valid column, including valid ones in active use. Agents choose a profile from this output and read NO as "log in again". JSON output is unchanged. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/cmd/auth/profiles: branch ✅ | main (20fef7c) ❌ | latest (v1.26.0) ❌main (20fef7c): latest (v1.26.0): same output as main (20fef7c) TestAccept/cmd/auth/switch/nominal: branch ✅ | main (20fef7c) ❌ | latest (v1.26.0) ❌main (20fef7c): latest (v1.26.0): same output as main (20fef7c) |
✅ Integration test reportCommit: e56d4c2
Top 3 slowest tests (at least 2 minutes):
|
Comment why SkipValidate stays out of JSON, and state the skip-validate output in the flag help. Add a text-mode `auth profiles --skip-validate` case to the command's own acceptance test. Reword the changelog entry to say the command now omits the `Valid` column. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Apply the existing `auth` label, which nothing applies today. Examples: databricks#7638, databricks#7522. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
|
/review |
There was a problem hiding this comment.
Automated review at e56d4c2. Each finding was verified against the code.
No blocking issues found.
This PR makes auth profiles --skip-validate omit the Valid column from text output instead of showing NO for every profile, while keeping JSON output unchanged. The implementation is clean: a render-only boolean on an anonymous render-only struct, guarded by json:"-", drives a conditional column in the template. Acceptance tests cover both text and JSON modes. I found no correctness issues or rule violations.
Changes
--skip-validate, theauth profilestext table omits theValidcolumn instead of printingNOfor every profile. Without the flag, output is unchanged.Skip validating the profiles (the Valid column is omitted and JSON "valid" is always false).validstaysfalsewhen validation is skipped), so the shape stays stable for tools that parse it. The render-only field carries a comment saying why it is kept out of JSON.Why
--skip-validatenever validates, so every profile showedNO, including valid profiles in active use. Thedatabricks-ai-runtimeagent skill starts sessions with exactlydatabricks auth profiles --skip-validateto choose a profile, and agents readNOas "log in again".Tests
acceptance/cmd/auth/profiles(auth profiles --skip-validate), and the updatedacceptance/cmd/auth/switch/nominalgolden.Validcolumn (login/nominal,login/discovery,logout/stale-account-id-workspace-host, ...) and the JSON goldens pass unchanged.go test ./cmd/auth/...andgo test ./acceptance -run 'TestAccept/cmd/auth/'pass;./task lint-q,./task fmt-qand./task check-changelogare clean. Tests ran withDATABRICKS_WORKSPACE_IDunset: some tests inlogin_test.goandtoken_test.goalso fail onmainwhen that variable is set.This pull request and its description were written by Isaac.