Repository navigation
air logs: print waiting status when stderr is not a terminal - #7651
Closed
anshul0713 wants to merge 2 commits into
Closed
anshul0713 wants to merge 2 commits into
anshul0713 wants to merge 2 commits into
Conversation
The "waiting for run to start" spinner degrades to nothing on a non-interactive stderr, so agents and CI saw no output at all while a run provisioned, and killed `air logs` as hung. Print each new waiting status as one stderr line instead. Co-authored-by: Isaac <no-reply@databricks.com> (cherry picked from commit 0a2112c46e3462e3a661a1313825a3e7a2e2683b)
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
Superseded by #7657: the same change, opened from a branch in this repo so the full CI and integration tests can run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When stderr isn't a terminal,
databricks air logsanddatabricks air run --watchnow print each new waiting status as one line on stderr, for exampleWaiting for accelerator compute capacity to become available.... Interactive terminals still get the spinner, unchanged.Why
While waiting for the first log line, the streamer shows a spinner, and on a non-interactive stderr
cmdiodrops the spinner entirely. Coding agents, CI and pipes therefore saw no output at all while a run waited for a GPU or provisioned. In agent trials of a 1x A10 training task, agents repeatedly killedair logswithtimeoutafter 25-30 s, treating it as hung, and then guessed at the run's state.The server status message is already fetched and only updated when it changes, so this adds at most a few lines per wait.
Tests
TestStreamBricklensPrintsWaitingStatusWithoutTTY. It fails onmain(empty stderr) and passes with this change.TestLogsCommandRepeatsRunLinkAfterStreamingcaptures stdout and stderr in one non-TTY buffer, so its expected output now includes the waiting line.go test ./cmd/air/...andgo test ./acceptance -run TestAccept/airpass.This pull request and its description were written by Isaac.