Repository navigation
serving-endpoints: show served entity deployment state while waiting - #7659
Open
anshul0713 wants to merge 2 commits into
Open
anshul0713 wants to merge 2 commits into
anshul0713 wants to merge 2 commits into
Conversation
`serving-endpoints create` and `update-config` only showed `current status: IN_PROGRESS` in a spinner for the whole deployment, and printed nothing when stderr is not a terminal. Show each served entity's deployment_state_message with the time waited, and print one stderr line per change when there is no TTY. Stdout is unchanged. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Anshul Gupta <anshul.gupta@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: Anshul Gupta <anshul.gupta@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/cmd/workspace/serving-endpoints: branch ✅ | main (620ea05) ❌ | latest (v1.26.0) ❌main (620ea05): latest (v1.26.0): same output as main (620ea05) |
Collaborator
✅ Integration test reportCommit: e4f05bf
Top 3 slowest tests (at least 2 minutes):
|
This was referenced Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
databricks serving-endpoints createandupdate-confignow show each served entity's deployment state and the time waited while they wait for the endpoint. Before, they showed onlycurrent status: IN_PROGRESS, which stays the same for the whole deployment.When stderr isn't a terminal, each state change is printed as one line on stderr. Before, nothing was printed. Interactive terminals still get the spinner, now with the new text. Stdout is unchanged in both cases.
Real run on a Small CPU endpoint with stderr redirected:
The
--helpfor both commands now also says that they wait by default (up to--timeout), and points to--no-waitplusserving-endpoints get.This is a hand-written override (
cmd/workspace/serving-endpoints/overrides.go), because the generated wait only readsstate.config_update. It reuses the generated flags and--jsonhandling, so the request sent to the API doesn't change.Why
In agent trials of a train → register → serve → query journey, every agent's
serving-endpoints createcall blocked for 7-9 minutes with no output and hit its tool timeout. Each agent then wrote its ownserving-endpoints getpolling loop. The per-entitydeployment_state_messagealready says which phase the endpoint is in; the CLI just never showed it.Backward compatibility
serving-endpoints createpass without regenerating their outputs.Tests
current statustext) and for non-TTY deduplication.acceptance/cmd/workspace/serving-endpointsforcreate,create --no-wait,update-configand--help.go test ./acceptance -run 'TestAccept/bundle/deployment/bind/model-serving-endpoint|TestAccept/bundle/resources/model_serving_endpoints'passes unchanged../task lintpasses.This pull request and its description were written by Isaac.