Repository navigation
aitools: test that the install hint stays quiet after a project-scoped install - #7667
Merged
Merged
Conversation
anshul0713
enabled auto-merge
November 16, 2026 07:57
idelafuente-oc
pushed a commit
to idelafuente-oc/cli
that referenced
this pull request
Nov 16, 2026
Label `aitools` PRs, the largest group of PRs without a product label. Examples: databricks#7549, databricks#7474, databricks#7667. This pull request and its description were written by Isaac. Co-authored-by: Isaac <no-reply@databricks.com>
anshul0713
force-pushed
the
anshul0713/aitools-hint-project-scope
branch
from
November 16, 2026 16:50
06694ad to
31e2b37
Compare
…d install #7585 made the hint ask DatabricksTooling, which already walks Claude's project skills dirs, so the false "skills are not installed" warning an agent hit right after `aitools install --scope project` is fixed. The hint tests cover project-scoped plugins and HOME skills but not this layout, so add regression tests for a project install (relative symlink from .claude/skills into .databricks/aitools/skills) seen from the project root and from a subdirectory of the repository. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
MaybeHint gained a pluginRecorded argument in #7586. Co-authored-by: Isaac <no-reply@databricks.com>
anshul0713
force-pushed
the
anshul0713/aitools-hint-project-scope
branch
from
November 17, 2026 09:02
1a84013 to
880de6d
Compare
lennartkats-db
approved these changes
Nov 18, 2026
Collaborator
❌ Integration test reportCommit: e4e790c
1290 interesting tests: 1262 MISS, 11 FAIL, 9 RECOVERED, 6 PANIC, 2 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test-only: adds
TestMaybeHint_ProjectSkillsInstalledSilentandTestMaybeHint_ProjectSkillsInParentOfRepoSubdirSilent. They lay out an install the waydatabricks aitools install --scope projectdoes (a relative symlink from.claude/skills/<skill>to the project's.databricks/aitools/skills/<skill>). Then they check that the "Databricks skills are not installed" hint stays quiet, both from the project root and from a subdirectory of the repository.Why
A coding agent in an AI Runtime trial ran
databricks aitools install --scope project. The very next command,databricks air list, said skills were not installed and suggested reinstalling. This PR originally fixed that inclaudeToolingInstalled. #7585 has since made the hint askDatabricksTooling, which already walks Claude's project skills folders, so the fix is no longer needed.The hint tests cover project-scoped plugins and skills under HOME, but not a project-scoped skills install, so I kept the regression tests. Both fail on the commit before #7585.
Tests
go test ./libs/aitools/...passes.This pull request and its description were written by Isaac.