Repository navigation
acc: unset OMNIGENT so the host's meta-harness does not leak into user agents - #7670
Merged
Merged
Conversation
…r agents The SDK reports a meta-harness/<name> user-agent dimension when OMNIGENT is set. Running the acceptance suite from an Omnigent session added meta-harness/omnigent to every recorded User-Agent and failed 37 tests. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: d0974af
|
andrewnester
approved these changes
Nov 16, 2026
Contributor
Author
|
Follow-ups (out of scope for this PR), from an adversarial review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
OMNIGENTto the env vars the acceptance runner unsets.Why
Since SDK v0.199 the user agent carries a
meta-harness/<name>dimension whenOMNIGENTis set. Running the suite from an Omnigent session addedmeta-harness/omnigentto every recorded User-Agent and failed 37 tests.Tests
TestAccept/cmd/api,TestAccept/bundle/migrateandTestAccept/bundle/user_agentpass withOMNIGENTset; they failed before.Found while generating test coverage for an analysis of coverage gaps in the CLI.
This pull request and its description were written by Isaac.