Skip to content

acc: unset OMNIGENT so the host's meta-harness does not leak into user agents - #7670

Merged
denik merged 1 commit into
mainfrom
denik/acc-unset-omnigent
Nov 16, 2026
Merged

denik merged 1 commit into
mainfrom
denik/acc-unset-omnigent

Conversation

@denik

@denik denik commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Add OMNIGENT to the env vars the acceptance runner unsets.

Why

Since SDK v0.199 the user agent carries a meta-harness/<name> dimension when OMNIGENT is set. Running the suite from an Omnigent session added meta-harness/omnigent to every recorded User-Agent and failed 37 tests.

Tests

TestAccept/cmd/api, TestAccept/bundle/migrate and TestAccept/bundle/user_agent pass with OMNIGENT set; they failed before.

Found while generating test coverage for an analysis of coverage gaps in the CLI.

This pull request and its description were written by Isaac.

…r agents

The SDK reports a meta-harness/<name> user-agent dimension when OMNIGENT is
set. Running the acceptance suite from an Omnigent session added
meta-harness/omnigent to every recorded User-Agent and failed 37 tests.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik requested a review from a team as a code owner November 16, 2026 10:28
@github-actions github-actions Bot added the test-only-fix PRs that update failing of flaky tests without changing CLI code. label Nov 16, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: d0974af

Run: 43849437285

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 7:18
💚​ aws-windows-latest-4core-16gb 1 272 13 9:46
💚​ azure linux-2core-8gb 1 269 15 6:30
💚​ azure-windows-latest-4core-16gb 1 271 13 8:42
💚​ gcp linux-2core-8gb 1 270 15 7:27
💚​ gcp-windows-latest-4core-16gb 1 272 13 12:58
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R

@denik

denik commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Follow-ups (out of scope for this PR), from an adversarial review:

  • The unset list is hand-synced with the SDK's unexported listKnownAgents() / listKnownMetaHarnesses(); the next SDK bump that adds a variable breaks the suite the same way.
  • No acceptance test pins the new meta-harness/<name> user-agent dimension (e.g. set OMNIGENT in a bundle/user_agent script).

@denik
denik added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit d790471 Nov 16, 2026
28 checks passed
@denik
denik deleted the denik/acc-unset-omnigent branch November 16, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-only-fix PRs that update failing of flaky tests without changing CLI code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants