Repository navigation
task cover: merge acceptance coverage in batches - #7671
Merged
Merged
Conversation
A full acceptance run writes one GOCOVERDIR per test (3.5k dirs). Joining them into a single -i argument for covdata merge produced a 228KB argument, over Linux's 128KB per-argument limit, so the merge failed with "argument list too long" and coverage-acceptance.txt was never written. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
approved these changes
Nov 16, 2026
Collaborator
✅ Integration test reportCommit: 6cff8ea
|
andrewnester
approved these changes
Nov 16, 2026
Contributor
Author
|
Follow-ups (out of scope for this PR), from an adversarial review:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Merge the per-test GOCOVERDIRs in batches of 500 in
task cover.Why
A full acceptance run writes one GOCOVERDIR per test (3.5k dirs). Joined into a single
-iargument that's 228KB, over Linux's 128KB per-argument limit, so the merge failed withargument list too longandcoverage-acceptance.txtwas never written.Tests
Ran the new merge steps via
taskover a real 3,551-dir run; the resultingcoverage-acceptance.txtis identical to a manual merge.Found while generating test coverage for an analysis of coverage gaps in the CLI.
This pull request and its description were written by Isaac.