Skip to content

task cover: merge acceptance coverage in batches - #7671

Merged
denik merged 1 commit into
mainfrom
denik/task-cover-batch-merge
Nov 16, 2026
Merged

denik merged 1 commit into
mainfrom
denik/task-cover-batch-merge

Conversation

@denik

@denik denik commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Merge the per-test GOCOVERDIRs in batches of 500 in task cover.

Why

A full acceptance run writes one GOCOVERDIR per test (3.5k dirs). Joined into a single -i argument that's 228KB, over Linux's 128KB per-argument limit, so the merge failed with argument list too long and coverage-acceptance.txt was never written.

Tests

Ran the new merge steps via task over a real 3,551-dir run; the resulting coverage-acceptance.txt is identical to a manual merge.

Found while generating test coverage for an analysis of coverage gaps in the CLI.

This pull request and its description were written by Isaac.

A full acceptance run writes one GOCOVERDIR per test (3.5k dirs). Joining
them into a single -i argument for covdata merge produced a 228KB
argument, over Linux's 128KB per-argument limit, so the merge failed with
"argument list too long" and coverage-acceptance.txt was never written.

Co-authored-by: Isaac <no-reply@databricks.com>
@denik
denik requested a review from a team as a code owner November 16, 2026 10:28
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: 6cff8ea

Run: 43849219373

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 6:03
💚​ aws-windows-latest-4core-16gb 1 272 13 9:57
💚​ azure linux-2core-8gb 1 269 15 5:49
💚​ azure-windows-latest-4core-16gb 1 271 13 8:43
💚​ gcp linux-2core-8gb 1 270 15 5:37
💚​ gcp-windows-latest-4core-16gb 1 272 13 13:27
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R

@denik

denik commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Follow-ups (out of scope for this PR), from an adversarial review:

  • Batching by byte length (or a batch of ~200) would also stay under Windows' 32K command-line limit and survive very long test names; task cover isn't used in CI today, so not urgent.

@denik
denik added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit cf9538e Nov 16, 2026
38 checks passed
@denik
denik deleted the denik/task-cover-batch-merge branch November 16, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants