Repository navigation
acc: record that apps import does not inline app.yml - #7689
Conversation
The app's app.yml has a plain env value, a valueFrom reference and an unquoted value that YAML reads as a number. Today databricks.yml gets no config and app.yml is kept as is, although the command means to inline it. Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
…test On Windows, Git Bash turns a leading-/ argument into a Windows path, so import-dir and apps deploy got C:/Program Files/Git/Workspace/... and failed. Disable the conversion for those two commands. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
|
Windows: PR CI skips Windows for Follow-ups (out of scope for this PR), from an adversarial review:
|
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
No blocking or major issues found.
| # valueFrom reference and an unquoted value that YAML reads as a number. | ||
| # MSYS_NO_PATHCONV keeps Git Bash on Windows from rewriting the /Workspace path. | ||
| APP_PATH="/Workspace/Users/$CURRENT_USER_NAME/myapp" | ||
| MSYS_NO_PATHCONV=1 $CLI workspace import-dir src "$APP_PATH" > /dev/null |
There was a problem hiding this comment.
[AI Generated] nit: Setup output from import-dir, apps create and apps deploy goes to /dev/null; testing.md asks for LOG.<name> so it shows under go test -v. Can these append to LOG.setup?
There was a problem hiding this comment.
Done in bf226f9: the three setup commands append to LOG.setup.
| fi | ||
|
|
||
| title "App config the bundle deploys (app.yml, if kept, is uploaded with the source)" | ||
| cd out |
There was a problem hiding this comment.
[AI Generated] nit: cd out / cd .. re-implements the withdir helper. Can this be withdir out trace $CLI bundle validate -o json | jq ..., as in acceptance/bundle/variables/sensitive/script:2?
There was a problem hiding this comment.
Done in bf226f9: withdir out trace $CLI bundle validate -o json | jq ...; output.txt is unchanged.
Co-authored-by: Isaac <no-reply@databricks.com>
macOS runners have bash 3.2, which has no &>>. Co-authored-by: Isaac <no-reply@databricks.com>
Changes
Add acceptance test
acceptance/apps/import/app-yml:apps importof an app whoseapp.ymlhas a plain env value, avalueFromreference and an unquoted value YAML reads as a number (3.10). It records the generateddatabricks.yml, what is left on disk, and the appconfigthe imported bundle deploys.Why
apps importmeans to inlineapp.ymlintodatabricks.ymlas the app'sconfigand remove it, but it looks forapp.ymlbefore the source files are downloaded, so it never finds it:databricks.ymlgets noconfigandapp.ymlstays. The test pins that (with aBadnessnote) so a change to the inlining shows up as a golden diff. #7675 is the attempt to make inlining run, and this test shows what it changes.Tests
Test-only. Passes 20/20 runs locally. PR CI skips Windows for
acceptance/apps/**; the script disables Git Bash path conversion for its two/Workspacearguments, and #7675 (stacked on this, touchescmd/apps) runs the same script on Windows.Found by analyzing test coverage gaps: the code path was not covered by any test.
This pull request and its description were written by Isaac.