Repository navigation
acc: share the CI env unset in an unset_ci_env helper #7691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,3 +197,12 @@ readplanarg() { | |
| printf "" | ||
| fi | ||
| } | ||
|
|
||
| # unset_ci_env clears CI and the CI/CD provider markers, so a test behaves the | ||
| # same in CI as on a laptop. The provider list mirrors listCiCdProviders in the | ||
| # Go SDK's useragent/cicd.go (read by useragent.CiCdProvider()); keep it in | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] The sync note names |
||
| # sync when the SDK adds a provider. PROJECT_ID alone defeats the Google Cloud | ||
| # Build check, which requires all of its variables. | ||
| unset_ci_env() { | ||
| unset CI GITHUB_ACTIONS GITLAB_CI JENKINS_URL TF_BUILD CIRCLECI TRAVIS BITBUCKET_BUILD_NUMBER PROJECT_ID CODEBUILD_BUILD_ARN TFC_RUN_ID | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: this duplicates the comment on
unset_ci_envinacceptance/script.prepare. I'd drop it here and inacceptance/cmd/aitools/telemetry/hint/script.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 13578d5: I dropped the comment from both aitools scripts. I left
air/image-pushalone because its comment explains why the CI vars matter in that test specifically.