Repository navigation
Report config-remote-sync selector misses under their own telemetry category - #7693
ilyakuz-db wants to merge 4 commits into
Conversation
…ategory Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
|
Commit: Regression test reportSelected 2 changed tests (limit=20, 0 not selected) 3 tests: regression=3 unreleased=0 coverage=0 failing=0
TestAccept/bundle/config-remote-sync/json_status_selectors/DMS=: branch ✅ | main (1511899) ❌ | latest (v1.27.0) ❌main (1511899): latest (v1.27.0): same output as main (1511899) TestAccept/bundle/config-remote-sync/json_status_selectors/DMS=true: branch ✅ | main (1511899) ❌ | latest (v1.27.0) ❌main (1511899): latest (v1.27.0): same output as main (1511899) TestAccept/bundle/telemetry/config-remote-sync-no-matching-selector/DMS=: branch ✅ | main (1511899) ❌ | latest (v1.27.0) ❌main (1511899): latest (v1.27.0): same output as main (1511899) |
✅ Integration test reportCommit: d742b69
Top 5 slowest tests (at least 2 minutes):
|
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
Co-authored-by: Isaac <no-reply@databricks.com>
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Follow-up review by review-factory (Claude Fable 5.2 + Claude Opus 5.5, cross-verified). Only points the reviewers agreed on are posted.
Earlier findings: 1 fixed.
No new issues found.
|
@Sankalp-Mittal can you stamp? |
Sankalp-Mittal
left a comment
There was a problem hiding this comment.
[AI Generated] Review by review-factory (Claude Opus 5.5 + Claude Fable 5.2, cross-verified). Only points the reviewers agreed on are posted.
No issues found.
Changes
bundle config-remote-sync --select-idsnow records a newNO_MATCHING_SELECTORtelemetry error category when none of the selected resources is in the deployed state. The JSON output carries the sameerrorCodenext tostatus: skipped.Why
Those runs are reported as skipped, not failed, but telemetry had no category for them, so they fell back to
BUNDLE_LOAD_FAILEDand counted toward the sync failure rate. With their own category, they can be left out of it.Tests
New acceptance test selects a job id that isn't deployed and checks the JSON output and the telemetry payload; updated the
json_status_selectorsgolden. The config-remote-sync acceptance tests, theconfigsync/cmd/bundleunit tests and lint pass locally.25ca011d742b69(latest)d742b69(latest)d742b69(no issues found), no approval yetbeaf1d0d742b69(latest)✅ success · ⏳ pending ·⚠️ warning · ❌ failed · ➖ n/a
This pull request and its description were written by Isaac.