Repository navigation
Add an opt-in Git branch freshness check for bundle deployments - #7696
Open
idelafuente-oc wants to merge 1 commit into
Open
idelafuente-oc wants to merge 1 commit into
idelafuente-oc wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Thanks for the contribution! This pull request was opened from a fork. If you're a member of the Databricks organization, please request access to the If you're an external contributor, no action is needed; a maintainer will review your pull request. |
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
experimental.check_git_branch_freshnessto warn and request confirmation when the current branch is behind its upstream. The check also runs for saved-plan deployments.Why
This helps prevent accidental deployments from stale branches. While a predeploy script can provide the same check, a built-in option may be simpler to configure and more consistent across platforms.
If freshness cannot be determined, deployment continues with a warning. Non-interactive deployments can use
--auto-approve, which also approves other deployment actions.This is an exploratory PR. Looking for feedback on whether this is something the Databricks CLI team would be interested in pursuing.
Tests
go test ./bundle/phases -run '^TestCheckGitBranchFreshness' -count=1— passed.go test ./acceptance -run '^TestAccept/bundle/deploy/git-freshness$' -count=1— passed.