Repository navigation
air: Disable MLflow artifact log fallback by default - #7697
Draft
ethanma-db wants to merge 2 commits into
Draft
ethanma-db wants to merge 2 commits into
ethanma-db wants to merge 2 commits into
Conversation
Collaborator
✅ Integration test reportCommit: 34969f2
Top 16 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Use Bricklens for AIR log streaming and downloads by default. Empty streams no longer probe MLflow, and unavailable Bricklens logs surface an error instead of silently switching backends.
Temporarily restore the legacy artifact fallback and artifact downloads with
DATABRICKS_AIR_ENABLE_MLFLOW_LOG_FALLBACK=true. The default download path pages all node logs without the streaming tail cap and preserves partial files on fetch failures.Why
The MLflow artifact ingestion path is being removed now that Bricklens logging is standard. Retain an environment-variable workaround during the transition, as agreed in the Slack discussion.
Related: #7621.
Tests
golangci-lint run ./cmd/air/...: 0 issues.tools/validate_nextchanges.py: passed.env -u DATABRICKS_CONFIG_PROFILE DATABRICKS_CONFIG_FILE=/dev/null go test ./cmd/air/...(161 s). The isolated config prevents the developer profile from supplying a workspace ID to URL tests.