Repository navigation
Remove the launch-stage override for Postgres bundle resources - #7705
Draft
janniklasrose wants to merge 2 commits into
Draft
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
Empty launchStageOverrides so Postgres resources render at the stage the upstream contract assigns, which is GA. The override mechanism stays in place for future use; the parser tests that asserted the Postgres pins are removed and the override unit test installs its own fixture. Regenerated bundle/schema/jsonschema.json and the PyDABs bindings, which now include the Postgres resources since codegen skips Beta resources. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: d61d4b2
Top 15 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Empty
launchStageOverridesinbundle/internal/annotation/preview.go, which pinned everypostgres_*bundle resource to[Beta](andpostgres_data_apisto[Private Preview]). The override mechanism itself (OverrideLaunchStageand its use in the schema parser) is kept; only the data is removed.Consequences, all from regenerating (
./task generate-schema,./task pydabs-codegen):bundle/schema/jsonschema.json: thepostgres_*resources now render at the stage the upstream contract assigns, which is GA. The[Beta]description prefix and the type-levelx-databricks-launch-stageare gone.postgres_data_apisloses its type-levelPRIVATE_PREVIEWstamp anddoNotSuggest, because the contract carries no type-level stage; that label came only from the override. Its individual fields that the contract marks Private Preview keep that label.postgres_*resources (python/databricks/bundles/postgres_*, core wiring, generated tests, docs).Tests: the parser tests that asserted every Postgres resource has an override (
TestPostgresResourcesHaveLaunchStageOverride,TestExtractAnnotationsOverridesLaunchStage,TestExtractAnnotationsStampsTypeLaunchStage) are removed, since that is the behaviour being undone.TestOverrideLaunchStagemoves to an internal test that installs its own override so the raising and more-restrictive paths stay covered.Why
The pin was added in #6226 to keep the
[Beta]label while the Postgres API moved to GA.TODO: explain why the pin is being removed now.
Tests
go test ./bundle/...passes../task generate-schema,./task generate-validation,./task generate-direct,./task pydabs-codegenrun; only the schema and the PyDABs bindings changed../task lint-qreports no issues../task pydabs-testfails:test_python_support_coveragerequires anacceptance/bundle/python/<plural>-support/fixture for each of the nine newly generated Postgres resources. Authoring those is effectively onboarding Lakebase resources to PyDABs, so it is not done here; either add the fixtures or keep the resources out of PyDABs codegen before this can merge.This pull request and its description were written by Isaac.