Skip to content

Remove the launch-stage override for Postgres bundle resources - #7705

Draft
janniklasrose wants to merge 2 commits into
mainfrom
janniklasrose/remove-postgres-beta-override
Draft

janniklasrose wants to merge 2 commits into
mainfrom
janniklasrose/remove-postgres-beta-override

Conversation

@janniklasrose

Copy link
Copy Markdown
Member

Changes

Empty launchStageOverrides in bundle/internal/annotation/preview.go, which pinned every postgres_* bundle resource to [Beta] (and postgres_data_apis to [Private Preview]). The override mechanism itself (OverrideLaunchStage and its use in the schema parser) is kept; only the data is removed.

Consequences, all from regenerating (./task generate-schema, ./task pydabs-codegen):

  • bundle/schema/jsonschema.json: the postgres_* resources now render at the stage the upstream contract assigns, which is GA. The [Beta] description prefix and the type-level x-databricks-launch-stage are gone.
  • postgres_data_apis loses its type-level PRIVATE_PREVIEW stamp and doNotSuggest, because the contract carries no type-level stage; that label came only from the override. Its individual fields that the contract marks Private Preview keep that label.
  • PyDABs codegen skips Beta and Private Preview resources, so it now generates all nine postgres_* resources (python/databricks/bundles/postgres_*, core wiring, generated tests, docs).

Tests: the parser tests that asserted every Postgres resource has an override (TestPostgresResourcesHaveLaunchStageOverride, TestExtractAnnotationsOverridesLaunchStage, TestExtractAnnotationsStampsTypeLaunchStage) are removed, since that is the behaviour being undone. TestOverrideLaunchStage moves to an internal test that installs its own override so the raising and more-restrictive paths stay covered.

Why

The pin was added in #6226 to keep the [Beta] label while the Postgres API moved to GA.

TODO: explain why the pin is being removed now.

Tests

  • go test ./bundle/... passes.
  • ./task generate-schema, ./task generate-validation, ./task generate-direct, ./task pydabs-codegen run; only the schema and the PyDABs bindings changed.
  • ./task lint-q reports no issues.
  • ./task pydabs-test fails: test_python_support_coverage requires an acceptance/bundle/python/<plural>-support/ fixture for each of the nine newly generated Postgres resources. Authoring those is effectively onboarding Lakebase resources to PyDABs, so it is not done here; either add the fixtures or keep the resources out of PyDABs codegen before this can merge.

This pull request and its description were written by Isaac.

janniklasrose and others added 2 commits November 16, 2026 20:45
Empty launchStageOverrides so Postgres resources render at the stage the
upstream contract assigns, which is GA. The override mechanism stays in
place for future use; the parser tests that asserted the Postgres pins
are removed and the override unit test installs its own fixture.

Regenerated bundle/schema/jsonschema.json and the PyDABs bindings, which
now include the Postgres resources since codegen skips Beta resources.

Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
@github-actions github-actions Bot added DABs DABs related issues PyDABs labels Nov 16, 2026
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: d61d4b2

Run: 43953497453

Env 🔄​flaky 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 270 15 9:32
💚​ aws-windows-latest-4core-16gb 1 272 13 8:41
💚​ azure linux-2core-8gb 1 269 15 11:08
💚​ azure-windows-latest-4core-16gb 1 271 13 9:34
🔄​ gcp linux-2core-8gb 1 1 269 15 10:43
🔄​ gcp-windows-latest-4core-16gb 1 1 271 13 10:23
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🔄​ TestSyncIncrementalFileSync ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestSyncIncrementalSyncFileToPythonNotebook ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
Top 15 slowest tests (at least 2 minutes):
duration env testname
4:03 aws-windows-latest-4core-16gb TestAccept
3:52 gcp-windows-latest-4core-16gb TestAccept
3:47 azure-windows-latest-4core-16gb TestAccept
3:31 azure-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
3:16 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsDelete
3:06 gcp-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:55 azure-windows-latest-4core-16gb TestImportDir
2:52 aws linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:39 aws-windows-latest-4core-16gb TestFilerWorkspaceNotebook/scalaNb.scala
2:26 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsDelete
2:25 gcp linux-2core-8gb TestFilerRecursiveDelete/workspace_files
2:22 azure linux-2core-8gb TestImportDirWithOverwriteFlag
2:19 azure-windows-latest-4core-16gb TestFilerWorkspaceFilesExtensionsReadDir
2:05 azure linux-2core-8gb TestImportDirDoesNotOverwrite
2:01 azure-windows-latest-4core-16gb TestImportDirDoesNotOverwrite

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues PyDABs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants