Skip to content

Redact sensitive variables from bundle plan and saved plans - #7713

Open
andrewnester wants to merge 6 commits into
mainfrom
feat/plan-secret-redaction
Open

andrewnester wants to merge 6 commits into
mainfrom
feat/plan-secret-redaction

Conversation

@andrewnester

@andrewnester andrewnester commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • bundle plan output (text and -o json) and the saved plan file no longer contain sensitive variable values. The plan's new_state is redacted once planning is done, alongside remote_state and changes.
  • bundle deploy --plan restores sensitive fields from the current config and fails before approval when a value is missing. For every sensitive field: a non-empty config value is restored; a non-zero planned value with an empty config value is an error; both empty is skipped (output-only fields).
  • One pre-approval check, CheckSensitivePlanValues, reports one error per problem. It looks at the resolved config value of each sensitive field the plan sets, so a value from --var, BUNDLE_VAR_<name>, a default, a target or the variable-overrides file all count. Sensitive variables that no planned resource uses need no value.
  • deploy --plan applies the sensitive values supplied at deploy time. They are not compared with the values used at plan time, so a saved plan can be applied with a different secret value than was planned.
  • The prepareChanges warning no longer prints change values. It previously showed old, new and remote values before redaction at the default log level.

Why

Fixes #7685. bundle plan and bundle deploy showed and stored sensitive variable values that bundle validate -o json already redacts. Since a saved plan no longer carries them, deploy --plan needs the values supplied again, and it applies the values given at deploy time, not those at plan time.

Tests

  • Unit (bundle/direct/redact_test.go): the restore table covers marker and plaintext replaced, zero in plan but set in config restored, both zero skipped, empty config value error, missing resource error, and nested paths. The check table covers a plan without sensitive resources, a set or zero value passing, and an empty config value. A separate test checks one error per resource.
  • Acceptance bundle/variables/sensitive/plan-derived: unused sensitive variables with a derived default, a literal default, and a dev-target value need no value, and a saved plan deploys with the credential from the variable-overrides file.
  • Acceptance bundle/variables/sensitive/plan: literals are absent from plan output, the saved plan and local state; a saved-plan deploy requires the values again; an empty value fails with no state-changing request; a plain-path create with real values; a rotate step where only the PATCH carries the new value. The test fails on main without this change.
  • Full acceptance suite and lint pass.

This pull request and its description were written by Isaac.

bundle plan no longer prints or saves sensitive values: new_state is
redacted once planning is done. A saved plan does not carry them, so
deploy --plan requires every sensitive variable of the bundle to be set
with --var or BUNDLE_VAR_<name>, and restores each sensitive field from
the config when the config sets it. One check runs before approval and
reports all missing values in one error. The prepareChanges warning no
longer prints the change values, which were visible before redaction.

Co-authored-by: Isaac <no-reply@databricks.com>
@andrewnester
andrewnester requested review from a team as code owners November 17, 2026 09:43
@andrewnester
andrewnester requested a review from denik November 17, 2026 09:43
Co-authored-by: Isaac <no-reply@databricks.com>
@andrewnester
andrewnester force-pushed the feat/plan-secret-redaction branch from a9836b9 to 614d281 Compare November 17, 2026 09:44
@github-actions github-actions Bot added the DABs DABs related issues label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Commit: fcecb403f | Workflow run

Regression test report

Selected 2 changed tests (limit=20, 0 not selected)

4 tests: regression=4 unreleased=0 coverage=0 failing=0
test branch main (36fdeb1) latest (v1.27.0)
TestAccept/bundle/variables/sensitive/plan-derived/DMS= ✅ ❌ ❌
TestAccept/bundle/variables/sensitive/plan-derived/DMS=true ✅ ❌ ❌
TestAccept/bundle/variables/sensitive/plan/DMS= ✅ ❌ ❌
TestAccept/bundle/variables/sensitive/plan/DMS=true ✅ ❌ ❌
TestAccept/bundle/variables/sensitive/plan-derived/DMS=: branch ✅ | main (36fdeb1) ❌ | latest (v1.27.0) ❌

main (36fdeb1):

acceptance_test.go:1402: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1402
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1143
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:704
        	Error:      	Not equal: 
        	            	expected: "\n=== bundle plan -o json, saved to a file\n\n>>> jq -S .plan | map_values(.new_state) .databricks/plan.json\n{\n  \"resources.secrets.credential_secret\": {\n    \"value\": {\n      \"catalog_name\": \"main\",\n      \"name\": \"credential_secret\",\n      \"schema_name\": \"default\",\n      \"value\": \"[redacted]\"\n    }\n  }\n}\n\n=== deploy from the saved plan with the credential in the variable-overrides file\n\n>>> env -u BUNDLE_VAR_api_credential [CLI] bundle deploy --plan .databricks/plan.json\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/dev/files...\nCreated secrets.credential_secret\nFiles: 1 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\n\n=== requests carrying a secret literal: path, name and value\n{\"path\":\"/api/2.1/unity-catalog/secrets\",\"name\":\"credential_secret\",\"value\":\"dummy-credential\"}\n"
        	            	actual  : "\n=== bundle plan -o json, saved to a file\n\n>>> jq -S .plan | map_values(.new_state) .databricks/plan.json\n{\n  \"resources.secrets.credential_secret\": {\n    \"value\": {\n      \"catalog_name\": \"main\",\n      \"name\": \"credential_secret\",\n      \"schema_name\": \"default\",\n      \"value\": \"[redacted]\"\n    }\n  }\n}\n\n=== deploy from the saved plan with the credential in the variable-overrides file\n\n>>> env -u BUNDLE_VAR_api_credential [CLI] bundle deploy --plan .databricks/plan.json\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/dev/files...\nCreated secrets.credential_secret\nFiles: 1 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\n\n=== requests carrying a secret literal: path, name and value\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -24,3 +24,2 @@
        	            	 === requests carrying a secret literal: path, name and value
        	            	-{"path":"/api/2.1/unity-catalog/secrets","name":"credential_secret","value":"dummy-credential"}
        	            	 
        	Test:       	TestAccept/bundle/variables/sensitive/plan-derived/DMS=
        	Messages:   	bundle/variables/sensitive/plan-derived/output.txt vs /tmp/TestAcceptbundlevariablessensitiveplan-derivedDMS=3018800865/002/output.txt

latest (v1.27.0): same output as main (36fdeb1)

TestAccept/bundle/variables/sensitive/plan-derived/DMS=true: branch ✅ | main (36fdeb1) ❌ | latest (v1.27.0) ❌

main (36fdeb1):

acceptance_test.go:1402: 
        	Error Trace:	/home/runner/work/cli/cli/libs/testdiff/testdiff.go:22
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1402
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:1143
        	            				/home/runner/work/cli/cli/acceptance/acceptance_test.go:704
        	Error:      	Not equal: 
        	            	expected: "\n=== bundle plan -o json, saved to a file\n\n>>> jq -S .plan | map_values(.new_state) .databricks/plan.json\n{\n  \"resources.secrets.credential_secret\": {\n    \"value\": {\n      \"catalog_name\": \"main\",\n      \"name\": \"credential_secret\",\n      \"schema_name\": \"default\",\n      \"value\": \"[redacted]\"\n    }\n  }\n}\n\n=== deploy from the saved plan with the credential in the variable-overrides file\n\n>>> env -u BUNDLE_VAR_api_credential [CLI] bundle deploy --plan .databricks/plan.json\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/dev/files...\nCreated secrets.credential_secret\nFiles: 1 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\n\n=== requests carrying a secret literal: path, name and value\n{\"path\":\"/api/2.1/unity-catalog/secrets\",\"name\":\"credential_secret\",\"value\":\"dummy-credential\"}\n"
        	            	actual  : "\n=== bundle plan -o json, saved to a file\n\n>>> jq -S .plan | map_values(.new_state) .databricks/plan.json\n{\n  \"resources.secrets.credential_secret\": {\n    \"value\": {\n      \"catalog_name\": \"main\",\n      \"name\": \"credential_secret\",\n      \"schema_name\": \"default\",\n      \"value\": \"[redacted]\"\n    }\n  }\n}\n\n=== deploy from the saved plan with the credential in the variable-overrides file\n\n>>> env -u BUNDLE_VAR_api_credential [CLI] bundle deploy --plan .databricks/plan.json\nUploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/dev/files...\nCreated secrets.credential_secret\nFiles: 1 uploaded, 0 deleted\nResources: 1 created, 0 changed, 0 deleted, 0 unchanged\n\n=== requests carrying a secret literal: path, name and value\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -24,3 +24,2 @@
        	            	 === requests carrying a secret literal: path, name and value
        	            	-{"path":"/api/2.1/unity-catalog/secrets","name":"credential_secret","value":"dummy-credential"}
        	            	 
        	Test:       	TestAccept/bundle/variables/sensitive/plan-derived/DMS=true
        	Messages:   	bundle/variables/sensitive/plan-derived/output.txt vs /tmp/TestAcceptbundlevariablessensitiveplan-derivedDMS=true1667306559/002/output.txt
FAIL

latest (v1.27.0): same output as main (36fdeb1)

TestAccept/bundle/variables/sensitive/plan/DMS=: branch ✅ | main (36fdeb1) ❌ | latest (v1.27.0) ❌

main (36fdeb1):

acceptance_test.go:1402: Diff:
        --- bundle/variables/sensitive/plan/output.txt
        +++ /tmp/TestAcceptbundlevariablessensitiveplanDMS=543722729/002/output.txt
        @@ -9,95 +9,6 @@
         Plan: 3 to add, 0 to change, 0 to delete, 0 unchanged
         
         === bundle plan -o json, saved to a file
        +contains error: 'dummy-credential' was not expected: '"value": "dummy-credential"'
         
        ->>> jq -S .plan | map_values(.new_state) .databricks/plan.json
        -{
        -  "resources.catalogs.audit_catalog": {
        -    "value": {
        -      "name": "audit_catalog"
        -    }
        -  },
        -  "resources.secrets.plain_secret": {
        -    "value": {
        -      "catalog_name": "main",
        -      "name": "plain_secret",
        -      "schema_name": "default",
        -      "value": "[redacted]"
        -    }
        -  },
        -  "resources.secrets.ref_secret": {
        -    "value": {
        -      "catalog_name": "audit_catalog",
        -      "name": "ref_secret",
        -      "schema_name": "default",
        -      "value": "[redacted]"
        -    }
        -  }
        -}
        -
        -=== deploy from the saved plan without the sensitive variable
        -
        ->>> env -u BUNDLE_VAR_api_header [CLI] bundle deploy --plan .databricks/plan.json
        -Error: no value assigned to required variable api_header. Variables are usually assigned in databricks.yml, and they can be overridden using "--var", the BUNDLE_VAR_api_header environment variable, or .databricks/bundle/<target>/variable-overrides.json
        -
        -
        -=== deploy from the saved plan with an empty sensitive variable
        -
        ->>> env BUNDLE_VAR_api_credential= [CLI] bundle deploy --plan .databricks/plan.json
        -Error: resource resources.secrets.ref_secret: the config has no value for sensitive field value; set the variable it uses with --var or BUNDLE_VAR_<name>
        -
        -state-changing requests sent by the failed deploy: 0
        -
        -=== deploy from the saved plan with the sensitive variables supplied
        -
        ->>> [CLI] bundle deploy --plan .databricks/plan.json
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Created catalogs.audit_catalog
        -Created secrets.plain_secret
        -Created secrets.ref_secret
        -Files: 1 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        -=== bundle destroy, then a plain bundle deploy creates the secrets again
        -
        ->>> [CLI] bundle destroy --auto-approve
        -The following resources will be deleted:
        -  delete resources.catalogs.audit_catalog
        -  delete resources.secrets.plain_secret
        -  delete resources.secrets.ref_secret
        -
        -All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default
        -
        -Destroy: 3 deleted
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Created catalogs.audit_catalog
        -Created secrets.plain_secret
        -Created secrets.ref_secret
        -Files: 1 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        -=== bundle plan -o json after deploy: remote_state holds the marker
        -
        ->>> jq -S .plan | map_values(.remote_state.value) .databricks/plan-after.json
        -{
        -  "resources.catalogs.audit_catalog": null,
        -  "resources.secrets.plain_secret": "[redacted]",
        -  "resources.secrets.ref_secret": "[redacted]"
        -}
        -
        -=== rotate the plain secret: plan and deploy with a new value
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Updated secrets.plain_secret
        -Files: 0 uploaded, 0 deleted
        -Resources: 0 created, 1 changed, 0 deleted, 2 unchanged
        -
        -=== requests carrying a secret literal: path, name and value
        -{"path":"/api/2.1/unity-catalog/secrets","name":"plain_secret","value":"dummy-header"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"plain_secret","value":"dummy-header"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"ref_secret","value":"dummy-credential"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"ref_secret","value":"dummy-credential"}
        -{"path":"/api/2.1/unity-catalog/secrets/main.default.plain_secret","name":"plain_secret","value":"dummy-rotated"}
        -
        -=== no secret value in the local state (the dump differs per DMS variant, so it is not shown)
        +Exit code: 1

latest (v1.27.0): same output as main (36fdeb1)

TestAccept/bundle/variables/sensitive/plan/DMS=true: branch ✅ | main (36fdeb1) ❌ | latest (v1.27.0) ❌

main (36fdeb1):

acceptance_test.go:1402: Diff:
        --- bundle/variables/sensitive/plan/output.txt
        +++ /tmp/TestAcceptbundlevariablessensitiveplanDMS=true2066542080/002/output.txt
        @@ -9,95 +9,6 @@
         Plan: 3 to add, 0 to change, 0 to delete, 0 unchanged
         
         === bundle plan -o json, saved to a file
        +contains error: 'dummy-credential' was not expected: '"value": "dummy-credential"'
         
        ->>> jq -S .plan | map_values(.new_state) .databricks/plan.json
        -{
        -  "resources.catalogs.audit_catalog": {
        -    "value": {
        -      "name": "audit_catalog"
        -    }
        -  },
        -  "resources.secrets.plain_secret": {
        -    "value": {
        -      "catalog_name": "main",
        -      "name": "plain_secret",
        -      "schema_name": "default",
        -      "value": "[redacted]"
        -    }
        -  },
        -  "resources.secrets.ref_secret": {
        -    "value": {
        -      "catalog_name": "audit_catalog",
        -      "name": "ref_secret",
        -      "schema_name": "default",
        -      "value": "[redacted]"
        -    }
        -  }
        -}
        -
        -=== deploy from the saved plan without the sensitive variable
        -
        ->>> env -u BUNDLE_VAR_api_header [CLI] bundle deploy --plan .databricks/plan.json
        -Error: no value assigned to required variable api_header. Variables are usually assigned in databricks.yml, and they can be overridden using "--var", the BUNDLE_VAR_api_header environment variable, or .databricks/bundle/<target>/variable-overrides.json
        -
        -
        -=== deploy from the saved plan with an empty sensitive variable
        -
        ->>> env BUNDLE_VAR_api_credential= [CLI] bundle deploy --plan .databricks/plan.json
        -Error: resource resources.secrets.ref_secret: the config has no value for sensitive field value; set the variable it uses with --var or BUNDLE_VAR_<name>
        -
        -state-changing requests sent by the failed deploy: 0
        -
        -=== deploy from the saved plan with the sensitive variables supplied
        -
        ->>> [CLI] bundle deploy --plan .databricks/plan.json
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Created catalogs.audit_catalog
        -Created secrets.plain_secret
        -Created secrets.ref_secret
        -Files: 1 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        -=== bundle destroy, then a plain bundle deploy creates the secrets again
        -
        ->>> [CLI] bundle destroy --auto-approve
        -The following resources will be deleted:
        -  delete resources.catalogs.audit_catalog
        -  delete resources.secrets.plain_secret
        -  delete resources.secrets.ref_secret
        -
        -All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default
        -
        -Destroy: 3 deleted
        -
        ->>> [CLI] bundle deploy
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Created catalogs.audit_catalog
        -Created secrets.plain_secret
        -Created secrets.ref_secret
        -Files: 1 uploaded, 0 deleted
        -Resources: 3 created, 0 changed, 0 deleted, 0 unchanged
        -
        -=== bundle plan -o json after deploy: remote_state holds the marker
        -
        ->>> jq -S .plan | map_values(.remote_state.value) .databricks/plan-after.json
        -{
        -  "resources.catalogs.audit_catalog": null,
        -  "resources.secrets.plain_secret": "[redacted]",
        -  "resources.secrets.ref_secret": "[redacted]"
        -}
        -
        -=== rotate the plain secret: plan and deploy with a new value
        -Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/sensitive-variables/default/files...
        -Updated secrets.plain_secret
        -Files: 0 uploaded, 0 deleted
        -Resources: 0 created, 1 changed, 0 deleted, 2 unchanged
        -
        -=== requests carrying a secret literal: path, name and value
        -{"path":"/api/2.1/unity-catalog/secrets","name":"plain_secret","value":"dummy-header"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"plain_secret","value":"dummy-header"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"ref_secret","value":"dummy-credential"}
        -{"path":"/api/2.1/unity-catalog/secrets","name":"ref_secret","value":"dummy-credential"}
        -{"path":"/api/2.1/unity-catalog/secrets/main.default.plain_secret","name":"plain_secret","value":"dummy-rotated"}
        -
        -=== no secret value in the local state (the dump differs per DMS variant, so it is not shown)
        +Exit code: 1

latest (v1.27.0): same output as main (36fdeb1)

andrewnester and others added 2 commits November 17, 2026 10:02
Co-authored-by: Isaac <no-reply@databricks.com>
The acceptance test checks that the literals stay out of plan output,
the saved plan and local state, that a saved plan needs the values
passed again, that an empty value fails before any state-changing
request, and that a rotated value reaches only the PATCH request.

Co-authored-by: Isaac <no-reply@databricks.com>
@andrewnester
andrewnester force-pushed the feat/plan-secret-redaction branch from 614d281 to 2212f0c Compare November 17, 2026 10:04
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Integration test report

Commit: fcecb40

Run: 44749575141

Env 💚​RECOVERED ✅​pass 🙈​skip Time
💚​ aws linux-2core-8gb 1 272 21 5:23
💚​ aws-windows-latest-4core-16gb 1 274 19 4:47
💚​ azure linux-2core-8gb 1 271 21 4:05
💚​ azure-windows-latest-4core-16gb 1 273 19 4:12
💚​ gcp linux-2core-8gb 1 272 21 5:09
💚​ gcp-windows-latest-4core-16gb 1 274 19 4:09
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
Top 3 slowest tests (at least 2 minutes):
duration env testname
4:10 azure-windows-latest-4core-16gb TestAccept
4:10 aws-windows-latest-4core-16gb TestAccept
4:07 gcp-windows-latest-4core-16gb TestAccept

@andrewnester

Copy link
Copy Markdown
Contributor Author

/review

@denik denik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design: the deploy value isn't tied to the plan value. deploy --plan now sends whatever value is supplied at deploy time, so it can differ from the planned one. For example, a plan updates a secret's comment, and at deploy time BUNDLE_VAR_x holds a different (wrong) value. The PATCH then sends a value nobody reviewed in the plan, and nothing warns. Would a salted fingerprint of each sensitive field in the plan work, with a check at deploy time that the supplied value matches and an error if not? That would keep "the saved plan is what gets applied" true. At minimum, the changelog should say this more strongly.

Comment thread bundle/direct/bundle_plan.go Resolved
Comment thread bundle/direct/bundle_plan.go Resolved
Comment thread bundle/direct/bundle_plan.go Resolved
Comment thread bundle/direct/bundle_plan.go Resolved
Comment thread bundle/direct/redact.go
return nil
}

if entry.NewState != nil {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule "the plan must not be serialized after this" is only stated in the comment, and nothing enforces it. If someone later re-serializes new_state from the cache after this point, the secrets leak silently. Could we assert it, or add a test that fails if new_state is non-redacted at output time?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not asserted in code, because makePlan has no unit-test harness in this package. The check is at output time instead: the variables/sensitive/plan acceptance case pipes bundle plan -o json and the saved plan file through a check that fails the test if a secret literal appears in them. A change that re-serializes unredacted new_state before output fails there. I can add a unit test on the serialized plan if you want one at that level.

Comment thread bundle/direct/bundle_plan.go Resolved
andrewnester and others added 2 commits November 20, 2026 13:33
deploy --plan rejected every sensitive variable that had no --var or
BUNDLE_VAR_ value, including variables a resource never uses and
variables set by a default, a target or the variable-overrides file.
The check now looks only at the resolved config value of each sensitive
field the plan sets, so every source of a value counts the same, and
the variable-overrides file is no longer a special case.

The check reports one error per problem, and it reads the adapter only
for resource types with sensitive fields. The acceptance case
variables/sensitive/plan-derived covers unused derived, literal-default
and target-set sensitive variables.

Co-authored-by: Isaac <no-reply@databricks.com>
@andrewnester

Copy link
Copy Markdown
Contributor Author

Thanks for the review. The changes for the other comments are in fcecb40.

On the design point (the deploy-time value is not tied to the plan-time value): this PR does not add a fingerprint. A fingerprint would change the saved plan format and store secret-derived data in the plan file, so it needs its own decision. Meanwhile the changelog and PR description now say explicitly that deploy --plan applies the sensitive values supplied at deploy time and does not compare them with the values used at plan time.

@andrewnester

Copy link
Copy Markdown
Contributor Author

Follow-up on the design point: the deploy-time value stays as documented in this PR (the plan format does not change). If a fingerprint check is wanted later, it can come as a separate PR with a plan-format version bump.

@andrewnester
andrewnester requested a review from denik November 20, 2026 14:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues factory-generated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Redact sensitive variables from bundle plan and deploy

3 participants